aboutsummaryrefslogtreecommitdiff
path: root/sys/kern/subr_unit.c
Commit message (Collapse)AuthorAgeFilesLines
* subr_unit.c: another attempt to fix the buildKonstantin Belousov2023-08-181-0/+4
| | | | | | Reported by: cy Sponsored by: The FreeBSD Foundation MFC after: 1 week
* kern/subr_unit.c: fix non-debug buildKonstantin Belousov2023-08-181-1/+1
| | | | | Sponsored by: The FreeBSD Foundation MFC after: 1 week
* sys: Remove $FreeBSD$: two-line .h patternWarner Losh2023-08-161-2/+0
| | | | Remove /^\s*\*\n \*\s+\$FreeBSD\$$\n/
* unr(9) iterator: add naive testKonstantin Belousov2023-05-291-2/+89
| | | | | | | | | | | To use, compile userspace code e.g. into the subr_unit binary, then do $ while ./subr_unit -iv >|/tmp/subr_unit.log ; do :; done The loop should be left run for as long as possible. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D40089
* unr(9): add 'show unrhdr_iter' commandKonstantin Belousov2023-05-291-0/+17
| | | | | | Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D40089
* unr(9): add iterator interfaceKonstantin Belousov2023-05-291-0/+121
| | | | | | | | Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D40089
* unr(9): add 'show unrhdr' ddb commandKonstantin Belousov2023-05-291-16/+43
| | | | | | Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D40089
* subr_unit.c: explain first/last special rangesKonstantin Belousov2023-05-291-0/+6
| | | | | | | | Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D40089
* kern/subr_unit.c: more uses for is_bitmap()Konstantin Belousov2023-05-291-7/+7
| | | | | | | | | | To facilitate it, move the is_bitmap() definition earlier. Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D40089
* kern/subr_unit.c: some styleKonstantin Belousov2023-05-291-2/+2
| | | | | | | | | | | Use NBBY instead of spelling '8' literally. Put space into the type specifier. Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D40089
* spdx: The BSD-2-Clause-FreeBSD identifier is obsolete, drop -FreeBSDWarner Losh2023-05-121-1/+1
| | | | | | | | | The SPDX folks have obsoleted the BSD-2-Clause-FreeBSD identifier. Catch up to that fact and revert to their recommended match of BSD-2-Clause. Discussed with: pfg MFC After: 3 days Sponsored by: Netflix
* unr: remove UNR64_LOCKEDMateusz Guzik2022-10-081-13/+0
| | | | All platforms support 64-bit atomics now.
* subr_unit.c: make userspace tests buildableKonstantin Belousov2022-04-281-0/+2
| | | | | | | by defining a placeholder for UNR_NO_MTX Sponsored by: The FreeBSD Foundation MFC after: 1 week
* unr(9): allow to avoid internal lockingKonstantin Belousov2022-04-271-14/+29
| | | | | | | | Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D35014
* init_unrhdr(): make it usable by initializing everythingKonstantin Belousov2022-04-271-0/+2
| | | | | | | | Reviewed by: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D35014
* kern: clean up empty lines in .c and .h filesMateusz Guzik2020-09-011-1/+0
| | | | Notes: svn path=/head/; revision=365222
* Remove duplicated empty lines from kern/*.cMateusz Guzik2020-01-301-4/+0
| | | | | | | No functional changes. Notes: svn path=/head/; revision=357312
* kern/subr_unit: Rip srandomdev, random(3) out of dead codeConrad Meyer2019-12-131-5/+3
| | | | | | | | | | | The simulation cannot be reproduced, so the value of using a deterministic PRNG like random(3) is dubious. The number of repitions used in the sample isn't a problem for the Chacha implementation of arc4random we have today. (Also, no one actually runs this code; it was provided as an example of the work the author did validating the implementation. It's not even test code.) Notes: svn path=/head/; revision=355694
* Implement unr64Mateusz Guzik2018-11-201-0/+13
| | | | | | | | | | | | | | | | Important users of unr like tmpfs or pipes can get away with just ever-increasing counters, making the overhead of managing the state for 32 bit counters a pessimization. Change it to an atomic variable. This can be further sped up by making the counts variable "allocate" ranges and store them per-cpu. Reviewed by: kib Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D18054 Notes: svn path=/head/; revision=340676
* sys/kern: adoption of SPDX licensing ID tags.Pedro F. Giffuni2017-11-271-0/+2
| | | | | | | | | | | | | | | Mainly focus on files that use BSD 2-Clause license, however the tool I was using misidentified many licenses so this was mostly a manual - error prone - task. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. Notes: svn path=/head/; revision=326271
* Properly reset the fields in clean_unrhdr.Matt Joras2017-10-161-5/+4
| | | | | | | | | | | | | | | In r324542 I neglected to reset the first and last fields of struct unrhdr. This causes a tmpfs to fail the unr(9) consistency checks with DIAGNOSTIC on. Fix this by resetting the fields by calling init_unrhdr. While here, change a loop to use TAILQ_FOREACH_SAFE since it is more readable and equally fast. Reported by: David Wolfskill <david@catwhisker.org> Approved by: rstone (mentor) Sponsored by: Dell EMC Isilon Notes: svn path=/head/; revision=324666
* Add clearing function for unr(9).Matt Joras2017-10-111-0/+21
| | | | | | | | | | | | | | | Previously before you could call unrhdr_delete you needed to individually free every allocated unit. It is useful to be able to tear down the unr without having to go through this process, as it is significantly faster than freeing the individual units. Reviewed by: cem, lidl Approved by: rstone (mentor) Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D12591 Notes: svn path=/head/; revision=324541
* Clean up trailing whitespaceEnji Cooper2017-01-141-6/+6
| | | | | | | | MFC after: 3 days Sponsored by: Dell EMC Isilon Notes: svn path=/head/; revision=312113
* Fix -Wunused on gcc 4.9 (x was set but not used)Enji Cooper2017-01-141-3/+2
| | | | | | | | MFC after: 3 days Sponsored by: Dell EMC Isilon Notes: svn path=/head/; revision=312112
* Fix build of kern/subr_unit.c, broken by r300539Alan Somers2016-05-241-3/+3
| | | | | | | | | Reported by: peter Pointyhat to: asomers Sponsored by: Spectra Logic Corp Notes: svn path=/head/; revision=300544
* Add bit_count to the bitstring(3) apiAlan Somers2016-05-231-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a bit_count function, which efficiently counts the number of bits set in a bitstring. sys/sys/bitstring.h tests/sys/sys/bitstring_test.c share/man/man3/bitstring.3 Add bit_alloc sys/kern/subr_unit.c Use bit_count instead of a naive counting loop in check_unrhdr, used when INVARIANTS are enabled. The userland test runs about 6x faster in a generic build, or 8.5x faster when built for Nehalem, which has the POPCNT instruction. sys/sys/param.h Bump __FreeBSD_version due to the addition of bit_alloc UPDATING Add a note about the ABI incompatibility of the bitstring(3) changes, as suggested by lidl. Suggested by: gibbs Reviewed by: gibbs, ngie MFC after: 9 days X-MFC-With: 299090, 300538 Relnotes: yes Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D6255 Notes: svn path=/head/; revision=300539
* Add explicit cast to fix mips and powerpc build after r299090Ed Maste2016-05-051-1/+1
| | | | | | | Sponsored by: The FreeBSD Foundation Notes: svn path=/head/; revision=299120
* Improve performance and functionality of the bitstring(3) apiAlan Somers2016-05-041-39/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two new functions are provided, bit_ffs_at() and bit_ffc_at(), which allow for efficient searching of set or cleared bits starting from any bit offset within the bit string. Performance is improved by operating on longs instead of bytes and using ffsl() for searches within a long. ffsl() is a compiler builtin in both clang and gcc for most architectures, converting what was a brute force while loop search into a couple of instructions. All of the bitstring(3) API continues to be contained in the header file. Some of the functions are large enough that perhaps they should be uninlined and moved to a library, but that is beyond the scope of this commit. sys/sys/bitstring.h: Convert the majority of the existing bit string implementation from macros to inline functions. Properly protect the implementation from inadvertant macro expansion when included in a user's program by prefixing all private macros/functions and local variables with '_'. Add bit_ffs_at() and bit_ffc_at(). Implement bit_ffs() and bit_ffc() in terms of their "at" counterparts. Provide a kernel implementation of bit_alloc(), making the full API usable in the kernel. Improve code documenation. share/man/man3/bitstring.3: Add pre-exisiting API bit_ffc() to the synopsis. Document new APIs. Document the initialization state of the bit strings allocated/declared by bit_alloc() and bit_decl(). Correct documentation for bitstr_size(). The original code comments indicate the size is in bytes, not "elements of bitstr_t". The new implementation follows this lead. Only hastd assumed "elements" rather than bytes and it has been corrected. etc/mtree/BSD.tests.dist: tests/sys/Makefile: tests/sys/sys/Makefile: tests/sys/sys/bitstring.c: Add tests for all existing and new functionality. include/bitstring.h Include all headers needed by sys/bitstring.h lib/libbluetooth/bluetooth.h: usr.sbin/bluetooth/hccontrol/le.c: Include bitstring.h instead of sys/bitstring.h. sbin/hastd/activemap.c: Correct usage of bitstr_size(). sys/dev/xen/blkback/blkback.c Use new bit_alloc. sys/kern/subr_unit.c: Remove hard-coded assumption that sizeof(bitstr_t) is 1. Get rid of unrb.busy, which caches the number of bits set in unrb.map. When INVARIANTS are disabled, nothing needs to know that information. callapse_unr can be adapted to use bit_ffs and bit_ffc instead. Eliminating unrb.busy saves memory, simplifies the code, and provides a slight speedup when INVARIANTS are disabled. sys/net/flowtable.c: Use the new kernel implementation of bit-alloc, instead of hacking the old libc-dependent macro. sys/sys/param.h Update __FreeBSD_version to indicate availability of new API Submitted by: gibbs, asomers Reviewed by: gibbs, ngie MFC after: 4 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D6004 Notes: svn path=/head/; revision=299090
* Automate the subr_unit test.Alan Somers2016-04-291-22/+67
| | | | | | | | | | | | | | | | | | | | | | Build and install the subr_unit test program originally written by phk, and run it with the other ATF tests. tests/sys/kern/Makefile * Build and install the subr_unit test as a plain test sys/kern/subr_unit.c * Reduce the default number of repetitions from 100 to 1, and add a command-line parser to override it. * Don't be so noisy by default * Fix an include problem for the test build Reviewed by: ngie MFC after: 4 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D6038 Notes: svn path=/head/; revision=298811
* Move the definition of the struct unrhdr into a separate header file,Konstantin Belousov2013-08-301-27/+18
| | | | | | | | | | | to allow embedding the struct. Add init_unrhdr(9) initializer, which sets up preallocated unrhdr. Reviewed by: alc Tested by: pho, bf Notes: svn path=/head/; revision=255057
* Correct double "the the"Eitan Adler2012-09-141-1/+1
| | | | | | | | Approved by: cperciva MFC after: 3 days Notes: svn path=/head/; revision=240518
* Fix typos - remove duplicate "the".Rebecca Cran2011-02-211-2/+2
| | | | | | | | | PR: bin/154928 Submitted by: Eitan Adler <lists at eitanadler.com> MFC after: 3 days Notes: svn path=/head/; revision=218909
* Remove redundant high >= 0.Jaakko Heinonen2010-07-091-1/+1
| | | | | | | Reported by: rstone Notes: svn path=/head/; revision=209844
* Assert that low and high are >= 0. The allocator doesn't support theJaakko Heinonen2010-07-081-2/+2
| | | | | | | negative range. Notes: svn path=/head/; revision=209816
* Extend the kernel unit number allocator for allocating specific unitJaakko Heinonen2010-07-051-13/+168
| | | | | | | | | | | | | | numbers. This change adds a new function alloc_unr_specific() which returns the requested unit number if it is free. If the number is already allocated or out of the range, -1 is returned. Update alloc_unr(9) manual page accordingly and add a MLINK for alloc_unr_specific(9). Discussed on: freebsd-hackers Notes: svn path=/head/; revision=209710
* Correct a comment typo.Jaakko Heinonen2010-06-271-1/+1
| | | | Notes: svn path=/head/; revision=209549
* - Fix compilation of the subr_unit.c user space test program.Jaakko Heinonen2010-06-171-3/+4
| | | | | | | - Use %zu for size_t in a few format strings. Notes: svn path=/head/; revision=209256
* Since cdev mutex is after system map mutex in global lock order, free()Konstantin Belousov2007-07-041-1/+34
| | | | | | | | | | | | | | | | | | | | | shall not be called while holding cdev mutex. devfs_inos unrhdr has cdev as mutex, thus creating this LOR situation. Postpone calling free() in kern/subr_unit.c:alloc_unr() and nested functions until the unrhdr mutex is dropped. Save the freed items on the ppfree list instead, and provide the clean_unrhdrl() and clean_unrhdr() functions to clean the list. Call clean_unrhdrl() after devfs_create() calls immediately before dropping cdev mutex. devfs_create() is the only user of the alloc_unrl() in the tree. Reviewed by: phk Tested by: Peter Holm LOR: 80 Approved by: re (kensmith) Notes: svn path=/head/; revision=171202
* Add the witness warning for free_unr. Function could sleep, thus callersKonstantin Belousov2007-06-191-0/+1
| | | | | | | | | | shall not have any non-sleepable locks held. Submitted by: Hans Petter Selasky <hselasky c2i net> Approved by: re (kensmith) Notes: svn path=/head/; revision=170949
* Remove debugging printfs.Poul-Henning Kamp2005-03-141-8/+3
| | | | Notes: svn path=/head/; revision=143550
* Reengineer subr_unitPoul-Henning Kamp2005-03-081-287/+511
| | | | | | | | | | | | | | | | | | Add support for passing in a mutex. If NULL is passed a global subr_unit mutex is used. Add alloc_unrl() which expects the mutex to be held. Allocating a unit will never sleep as it does not need to allocate memory. Cut possible range in half so we can use -1 to mean "out of number". Collapse first and last runs into the head by means of counters. This saves memory in the common case(s). Notes: svn path=/head/; revision=143283
* Add placeholder mutex argument to new_unrhdr().Poul-Henning Kamp2005-03-071-2/+2
| | | | Notes: svn path=/head/; revision=143238
* /* -> /*- for copyright notices, minor format tweaks as necessaryWarner Losh2005-01-061-2/+3
| | | | Notes: svn path=/head/; revision=139804
* Add delete_unrhdr() function.Poul-Henning Kamp2004-10-251-2/+19
| | | | | | | It will fail fatally if all allocated numbers have not been returned first. Notes: svn path=/head/; revision=136945
* Fix a typo to fix the !DIAGNOSTIC build.John Baldwin2004-09-301-1/+1
| | | | | | | Submitted by: many Notes: svn path=/head/; revision=135979
* Add a new API for allocating unit number (-like) resources.Poul-Henning Kamp2004-09-301-0/+597
Allocation is always lowest free unit number. A mixed range/bitmap strategy for maximum memory efficiency. In the typical case where no unit numbers are freed total memory usage is 56 bytes on i386. malloc is called M_WAITOK but no locking is provided (yet). A bit of experience will be necessary to determine the best strategy. Hopefully a "caller provides locking" strategy can be maintained, but that may require use of M_NOWAIT allocation and failure handling. A userland test driver is included. Notes: svn path=/head/; revision=135956
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-13 04:21:33 +0000