diff options
| author | Xin LI <delphij@FreeBSD.org> | 2017-06-19 07:02:52 +0000 |
|---|---|---|
| committer | Xin LI <delphij@FreeBSD.org> | 2017-06-19 07:02:52 +0000 |
| commit | df9abd97ac98d8bf50c06548eedcd8a69600243e (patch) | |
| tree | 821067406eba4a5a1c1cfaca5ebaacfbda08894c /usr.sbin/rpc.lockd | |
| parent | acd690d524f5c7528f8c96e27cdd23474e8e31c9 (diff) | |
| download | src-df9abd97ac98d8bf50c06548eedcd8a69600243e.tar.gz src-df9abd97ac98d8bf50c06548eedcd8a69600243e.zip | |
Check return value of seteuid() and bail out if we fail.
MFC after: 2 weeks
Notes
Notes:
svn path=/head/; revision=320093
Diffstat (limited to 'usr.sbin/rpc.lockd')
| -rw-r--r-- | usr.sbin/rpc.lockd/lock_proc.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/usr.sbin/rpc.lockd/lock_proc.c b/usr.sbin/rpc.lockd/lock_proc.c index 595d6254769c..3b040e5f14a0 100644 --- a/usr.sbin/rpc.lockd/lock_proc.c +++ b/usr.sbin/rpc.lockd/lock_proc.c @@ -276,7 +276,10 @@ get_client(struct sockaddr *host_addr, rpcvers_t vers) /* Regain root privileges, for bindresvport. */ old_euid = geteuid(); - seteuid(0); + if (seteuid(0) != 0) { + syslog(LOG_ERR, "seteuid(0) failed"); + return NULL; + } /* * Bind the client FD to a reserved port. @@ -285,7 +288,10 @@ get_client(struct sockaddr *host_addr, rpcvers_t vers) bindresvport(clnt_fd, NULL); /* Drop root privileges again. */ - seteuid(old_euid); + if (seteuid(old_euid) != 0) { + syslog(LOG_ERR, "seteuid(%d) failed", old_euid); + return NULL; + } /* Success - update the cache entry */ clnt_cache_ptr[clnt_cache_next_to_use] = client; |