diff options
author | Andrey A. Chernov <ache@FreeBSD.org> | 2001-03-27 15:53:48 +0000 |
---|---|---|
committer | Andrey A. Chernov <ache@FreeBSD.org> | 2001-03-27 15:53:48 +0000 |
commit | 6bea9ab43b92f0e9a94ca208064fd1a3f02c3ca2 (patch) | |
tree | 339fa66fced49745b7ab8b68ff8cb0830c673af4 /usr.bin/tail | |
parent | d92a0c0bde0045f5357ae9f6dd12ec05f9d62e5f (diff) | |
download | src-6bea9ab43b92f0e9a94ca208064fd1a3f02c3ca2.tar.gz src-6bea9ab43b92f0e9a94ca208064fd1a3f02c3ca2.zip |
Add comment explaining why size not passed directly to mmap, i.e. not relay
on its check.
KNF multi-line comments
(inspired by bde)
Notes
Notes:
svn path=/head/; revision=74863
Diffstat (limited to 'usr.bin/tail')
-rw-r--r-- | usr.bin/tail/forward.c | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/usr.bin/tail/forward.c b/usr.bin/tail/forward.c index cfcb535acc3a..ef046ccbd745 100644 --- a/usr.bin/tail/forward.c +++ b/usr.bin/tail/forward.c @@ -274,15 +274,21 @@ rlines(fp, off, sbp) if (!(size = sbp->st_size)) return; + /* + * size not passed directly to mmap() below because unclear error + * diagnostic "Invalid argument". + */ if (size > SIZE_T_MAX || size < 0) { errno = EFBIG; ierr(); exit(1); } - /* XXX: FIXME - mmap() not support files over 2Gb */ - /* Large file processing require alternative implementation */ - /* for now print nice error diagnostic at least */ + /* + * XXX: FIXME - mmap() not support files over 2GB + * Large file processing require alternative implementation, + * for now print nice error diagnostic at least. + */ if (size > SSIZE_MAX) { errno = EFBIG; ierr(); |