diff options
author | Jung-uk Kim <jkim@FreeBSD.org> | 2011-10-06 20:20:30 +0000 |
---|---|---|
committer | Jung-uk Kim <jkim@FreeBSD.org> | 2011-10-06 20:20:30 +0000 |
commit | 0007f669caf68d2abf6b924b82263d590ef63cce (patch) | |
tree | 207623c95f3c9b57f4b051189258dae9ca4f2087 /sys | |
parent | c15cdbf2f3f3d07195443516bf0b6b5d6ee2cc0e (diff) | |
download | src-0007f669caf68d2abf6b924b82263d590ef63cce.tar.gz src-0007f669caf68d2abf6b924b82263d590ef63cce.zip |
Inline do_sa_get() function and remove an unused return value.
Notes
Notes:
svn path=/head/; revision=226069
Diffstat (limited to 'sys')
-rw-r--r-- | sys/compat/linux/linux_socket.c | 32 |
1 files changed, 9 insertions, 23 deletions
diff --git a/sys/compat/linux/linux_socket.c b/sys/compat/linux/linux_socket.c index ccecb81c02a8..e152befc9663 100644 --- a/sys/compat/linux/linux_socket.c +++ b/sys/compat/linux/linux_socket.c @@ -72,29 +72,16 @@ __FBSDID("$FreeBSD$"); #include <compat/linux/linux_socket.h> #include <compat/linux/linux_util.h> -static int do_sa_get(struct sockaddr **, const struct osockaddr *, int *, - struct malloc_type *); static int linux_to_bsd_domain(int); /* * Reads a linux sockaddr and does any necessary translation. * Linux sockaddrs don't have a length field, only a family. - */ -static int -linux_getsockaddr(struct sockaddr **sap, const struct osockaddr *osa, int len) -{ - int osalen = len; - - return (do_sa_get(sap, osa, &osalen, M_SONAME)); -} - -/* * Copy the osockaddr structure pointed to by osa to kernel, adjust * family and convert to sockaddr. */ static int -do_sa_get(struct sockaddr **sap, const struct osockaddr *osa, int *osalen, - struct malloc_type *mtype) +linux_getsockaddr(struct sockaddr **sap, const struct osockaddr *osa, int osalen) { int error=0, bdom; struct sockaddr *sa; @@ -105,10 +92,10 @@ do_sa_get(struct sockaddr **sap, const struct osockaddr *osa, int *osalen, #endif int alloclen, hdrlen, namelen; - if (*osalen < 2 || *osalen > UCHAR_MAX || !osa) + if (osalen < 2 || osalen > UCHAR_MAX || !osa) return (EINVAL); - alloclen = *osalen; + alloclen = osalen; #ifdef INET6 oldv6size = 0; /* @@ -122,9 +109,9 @@ do_sa_get(struct sockaddr **sap, const struct osockaddr *osa, int *osalen, } #endif - kosa = malloc(alloclen, mtype, M_WAITOK); + kosa = malloc(alloclen, M_SONAME, M_WAITOK); - if ((error = copyin(osa, kosa, *osalen))) + if ((error = copyin(osa, kosa, osalen))) goto out; bdom = linux_to_bsd_domain(kosa->sa_family); @@ -160,16 +147,16 @@ do_sa_get(struct sockaddr **sap, const struct osockaddr *osa, int *osalen, #endif if (bdom == AF_INET) { alloclen = sizeof(struct sockaddr_in); - if (*osalen < alloclen) { + if (osalen < alloclen) { error = EINVAL; goto out; } } - if (bdom == AF_LOCAL && *osalen > sizeof(struct sockaddr_un)) { + if (bdom == AF_LOCAL && osalen > sizeof(struct sockaddr_un)) { hdrlen = offsetof(struct sockaddr_un, sun_path); namelen = strnlen(((struct sockaddr_un *)kosa)->sun_path, - *osalen - hdrlen); + osalen - hdrlen); if (hdrlen + namelen > sizeof(struct sockaddr_un)) { error = EINVAL; goto out; @@ -182,11 +169,10 @@ do_sa_get(struct sockaddr **sap, const struct osockaddr *osa, int *osalen, sa->sa_len = alloclen; *sap = sa; - *osalen = alloclen; return (0); out: - free(kosa, mtype); + free(kosa, M_SONAME); return (error); } |