diff options
| author | Konstantin Belousov <kib@FreeBSD.org> | 2010-12-29 22:26:49 +0000 |
|---|---|---|
| committer | Konstantin Belousov <kib@FreeBSD.org> | 2010-12-29 22:26:49 +0000 |
| commit | 50cfe7fa503448074356ea6f40a22973e489ad4f (patch) | |
| tree | 85e3ca190990ebd95923f075fd1424022c5dee91 /sys/vm | |
| parent | add265c6ba450d4930722a277cd0bc8ac5b42b25 (diff) | |
| download | src-50cfe7fa503448074356ea6f40a22973e489ad4f.tar.gz src-50cfe7fa503448074356ea6f40a22973e489ad4f.zip | |
Remove OBJ_CLEANING flag. The vfs_setdirty_locked_object() is the only
consumer of the flag, and it used the flag because OBJ_MIGHTBEDIRTY
was cleared early in vm_object_page_clean, before the cleaning pass
was done. This is no longer true after r216799.
Moreover, since OBJ_CLEANING is a flag, and not the counter, it could
be reset too prematurely when parallel vm_object_page_clean() are
performed.
Reviewed by: alc (as a part of the bigger patch)
MFC after: 1 month (after r216799 is merged)
Notes
Notes:
svn path=/head/; revision=216810
Diffstat (limited to 'sys/vm')
| -rw-r--r-- | sys/vm/vm_object.c | 3 | ||||
| -rw-r--r-- | sys/vm/vm_object.h | 1 |
2 files changed, 0 insertions, 4 deletions
diff --git a/sys/vm/vm_object.c b/sys/vm/vm_object.c index b7ddf601797f..e34c3e907ad5 100644 --- a/sys/vm/vm_object.c +++ b/sys/vm/vm_object.c @@ -809,8 +809,6 @@ vm_object_page_clean(vm_object_t object, vm_pindex_t start, vm_pindex_t end, tend = (end == 0) ? object->size : end; - vm_object_set_flag(object, OBJ_CLEANING); - /* * Make the page read-only so we can then clear the object flags. * @@ -849,7 +847,6 @@ rescan: VOP_FSYNC(vp, (pagerflags & VM_PAGER_PUT_SYNC) ? MNT_WAIT : 0); #endif - vm_object_clear_flag(object, OBJ_CLEANING); if (clearobjflags && start == 0 && tend == object->size) vm_object_clear_flag(object, OBJ_MIGHTBEDIRTY); } diff --git a/sys/vm/vm_object.h b/sys/vm/vm_object.h index 7cce955f33d9..b830202432dd 100644 --- a/sys/vm/vm_object.h +++ b/sys/vm/vm_object.h @@ -155,7 +155,6 @@ struct vm_object { #define OBJ_NOSPLIT 0x0010 /* dont split this object */ #define OBJ_PIPWNT 0x0040 /* paging in progress wanted */ #define OBJ_MIGHTBEDIRTY 0x0100 /* object might be dirty, only for vnode */ -#define OBJ_CLEANING 0x0200 #define OBJ_COLORED 0x1000 /* pg_color is defined */ #define OBJ_ONEMAPPING 0x2000 /* One USE (a single, non-forked) mapping flag */ #define OBJ_DISCONNECTWNT 0x4000 /* disconnect from vnode wanted */ |