aboutsummaryrefslogtreecommitdiff
path: root/sys/nfsclient/nfs_subs.c
diff options
context:
space:
mode:
authorAttilio Rao <attilio@FreeBSD.org>2008-01-10 01:10:58 +0000
committerAttilio Rao <attilio@FreeBSD.org>2008-01-10 01:10:58 +0000
commitcb05b60a8982e5497cd30449710deb2f4be653d4 (patch)
treec4e28d990eaa525916ab09f2bd1d9c6ddf2c8dea /sys/nfsclient/nfs_subs.c
parent71e3b145e380a641c1129e0363ecb2f5ebbb09f2 (diff)
downloadsrc-cb05b60a8982e5497cd30449710deb2f4be653d4.tar.gz
src-cb05b60a8982e5497cd30449710deb2f4be653d4.zip
vn_lock() is currently only used with the 'curthread' passed as argument.
Remove this argument and pass curthread directly to underlying VOP_LOCK1() VFS method. This modify makes the code cleaner and in particular remove an annoying dependence helping next lockmgr() cleanup. KPI results, obviously, changed. Manpage and FreeBSD_version will be updated through further commits. As a side note, would be valuable to say that next commits will address a similar cleanup about VFS methods, in particular vop_lock1 and vop_unlock. Tested by: Diego Sardina <siarodx at gmail dot com>, Andrea Di Pasquale <whyx dot it at gmail dot com>
Notes
Notes: svn path=/head/; revision=175202
Diffstat (limited to 'sys/nfsclient/nfs_subs.c')
-rw-r--r--sys/nfsclient/nfs_subs.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/sys/nfsclient/nfs_subs.c b/sys/nfsclient/nfs_subs.c
index 1c78599ba451..d6c7d295b62a 100644
--- a/sys/nfsclient/nfs_subs.c
+++ b/sys/nfsclient/nfs_subs.c
@@ -487,9 +487,9 @@ nfs_upgrade_vnlock(struct vnode *vp, struct thread *td)
if ((old_lock = VOP_ISLOCKED(vp, td)) != LK_EXCLUSIVE) {
if (old_lock == LK_SHARED) {
/* Upgrade to exclusive lock, this might block */
- vn_lock(vp, LK_UPGRADE | LK_RETRY, td);
+ vn_lock(vp, LK_UPGRADE | LK_RETRY);
} else {
- vn_lock(vp, LK_EXCLUSIVE | LK_RETRY, td);
+ vn_lock(vp, LK_EXCLUSIVE | LK_RETRY);
}
}
return old_lock;
@@ -501,7 +501,7 @@ nfs_downgrade_vnlock(struct vnode *vp, struct thread *td, int old_lock)
if (old_lock != LK_EXCLUSIVE) {
if (old_lock == LK_SHARED) {
/* Downgrade from exclusive lock, this might block */
- vn_lock(vp, LK_DOWNGRADE, td);
+ vn_lock(vp, LK_DOWNGRADE);
} else {
VOP_UNLOCK(vp, 0, td);
}