diff options
| author | Stephen Hurd <shurd@FreeBSD.org> | 2018-05-08 17:15:10 +0000 |
|---|---|---|
| committer | Stephen Hurd <shurd@FreeBSD.org> | 2018-05-08 17:15:10 +0000 |
| commit | ac88e6da113f659dc7cc535d0f0a76cb9ad906d4 (patch) | |
| tree | 7c327a3853b1f7c843e3f64dc000105a0ce97d21 /sys/net/iflib.c | |
| parent | 053641bb1cef4431983c2ce81e605520fa0380e2 (diff) | |
| download | src-ac88e6da113f659dc7cc535d0f0a76cb9ad906d4.tar.gz src-ac88e6da113f659dc7cc535d0f0a76cb9ad906d4.zip | |
iflib: print message when iflib_tx_structures_setup fails
Print a message when iflib_tx_structures_setup fails, like we do for
iflib_rx_structures_setup.
Now that we always print a message from within
iflib_qset_structures_setup when it fails, stop printing one in
iflib_device_register() at the call site.
Submitted by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed by: gallatin
MFC after: 3 days
Sponsored by: Intel Corporation
Differential Revision: https://reviews.freebsd.org/D15300
Notes
Notes:
svn path=/head/; revision=333373
Diffstat (limited to 'sys/net/iflib.c')
| -rw-r--r-- | sys/net/iflib.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sys/net/iflib.c b/sys/net/iflib.c index 11a95897f3c9..01147190d1b3 100644 --- a/sys/net/iflib.c +++ b/sys/net/iflib.c @@ -4398,10 +4398,8 @@ iflib_device_register(device_t dev, void *sc, if_shared_ctx_t sctx, if_ctx_t *ct goto fail; } - if ((err = iflib_qset_structures_setup(ctx))) { - device_printf(dev, "qset structure setup failed %d\n", err); + if ((err = iflib_qset_structures_setup(ctx))) goto fail_queues; - } /* * Group taskqueues aren't properly set up until SMP is started, @@ -5070,8 +5068,10 @@ iflib_qset_structures_setup(if_ctx_t ctx) * It is expected that the caller takes care of freeing queues if this * fails. */ - if ((err = iflib_tx_structures_setup(ctx)) != 0) + if ((err = iflib_tx_structures_setup(ctx)) != 0) { + device_printf(ctx->ifc_dev, "iflib_tx_structures_setup failed: %d\n", err); return (err); + } if ((err = iflib_rx_structures_setup(ctx)) != 0) device_printf(ctx->ifc_dev, "iflib_rx_structures_setup failed: %d\n", err); |