diff options
author | Rick Macklem <rmacklem@FreeBSD.org> | 2012-12-18 00:25:48 +0000 |
---|---|---|
committer | Rick Macklem <rmacklem@FreeBSD.org> | 2012-12-18 00:25:48 +0000 |
commit | 13870d5d7bf1353a623b5be770d9b64d53f8003d (patch) | |
tree | 1a528b7e5e6224c7d6841c880e1617f1b61ec29e /sys/kgssapi/gss_display_status.c | |
parent | 61ba2ac6b44e016b36bac70a7dc9d62a8d60da55 (diff) | |
download | src-13870d5d7bf1353a623b5be770d9b64d53f8003d.tar.gz src-13870d5d7bf1353a623b5be770d9b64d53f8003d.zip |
Piete.Brooks at cl.cam.ac.uk reported via email a crash which was
caused by use of an invalid kgss_gssd_handle during an upcall to
the gssd daemon when it has exited. This patch seems to avoid the
crashes by holding a reference count on the kgss_gssd_handle until
the upcall is done. It also adds a new mutex kgss_gssd_lock used to
make manipulation of kgss_gssd_handle SMP safe.
Tested by: Illias A. Marinos, Herbert Poeckl
Reviewed by: jhb
MFC after: 2 weeks
Notes
Notes:
svn path=/head/; revision=244370
Diffstat (limited to 'sys/kgssapi/gss_display_status.c')
-rw-r--r-- | sys/kgssapi/gss_display_status.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/sys/kgssapi/gss_display_status.c b/sys/kgssapi/gss_display_status.c index 0b5b79d17b6b..e03a3762aa8b 100644 --- a/sys/kgssapi/gss_display_status.c +++ b/sys/kgssapi/gss_display_status.c @@ -31,7 +31,9 @@ __FBSDID("$FreeBSD$"); #include <sys/param.h> #include <sys/kernel.h> #include <sys/kobj.h> +#include <sys/lock.h> #include <sys/malloc.h> +#include <sys/mutex.h> #include <kgssapi/gssapi.h> #include <kgssapi/gssapi_impl.h> @@ -49,8 +51,11 @@ gss_display_status(OM_uint32 *minor_status, struct display_status_res res; struct display_status_args args; enum clnt_stat stat; + CLIENT *cl; - if (!kgss_gssd_handle) + *minor_status = 0; + cl = kgss_gssd_client(); + if (cl == NULL) return (GSS_S_FAILURE); args.status_value = status_value; @@ -59,7 +64,8 @@ gss_display_status(OM_uint32 *minor_status, args.message_context = *message_context; bzero(&res, sizeof(res)); - stat = gssd_display_status_1(&args, &res, kgss_gssd_handle); + stat = gssd_display_status_1(&args, &res, cl); + CLNT_RELEASE(cl); if (stat != RPC_SUCCESS) { *minor_status = stat; return (GSS_S_FAILURE); @@ -70,7 +76,6 @@ gss_display_status(OM_uint32 *minor_status, return (res.major_status); } - *minor_status = 0; *message_context = res.message_context; kgss_copy_buffer(&res.status_string, status_string); xdr_free((xdrproc_t) xdr_display_status_res, &res); |