diff options
| author | Konstantin Belousov <kib@FreeBSD.org> | 2021-11-16 17:31:11 +0000 |
|---|---|---|
| committer | Konstantin Belousov <kib@FreeBSD.org> | 2021-11-16 18:01:31 +0000 |
| commit | c34a5148e8f21e9be28330c4ae4884b6f31193dd (patch) | |
| tree | dbc7920e80713b83ce068d35b23459381c2adc58 /sys/geom | |
| parent | 16bea05ac3275d41663939da0d5c26d89f15cd53 (diff) | |
| download | src-c34a5148e8f21e9be28330c4ae4884b6f31193dd.tar.gz src-c34a5148e8f21e9be28330c4ae4884b6f31193dd.zip | |
ffs: fix newly introduced LOR between mntfs vnode lock and topology lock
The mntfs vnode lock should be before topology, as established in
ffs_mountfs(). Extend the locked region in ffs_unmount().
Reported and reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D33013
Diffstat (limited to 'sys/geom')
| -rw-r--r-- | sys/geom/geom_vfs.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/sys/geom/geom_vfs.c b/sys/geom/geom_vfs.c index 9590fee11000..ab068d7c85d5 100644 --- a/sys/geom/geom_vfs.c +++ b/sys/geom/geom_vfs.c @@ -309,9 +309,7 @@ g_vfs_close(struct g_consumer *cp) gp = cp->geom; sc = gp->softc; vp = cp->private; - vn_lock(vp, LK_EXCLUSIVE | LK_RETRY); bufobj_invalbuf(sc->sc_bo, V_SAVE, 0, 0); - VOP_UNLOCK(vp); sc->sc_bo->bo_private = cp->private; gp->softc = NULL; mtx_destroy(&sc->sc_mtx); |