aboutsummaryrefslogtreecommitdiff
path: root/sys/dev
diff options
context:
space:
mode:
authorMarius Strobl <marius@FreeBSD.org>2011-02-09 11:28:57 +0000
committerMarius Strobl <marius@FreeBSD.org>2011-02-09 11:28:57 +0000
commit1115e138a94a3907dfb04c12191d82cf0a39e844 (patch)
tree203d920dec091258014cdea2c6e6ac1073d8b943 /sys/dev
parent7e7f4121392ef4530c8f4aad1491698db9fdc2a6 (diff)
downloadsrc-1115e138a94a3907dfb04c12191d82cf0a39e844.tar.gz
src-1115e138a94a3907dfb04c12191d82cf0a39e844.zip
Correct signedness and off-by-one issues in parameters used for DMA tag
creation. PR: 154259 Submitted by: Vladislav Movchan (partially) MFC after: 3 days
Notes
Notes: svn path=/head/; revision=218478
Diffstat (limited to 'sys/dev')
-rw-r--r--sys/dev/sound/pci/emu10k1.c2
-rw-r--r--sys/dev/sound/pci/emu10kx.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/sys/dev/sound/pci/emu10k1.c b/sys/dev/sound/pci/emu10k1.c
index 43b7ebee0ddd..4c02fa4eaaff 100644
--- a/sys/dev/sound/pci/emu10k1.c
+++ b/sys/dev/sound/pci/emu10k1.c
@@ -2017,7 +2017,7 @@ emu_pci_attach(device_t dev)
if (bus_dma_tag_create(/*parent*/bus_get_dma_tag(dev), /*alignment*/2,
/*boundary*/0,
- /*lowaddr*/1 << 31, /* can only access 0-2gb */
+ /*lowaddr*/(1U << 31) - 1, /* can only access 0-2gb */
/*highaddr*/BUS_SPACE_MAXADDR,
/*filter*/NULL, /*filterarg*/NULL,
/*maxsize*/sc->bufsz, /*nsegments*/1, /*maxsegz*/0x3ffff,
diff --git a/sys/dev/sound/pci/emu10kx.c b/sys/dev/sound/pci/emu10kx.c
index f1d10ed41deb..c7ac57f7a501 100644
--- a/sys/dev/sound/pci/emu10kx.c
+++ b/sys/dev/sound/pci/emu10kx.c
@@ -2700,7 +2700,7 @@ emu_init(struct emu_sc_info *sc)
if (bus_dma_tag_create( /* parent */ bus_get_dma_tag(sc->dev),
/* alignment */ 2, /* boundary */ 0,
- /* lowaddr */ 1 << 31, /* can only access 0-2gb */
+ /* lowaddr */ (1U << 31) - 1, /* can only access 0-2gb */
/* highaddr */ BUS_SPACE_MAXADDR,
/* filter */ NULL, /* filterarg */ NULL,
/* maxsize */ EMU_MAX_BUFSZ, /* nsegments */ 1, /* maxsegz */ 0x3ffff,