diff options
| author | Roger Pau Monné <royger@FreeBSD.org> | 2016-02-11 11:53:32 +0000 |
|---|---|---|
| committer | Roger Pau Monné <royger@FreeBSD.org> | 2016-02-11 11:53:32 +0000 |
| commit | d4dae2b1fb44e0205238cd5b1ec8bac2cd72d74d (patch) | |
| tree | e9a60652e9c13bb4e094ffa9337fe5d6d1da5aac /sys/dev/xen/netfront | |
| parent | 780349944044e8f769bb0b93755178ac0fb22c7f (diff) | |
| download | src-d4dae2b1fb44e0205238cd5b1ec8bac2cd72d74d.tar.gz src-d4dae2b1fb44e0205238cd5b1ec8bac2cd72d74d.zip | |
xen-netfront: rearrange error paths in setup_txqs
Coverity spotted double free errors in error path. Fix that by
removing the extraneous calls.
Coverity ID: 1349798
Submitted by: Wei Liu <wei.liu2@citrix.com>
Reviewed by: royger
Sponsored by: Citrix Systems R&D
Differential revision: https://reviews.freebsd.org/D5251
Notes
Notes:
svn path=/head/; revision=295511
Diffstat (limited to 'sys/dev/xen/netfront')
| -rw-r--r-- | sys/dev/xen/netfront/netfront.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/sys/dev/xen/netfront/netfront.c b/sys/dev/xen/netfront/netfront.c index 89aef6298b2f..296c940f0836 100644 --- a/sys/dev/xen/netfront/netfront.c +++ b/sys/dev/xen/netfront/netfront.c @@ -906,11 +906,9 @@ setup_txqs(device_t dev, struct netfront_info *info, fail_bind_port: taskqueue_drain_all(txq->tq); fail_start_thread: - gnttab_free_grant_references(txq->gref_head); - free(txq->ring.sring, M_DEVBUF); - gnttab_end_foreign_access_ref(txq->ring_ref); buf_ring_free(txq->br, M_DEVBUF); taskqueue_free(txq->tq); + gnttab_end_foreign_access_ref(txq->ring_ref); fail_grant_ring: gnttab_free_grant_references(txq->gref_head); free(txq->ring.sring, M_DEVBUF); |