aboutsummaryrefslogtreecommitdiff
path: root/sys/dev/msk
diff options
context:
space:
mode:
authorMarius Strobl <marius@FreeBSD.org>2011-11-22 21:28:20 +0000
committerMarius Strobl <marius@FreeBSD.org>2011-11-22 21:28:20 +0000
commit4b7ec27007570e0ce4fe9dbb447e7afc131b487a (patch)
tree4941db3a873a5f9b2ccc4a64c23bf5cd65516206 /sys/dev/msk
parent21c8beb9fd4c49e791b4347f7b535315735a398a (diff)
downloadsrc-4b7ec27007570e0ce4fe9dbb447e7afc131b487a.tar.gz
src-4b7ec27007570e0ce4fe9dbb447e7afc131b487a.zip
- There's no need to overwrite the default device method with the default
one. Interestingly, these are actually the default for quite some time (bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9) since r52045) but even recently added device drivers do this unnecessarily. Discussed with: jhb, marcel - While at it, use DEVMETHOD_END. Discussed with: jhb - Also while at it, use __FBSDID.
Notes
Notes: svn path=/head/; revision=227843
Diffstat (limited to 'sys/dev/msk')
-rw-r--r--sys/dev/msk/if_msk.c12
1 files changed, 2 insertions, 10 deletions
diff --git a/sys/dev/msk/if_msk.c b/sys/dev/msk/if_msk.c
index 36407a2c1a14..588eb8de854d 100644
--- a/sys/dev/msk/if_msk.c
+++ b/sys/dev/msk/if_msk.c
@@ -334,11 +334,7 @@ static device_method_t mskc_methods[] = {
DEVMETHOD(device_resume, mskc_resume),
DEVMETHOD(device_shutdown, mskc_shutdown),
- /* bus interface */
- DEVMETHOD(bus_print_child, bus_generic_print_child),
- DEVMETHOD(bus_driver_added, bus_generic_driver_added),
-
- { NULL, NULL }
+ DEVMETHOD_END
};
static driver_t mskc_driver = {
@@ -356,16 +352,12 @@ static device_method_t msk_methods[] = {
DEVMETHOD(device_detach, msk_detach),
DEVMETHOD(device_shutdown, bus_generic_shutdown),
- /* bus interface */
- DEVMETHOD(bus_print_child, bus_generic_print_child),
- DEVMETHOD(bus_driver_added, bus_generic_driver_added),
-
/* MII interface */
DEVMETHOD(miibus_readreg, msk_miibus_readreg),
DEVMETHOD(miibus_writereg, msk_miibus_writereg),
DEVMETHOD(miibus_statchg, msk_miibus_statchg),
- { NULL, NULL }
+ DEVMETHOD_END
};
static driver_t msk_driver = {