diff options
| author | David Schultz <das@FreeBSD.org> | 2005-03-18 05:43:37 +0000 |
|---|---|---|
| committer | David Schultz <das@FreeBSD.org> | 2005-03-18 05:43:37 +0000 |
| commit | 730eb840112f942092aa9bf9edf4dfa30e10a61c (patch) | |
| tree | 6d698e26612955fd0dc67c366868b4597c26f82e /sys/dev/mlx | |
| parent | 14f1a8cc086dce23cf113f16d983161486da97a4 (diff) | |
| download | src-730eb840112f942092aa9bf9edf4dfa30e10a61c.tar.gz src-730eb840112f942092aa9bf9edf4dfa30e10a61c.zip | |
If mlx_attach() returns an error, don't free sc again.
Spotted by: Ted Unangst using the Coverity Prevent static analysis tool
Reviewed by: scottl
Notes
Notes:
svn path=/head/; revision=143788
Diffstat (limited to 'sys/dev/mlx')
| -rw-r--r-- | sys/dev/mlx/mlx_pci.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/sys/dev/mlx/mlx_pci.c b/sys/dev/mlx/mlx_pci.c index 6c2fe87e6e93..7e4b01ac6270 100644 --- a/sys/dev/mlx/mlx_pci.c +++ b/sys/dev/mlx/mlx_pci.c @@ -214,10 +214,8 @@ mlx_pci_attach(device_t dev) * Do bus-independant initialisation. */ error = mlx_attach(sc); - if (error != 0) { - mlx_free(sc); + if (error != 0) return(error); - } /* * Start the controller. |