diff options
| author | Eitan Adler <eadler@FreeBSD.org> | 2013-11-30 22:17:27 +0000 |
|---|---|---|
| committer | Eitan Adler <eadler@FreeBSD.org> | 2013-11-30 22:17:27 +0000 |
| commit | 7a22215c5346c9009d1dfa4d3c118ff99f89d184 (patch) | |
| tree | 050fb3b68519f6ef7d59051550fa29cdd79d6dac /sys/dev/mge/if_mgevar.h | |
| parent | c8aef31d309ac3f874c461619248fee9c1d74c2f (diff) | |
| download | src-7a22215c5346c9009d1dfa4d3c118ff99f89d184.tar.gz src-7a22215c5346c9009d1dfa4d3c118ff99f89d184.zip | |
Fix undefined behavior: (1 << 31) is not defined as 1 is an int and this
shifts into the sign bit. Instead use (1U << 31) which gets the
expected result.
This fix is not ideal as it assumes a 32 bit int, but does fix the issue
for most cases.
A similar change was made in OpenBSD.
Discussed with: -arch, rdivacky
Reviewed by: cperciva
Notes
Notes:
svn path=/head/; revision=258780
Diffstat (limited to 'sys/dev/mge/if_mgevar.h')
| -rw-r--r-- | sys/dev/mge/if_mgevar.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sys/dev/mge/if_mgevar.h b/sys/dev/mge/if_mgevar.h index f884fc8945a7..0ab28bf6f0be 100644 --- a/sys/dev/mge/if_mgevar.h +++ b/sys/dev/mge/if_mgevar.h @@ -262,7 +262,7 @@ struct mge_softc { #define MGE_PORT_INT_RXQ0 (1 << 2) #define MGE_PORT_INT_RXERR (1 << 10) #define MGE_PORT_INT_RXERRQ0 (1 << 11) -#define MGE_PORT_INT_SUM (1 << 31) +#define MGE_PORT_INT_SUM (1U << 31) #define MGE_PORT_INT_CAUSE_EXT 0x464 #define MGE_PORT_INT_MASK_EXT 0x46C @@ -273,7 +273,7 @@ struct mge_softc { #define MGE_PORT_INT_EXT_TXUR (1 << 19) #define MGE_PORT_INT_EXT_LC (1 << 20) #define MGE_PORT_INT_EXT_IAR (1 << 23) -#define MGE_PORT_INT_EXT_SUM (1 << 31) +#define MGE_PORT_INT_EXT_SUM (1U << 31) #define MGE_RX_FIFO_URGENT_TRSH 0x470 #define MGE_TX_FIFO_URGENT_TRSH 0x474 @@ -330,7 +330,7 @@ struct mge_softc { #define MGE_RX_DESC_FIRST (1 << 27) #define MGE_RX_ENABLE_INT (1 << 29) #define MGE_RX_L4_CSUM_OK (1 << 30) -#define MGE_DMA_OWNED (1 << 31) +#define MGE_DMA_OWNED (1U << 31) #define MGE_RX_IP_FRAGMENT (1 << 2) |