aboutsummaryrefslogtreecommitdiff
path: root/sys/dev/isp/ispvar.h
diff options
context:
space:
mode:
authorKenneth D. Merry <ken@FreeBSD.org>2019-03-11 14:21:14 +0000
committerKenneth D. Merry <ken@FreeBSD.org>2019-03-11 14:21:14 +0000
commit6f9dbc0e6ec465793f19a48620e1205cc1eec2be (patch)
treeb70bf047e854304c1eb2d2c23e2e54fa781ddbbd /sys/dev/isp/ispvar.h
parentc65b552f895bcb8ea931da6304108a3e008ff669 (diff)
downloadsrc-6f9dbc0e6ec465793f19a48620e1205cc1eec2be.tar.gz
src-6f9dbc0e6ec465793f19a48620e1205cc1eec2be.zip
Fix CRN resets in the isp(4) driver in certain situations.
The Command Reference Number (CRN) is part of the FC-Tape features that we enable when talking to tape drives. It starts at 1, and goes to 255 and wraps around to 1. There are a number of reset type conditions that result in the CRN getting reset to 1. These are detailed in section 4.10 (table 8) of the FCP-4r02b specification. One of the conditions is when a PRLI (Process Login) is sent by the initiator, and the Establish Image Pair bit is set in Word 0 of the PRLI. Previously, the isp(4) driver core sent a notification via isp_async() that the target had changed or stayed in place, but there was no indication of whether a PRLI was sent and whether the Establish Image Pair bit was set. The result of this was that in some situations, notably switching back and forth between a direct connection and a switch connection to a tape drive, the isp(4) driver would fail to reset the CRN in situations that require it according to the spec. When the CRN isn't reset in a situation that requires it, the tape drive then rejects every subsequent command that is sent to the drive. It is assuming that the commands are being sent out of order. So, modify the isp(4) driver to include Word 0 of the PRLI command when it sends isp_async() notifications of target changes. Look at the Establish Image Pair bit, and reset the CRN if that bit is set. With this change, I am able to switch a tape drive back and forth between a direct connection and a switch connection, and the isp(4) driver resets the CRN when it should. sys/dev/isp_stds.h: Add bit definitions for PRLI Word 0. sys/dev/ispmbox.h: Add PRLI Word 0 to the port database type, isp_pdb_t. sys/dev/ispvar.h Add PRLI Word 0 to fcportdb_t. sys/dev/isp.c: Populate the new prli_word0 parameter in the port database. In isp_pdb_add_update(), add a check to see if the Establish Image Pair bit is set in PRLI Word 0. If it is, then that is an additional reason to create a change notification. sys/dev/isp_freebsd.c: In isp_async(), if the device changed or stayed, look at PRLI Word 0 to see if the Establish Image Pair bit is set. If it is, reset the CRN if we haven't already. MFC after: 1 week Sponsored by: Spectra Logic Differential Revision: https://reviews.freebsd.org/D19472
Notes
Notes: svn path=/head/; revision=345008
Diffstat (limited to 'sys/dev/isp/ispvar.h')
-rw-r--r--sys/dev/isp/ispvar.h5
1 files changed, 5 insertions, 0 deletions
diff --git a/sys/dev/isp/ispvar.h b/sys/dev/isp/ispvar.h
index 1e963916ca1e..45513a3b6871 100644
--- a/sys/dev/isp/ispvar.h
+++ b/sys/dev/isp/ispvar.h
@@ -381,6 +381,9 @@ typedef struct {
uint16_t handle;
/*
+ * PRLI word 0 contains the Establish Image Pair bit, which is
+ * important for knowing when to reset the CRN.
+ *
* PRLI word 3 parameters contains role as well as other things.
*
* The state is the current state of this entry.
@@ -392,7 +395,9 @@ typedef struct {
* Portid is obvious, as are node && port WWNs. The new_role and
* new_portid is for when we are pending a change.
*/
+ uint16_t prli_word0; /* PRLI parameters */
uint16_t prli_word3; /* PRLI parameters */
+ uint16_t new_prli_word0; /* Incoming new PRLI parameters */
uint16_t new_prli_word3; /* Incoming new PRLI parameters */
uint16_t : 12,
probational : 1,