aboutsummaryrefslogtreecommitdiff
path: root/sys/dev/ed
diff options
context:
space:
mode:
authorWarner Losh <imp@FreeBSD.org>2005-09-19 03:10:21 +0000
committerWarner Losh <imp@FreeBSD.org>2005-09-19 03:10:21 +0000
commitad4f426ef63acf8f93962c281274c677a055e500 (patch)
treec3358cebc77043ea8b2a3a5036b02dad6a674b7e /sys/dev/ed
parent6763e7c1edc7198eca8ab7017018b03f5c41e012 (diff)
downloadsrc-ad4f426ef63acf8f93962c281274c677a055e500.tar.gz
src-ad4f426ef63acf8f93962c281274c677a055e500.zip
Make sure that we call if_free(ifp) after bus_teardown_intr. Since we
could get an interrupt after we free the ifp, and the interrupt handler depended on the ifp being still alive, this could, in theory, cause a crash. Eliminate this possibility by moving the if_free to after the bus_teardown_intr() call.
Notes
Notes: svn path=/head/; revision=150306
Diffstat (limited to 'sys/dev/ed')
-rw-r--r--sys/dev/ed/if_ed.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/ed/if_ed.c b/sys/dev/ed/if_ed.c
index e76c0c8ca9dd..0cbe2b3b044f 100644
--- a/sys/dev/ed/if_ed.c
+++ b/sys/dev/ed/if_ed.c
@@ -369,8 +369,8 @@ ed_detach(device_t dev)
callout_drain(&sc->tick_ch);
ether_ifdetach(ifp);
bus_teardown_intr(dev, sc->irq_res, sc->irq_handle);
- if_free(ifp);
ed_release_resources(dev);
+ if_free(ifp);
ED_LOCK_DESTROY(sc);
return (0);
}