aboutsummaryrefslogtreecommitdiff
path: root/sys/dev/amr
diff options
context:
space:
mode:
authorMike Smith <msmith@FreeBSD.org>2000-04-24 19:56:26 +0000
committerMike Smith <msmith@FreeBSD.org>2000-04-24 19:56:26 +0000
commit59548657bca83bb7e17b059a36381efe0dcb29b7 (patch)
tree9fafdf6c9b7a12daead2891fb061e6e484cf0b21 /sys/dev/amr
parent27440dd2379da896ca3ceadb64586a94c6fff71e (diff)
downloadsrc-59548657bca83bb7e17b059a36381efe0dcb29b7.tar.gz
src-59548657bca83bb7e17b059a36381efe0dcb29b7.zip
Disable the returning of "wedged" commands; this is wrong and needs to be
rethought.
Notes
Notes: svn path=/head/; revision=59610
Diffstat (limited to 'sys/dev/amr')
-rw-r--r--sys/dev/amr/amr.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/sys/dev/amr/amr.c b/sys/dev/amr/amr.c
index de6f965a334c..b81403e5998f 100644
--- a/sys/dev/amr/amr.c
+++ b/sys/dev/amr/amr.c
@@ -688,7 +688,13 @@ amr_periodic(void *data)
debug("called");
-
+#if 0
+ /*
+ * XXX this is basically wrong - returning a command that's wedged
+ * leaves us vulnerable to the controller later completing the command
+ * and overwriting memory that may have subsequently been reused.
+ */
+
/*
* Check for commands that are massively late. This will need to be
* revisited if/when we deal with eg. device format commands.
@@ -711,6 +717,7 @@ amr_periodic(void *data)
}
}
splx(s);
+#endif
/* reschedule */
sc->amr_timeout = timeout(amr_periodic, sc, hz);