diff options
author | Scott Long <scottl@FreeBSD.org> | 2006-04-08 05:08:17 +0000 |
---|---|---|
committer | Scott Long <scottl@FreeBSD.org> | 2006-04-08 05:08:17 +0000 |
commit | dce223cfb613d2fd34ad41e4e6502941a394c898 (patch) | |
tree | 89131839dd52d34fe198dcc50d299e65fa7a575d /sys/dev/amr/amrvar.h | |
parent | 026d2aa333fe1184333eadac35e29264f083d879 (diff) | |
download | src-dce223cfb613d2fd34ad41e4e6502941a394c898.tar.gz src-dce223cfb613d2fd34ad41e4e6502941a394c898.zip |
After further review and discussion, partially revert the previous commit.
The real problem was that ioctl handlers needed to call amr_wait_command()
with the list lock held. This not only solves the completion race, it also
prevents bounce buffer corruption that could arise from amr_start() being
called without the proper locks held.
Discussed with: ps
MFC After: 3 days
Notes
Notes:
svn path=/head/; revision=157586
Diffstat (limited to 'sys/dev/amr/amrvar.h')
-rw-r--r-- | sys/dev/amr/amrvar.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sys/dev/amr/amrvar.h b/sys/dev/amr/amrvar.h index 4ff0c904ae42..2f9a72837831 100644 --- a/sys/dev/amr/amrvar.h +++ b/sys/dev/amr/amrvar.h @@ -244,7 +244,6 @@ struct amr_softc int amr_linux_no_adapters; int amr_ld_del_supported; struct mtx amr_hw_lock; - struct mtx amr_wait_lock; }; /* |