aboutsummaryrefslogtreecommitdiff
path: root/sys/dev/acpica
diff options
context:
space:
mode:
authorDimitry Andric <dim@FreeBSD.org>2023-04-25 17:18:58 +0000
committerDimitry Andric <dim@FreeBSD.org>2023-04-25 17:26:03 +0000
commitbab8274c090942cf96c44bc001307b9bffac9d7e (patch)
tree0045eeca8c88ff4c7a014c23e14200c326736e89 /sys/dev/acpica
parentb0695c6abe3f33a4188bcbcbf214823cd86f54d6 (diff)
downloadsrc-bab8274c090942cf96c44bc001307b9bffac9d7e.tar.gz
src-bab8274c090942cf96c44bc001307b9bffac9d7e.zip
Use bool for one-bit wide bit-fields
A signed one-bit wide bit-field can take only the values 0 and -1. Clang 16 introduced a warning that "implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1". Fix the warnings by using C99 bool. Reported by: Clang 16 Reviewed by: emaste, jhb MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D39705
Diffstat (limited to 'sys/dev/acpica')
-rw-r--r--sys/dev/acpica/acpi_pci_link.c28
-rw-r--r--sys/dev/acpica/acpi_pxm.c4
2 files changed, 16 insertions, 16 deletions
diff --git a/sys/dev/acpica/acpi_pci_link.c b/sys/dev/acpica/acpi_pci_link.c
index dfbaeaddec06..95dd11b9805e 100644
--- a/sys/dev/acpica/acpi_pci_link.c
+++ b/sys/dev/acpica/acpi_pci_link.c
@@ -104,8 +104,8 @@ struct link {
int l_num_irqs;
int *l_irqs;
int l_references;
- int l_routed:1;
- int l_isa_irq:1;
+ bool l_routed:1;
+ bool l_isa_irq:1;
ACPI_RESOURCE l_prs_template;
};
@@ -355,18 +355,18 @@ link_add_prs(ACPI_RESOURCE *res, void *context)
* valid IRQs are ISA IRQs, then mark this link as
* routed via an ISA interrupt.
*/
- link->l_isa_irq = TRUE;
+ link->l_isa_irq = true;
link->l_irqs = malloc(sizeof(int) * link->l_num_irqs,
M_PCI_LINK, M_WAITOK | M_ZERO);
for (i = 0; i < link->l_num_irqs; i++) {
if (is_ext_irq) {
link->l_irqs[i] = ext_irqs[i];
if (ext_irqs[i] >= NUM_ISA_INTERRUPTS)
- link->l_isa_irq = FALSE;
+ link->l_isa_irq = false;
} else {
link->l_irqs[i] = irqs[i];
if (irqs[i] >= NUM_ISA_INTERRUPTS)
- link->l_isa_irq = FALSE;
+ link->l_isa_irq = false;
}
}
@@ -376,7 +376,7 @@ link_add_prs(ACPI_RESOURCE *res, void *context)
*/
if (!req->sc->pl_crs_bad && !link->l_isa_irq &&
link->l_crs_type == ACPI_RESOURCE_TYPE_IRQ)
- req->sc->pl_crs_bad = TRUE;
+ req->sc->pl_crs_bad = true;
break;
default:
if (req->in_dpf == DPF_IGNORE)
@@ -390,7 +390,7 @@ link_add_prs(ACPI_RESOURCE *res, void *context)
return (AE_OK);
}
-static int
+static bool
link_valid_irq(struct link *link, int irq)
{
int i;
@@ -399,12 +399,12 @@ link_valid_irq(struct link *link, int irq)
/* Invalid interrupts are never valid. */
if (!PCI_INTERRUPT_VALID(irq))
- return (FALSE);
+ return (false);
/* Any interrupt in the list of possible interrupts is valid. */
for (i = 0; i < link->l_num_irqs; i++)
if (link->l_irqs[i] == irq)
- return (TRUE);
+ return (true);
/*
* For links routed via an ISA interrupt, if the SCI is routed via
@@ -412,10 +412,10 @@ link_valid_irq(struct link *link, int irq)
*/
if (link->l_isa_irq && AcpiGbl_FADT.SciInterrupt == irq &&
irq < NUM_ISA_INTERRUPTS)
- return (TRUE);
+ return (true);
/* If the interrupt wasn't found in the list it is not valid. */
- return (FALSE);
+ return (false);
}
static void
@@ -493,7 +493,7 @@ acpi_pci_link_attach(device_t dev)
sc->pl_links[i].l_irq = PCI_INVALID_IRQ;
sc->pl_links[i].l_bios_irq = PCI_INVALID_IRQ;
sc->pl_links[i].l_sc = sc;
- sc->pl_links[i].l_isa_irq = FALSE;
+ sc->pl_links[i].l_isa_irq = false;
sc->pl_links[i].l_res_index = -1;
}
@@ -558,7 +558,7 @@ acpi_pci_link_attach(device_t dev)
else
for (i = 0; i < sc->pl_num_links; i++)
if (PCI_INTERRUPT_VALID(sc->pl_links[i].l_irq))
- sc->pl_links[i].l_routed = TRUE;
+ sc->pl_links[i].l_routed = true;
if (bootverbose)
acpi_pci_link_dump(sc, 0, "After Disable");
ACPI_SERIAL_END(pci_link);
@@ -904,7 +904,7 @@ acpi_pci_link_route_irqs(device_t dev)
*/
if (!link->l_routed &&
PCI_INTERRUPT_VALID(link->l_irq)) {
- link->l_routed = TRUE;
+ link->l_routed = true;
acpi_config_intr(dev, resource);
pci_link_interrupt_weights[link->l_irq] +=
link->l_references;
diff --git a/sys/dev/acpica/acpi_pxm.c b/sys/dev/acpica/acpi_pxm.c
index 03624f00e2f6..2c4347806595 100644
--- a/sys/dev/acpica/acpi_pxm.c
+++ b/sys/dev/acpica/acpi_pxm.c
@@ -56,8 +56,8 @@ __FBSDID("$FreeBSD$");
#if MAXMEMDOM > 1
static struct cpu_info {
- int enabled:1;
- int has_memory:1;
+ bool enabled:1;
+ bool has_memory:1;
int domain;
int id;
} *cpus;