diff options
author | Warner Losh <imp@FreeBSD.org> | 2018-03-20 03:37:04 +0000 |
---|---|---|
committer | Warner Losh <imp@FreeBSD.org> | 2018-03-20 03:37:04 +0000 |
commit | fdfc0a83a344225da6fbdb5aa2f95208ac077b3d (patch) | |
tree | 878994891b971818d1f35065927d49e44559d73e /sys/cam | |
parent | 4e784432626428107411bd9165d3c09ef8e3bcf5 (diff) | |
download | src-fdfc0a83a344225da6fbdb5aa2f95208ac077b3d.tar.gz src-fdfc0a83a344225da6fbdb5aa2f95208ac077b3d.zip |
Remove some redundant MPSAFE flags.
This was pointed out in a code review I'm having trouble finding right
now, but go ahead and eliminate these.
Sponsored by: Netfix
Notes
Notes:
svn path=/head/; revision=331237
Diffstat (limited to 'sys/cam')
-rw-r--r-- | sys/cam/nvme/nvme_da.c | 31 |
1 files changed, 13 insertions, 18 deletions
diff --git a/sys/cam/nvme/nvme_da.c b/sys/cam/nvme/nvme_da.c index d83f505f5fb1..340b48a82248 100644 --- a/sys/cam/nvme/nvme_da.c +++ b/sys/cam/nvme/nvme_da.c @@ -626,25 +626,20 @@ ndasysctlinit(void *context, int pending) } SYSCTL_ADD_INT(&softc->sysctl_ctx, SYSCTL_CHILDREN(softc->sysctl_tree), - OID_AUTO, "unmapped_io", CTLFLAG_RD | CTLFLAG_MPSAFE, - &softc->unmappedio, 0, "Unmapped I/O leaf"); + OID_AUTO, "unmapped_io", CTLFLAG_RD, + &softc->unmappedio, 0, "Unmapped I/O leaf"); SYSCTL_ADD_QUAD(&softc->sysctl_ctx, SYSCTL_CHILDREN(softc->sysctl_tree), - OID_AUTO, "deletes", CTLFLAG_RD | CTLFLAG_MPSAFE, - &softc->deletes, "Number of BIO_DELETE requests"); + OID_AUTO, "deletes", CTLFLAG_RD, + &softc->deletes, "Number of BIO_DELETE requests"); SYSCTL_ADD_QUAD(&softc->sysctl_ctx, SYSCTL_CHILDREN(softc->sysctl_tree), - OID_AUTO, "dsm_req", CTLFLAG_RD | CTLFLAG_MPSAFE, - &softc->dsm_req, "Number of DSM requests sent to SIM"); - - SYSCTL_ADD_INT(&softc->sysctl_ctx, - SYSCTL_CHILDREN(softc->sysctl_tree), - OID_AUTO, - "rotating", - CTLFLAG_RD | CTLFLAG_MPSAFE, - &nda_rotating_media, - 0, - "Rotating media"); + OID_AUTO, "dsm_req", CTLFLAG_RD, + &softc->dsm_req, "Number of DSM requests sent to SIM"); + + SYSCTL_ADD_INT(&softc->sysctl_ctx, SYSCTL_CHILDREN(softc->sysctl_tree), + OID_AUTO, "rotating", CTLFLAG_RD, &nda_rotating_media, 1, + "Rotating media"); #ifdef CAM_IO_STATS softc->sysctl_stats_tree = SYSCTL_ADD_NODE(&softc->sysctl_stats_ctx, @@ -657,17 +652,17 @@ ndasysctlinit(void *context, int pending) } SYSCTL_ADD_INT(&softc->sysctl_stats_ctx, SYSCTL_CHILDREN(softc->sysctl_stats_tree), - OID_AUTO, "timeouts", CTLFLAG_RD | CTLFLAG_MPSAFE, + OID_AUTO, "timeouts", CTLFLAG_RD, &softc->timeouts, 0, "Device timeouts reported by the SIM"); SYSCTL_ADD_INT(&softc->sysctl_stats_ctx, SYSCTL_CHILDREN(softc->sysctl_stats_tree), - OID_AUTO, "errors", CTLFLAG_RD | CTLFLAG_MPSAFE, + OID_AUTO, "errors", CTLFLAG_RD, &softc->errors, 0, "Transport errors reported by the SIM."); SYSCTL_ADD_INT(&softc->sysctl_stats_ctx, SYSCTL_CHILDREN(softc->sysctl_stats_tree), - OID_AUTO, "pack_invalidations", CTLFLAG_RD | CTLFLAG_MPSAFE, + OID_AUTO, "pack_invalidations", CTLFLAG_RD, &softc->invalidations, 0, "Device pack invalidations."); #endif |