diff options
| author | Alex Richardson <arichardson@FreeBSD.org> | 2021-09-06 09:24:33 +0000 |
|---|---|---|
| committer | Alex Richardson <arichardson@FreeBSD.org> | 2021-09-06 09:24:34 +0000 |
| commit | 24f586182ff4d0e94a5c17cb542e0bffefb51fa7 (patch) | |
| tree | 97b31d6225b5bcd4fe302a2fbb5f500c4b064883 /share | |
| parent | 021385aba56279febcfdcc64d23673a0106ae45d (diff) | |
| download | src-24f586182ff4d0e94a5c17cb542e0bffefb51fa7.tar.gz src-24f586182ff4d0e94a5c17cb542e0bffefb51fa7.zip | |
Enable MK_LLVM_BINUTILS if MK_ASAN is requested
ASan will not be able to provide backtraces with symbol names with
elftoolchain's addr2line. To fix this turn MK_LLVM_BINUTILS on by
default when ASan instrumentation is requested.
Reviewed By: emaste, markj
Differential Revision: https://reviews.freebsd.org/D31061
Diffstat (limited to 'share')
| -rw-r--r-- | share/mk/src.opts.mk | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/share/mk/src.opts.mk b/share/mk/src.opts.mk index 5363cb6e78f9..28e18260affd 100644 --- a/share/mk/src.opts.mk +++ b/share/mk/src.opts.mk @@ -470,6 +470,12 @@ MK_CLANG_FULL:= no MK_LLVM_COV:= no .endif +.if ${MK_ASAN} == "yes" +# In order to get sensible backtraces from ASAN we have to install +# llvm-symbolizer as /usr/bin/addr2line instead of the elftoolchain version. +MK_LLVM_BINUTILS:= yes +.endif + .if ${MK_LLVM_BINUTILS} == "yes" # MK_LLVM_CXXFILT is a subset of MK_LLVM_BINUTILS and should therefore be # enabled if MK_LLVM_BINUTILS is set. |