diff options
author | Igor Ostapenko <igoro@FreeBSD.org> | 2025-02-23 10:41:58 +0000 |
---|---|---|
committer | Igor Ostapenko <igoro@FreeBSD.org> | 2025-02-23 10:41:58 +0000 |
commit | 51a8eb6410461c94c8e0f2b59e3417cfb5d7da75 (patch) | |
tree | c635f39e2824c8f40884677c75989bd1028a108b /secure/libexec/(developers-only) | |
parent | 65c573e47c40e3f167f3d7e41bd8db40b6b8f91e (diff) |
Kyua and ATF speak different naming styles. In this case, the
unprivileged user property can be named with underscore on the Kyua
side, and with a hyphen on the ATF side. Sometimes it is not obvious
which style should be used in which situation. For instance, a test case
may require this configuration property being set using require.config.
Also, a test case may want to read the property using something like
atf_tc_get_config_var(). Which names should be used in these cases?
From the perspective of the original code, it is expected to be this:
require.config unprivileged-user
atf_tc_get_config_var(tc, "unprivileged-user")
But, as long as Kyua is the main interface, its users expect to work
with kyua.conf(5), which says that it must be named as unprivileged_user
(with underscore). As a result, test authors tend to do this instead:
require.config unprivileged_user
atf_tc_get_config_var(tc, "unprivileged_user")
Kyua already has hacks to understand both unprivileged_user and
unprivileged-user coming from require.config. And this patch covers the
missing second part -- make Kyua pass both names back to ATF as two
identical configuration properties named different ways.
Reviewed by: ngie, asomers
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D49039
Diffstat (limited to 'secure/libexec/(developers-only)')
0 files changed, 0 insertions, 0 deletions