diff options
author | Eric van Gyzen <vangyzen@FreeBSD.org> | 2018-05-29 20:30:46 +0000 |
---|---|---|
committer | Eric van Gyzen <vangyzen@FreeBSD.org> | 2018-05-29 20:30:46 +0000 |
commit | 4f9b4ac4c279650aa4f4ed7cd1b5fdfa60fbf60c (patch) | |
tree | cb5f3051d59cac5c7f8f6d9804f1bc4154b87934 /lib | |
parent | 3554f22e674e5f3cd057ee1731b466576ce95268 (diff) | |
download | src-4f9b4ac4c279650aa4f4ed7cd1b5fdfa60fbf60c.tar.gz src-4f9b4ac4c279650aa4f4ed7cd1b5fdfa60fbf60c.zip |
pmc_annotate: adhere to the API
If the 'mode' parameter was invalid, pmc_annotate() would
return EINVAL instead of setting errno and returning -1.
Sponsored by: Dell EMC
Notes
Notes:
svn path=/head/; revision=334351
Diffstat (limited to 'lib')
-rw-r--r-- | lib/libpmc/libpmc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/libpmc/libpmc.c b/lib/libpmc/libpmc.c index daea37c8c891..2826a250796b 100644 --- a/lib/libpmc/libpmc.c +++ b/lib/libpmc/libpmc.c @@ -2781,7 +2781,8 @@ pmc_allocate(const char *ctrspec, enum pmc_mode mode, if (mode != PMC_MODE_SS && mode != PMC_MODE_TS && mode != PMC_MODE_SC && mode != PMC_MODE_TC) { - return (EINVAL); + errno = EINVAL; + goto out; } bzero(&pmc_config, sizeof(pmc_config)); pmc_config.pm_cpu = cpu; |