diff options
| author | Enji Cooper <ngie@FreeBSD.org> | 2016-04-22 07:51:38 +0000 |
|---|---|---|
| committer | Enji Cooper <ngie@FreeBSD.org> | 2016-04-22 07:51:38 +0000 |
| commit | e9f8d18ebe44b3212613241b12e86b882753bc57 (patch) | |
| tree | 21d59cdc61908cbcfa4b3d0eff3c36baa18c0a18 /contrib | |
| parent | d71ca0e296cbc48e2dbdbcd0cbdb1f56d954656a (diff) | |
| download | src-e9f8d18ebe44b3212613241b12e86b882753bc57.tar.gz src-e9f8d18ebe44b3212613241b12e86b882753bc57.zip | |
Return `ret` in op_ifentry(..) to mute a -Wunused-but-set-variable warning
This will also now detect error conditions with
value->var.subs[sub - 1] == LEAF_ifPhysAddress where `string_get(..)`
could fail if iifp->physaddr and/or iifp->physaddrlen were deemed
invalid.
MFC after: 2 weeks
CID: 1006551
Reported by: Coverity, gcc
Sponsored by: EMC / Isilon Storage Division
Notes
Notes:
svn path=/head/; revision=298462
Diffstat (limited to 'contrib')
| -rw-r--r-- | contrib/bsnmp/snmp_mibII/mibII_interfaces.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/bsnmp/snmp_mibII/mibII_interfaces.c b/contrib/bsnmp/snmp_mibII/mibII_interfaces.c index 654e9c310b50..9bd794208bc5 100644 --- a/contrib/bsnmp/snmp_mibII/mibII_interfaces.c +++ b/contrib/bsnmp/snmp_mibII/mibII_interfaces.c @@ -356,7 +356,7 @@ op_ifentry(struct snmp_context *ctx, struct snmp_value *value, value->v.oid = ifp->spec_oid; break; } - return (SNMP_ERR_NOERROR); + return (ret); } /* |