diff options
| author | Enji Cooper <ngie@FreeBSD.org> | 2016-12-31 12:18:17 +0000 |
|---|---|---|
| committer | Enji Cooper <ngie@FreeBSD.org> | 2016-12-31 12:18:17 +0000 |
| commit | 8e02b381d3f079f15227fbc6bf83cac1ffebf70f (patch) | |
| tree | bdff68156a4ccb233084204552a6e8789112d238 /contrib/bsnmp | |
| parent | c4114bd1f5d597d3497ac560e0aecb3608de5b3d (diff) | |
| download | src-8e02b381d3f079f15227fbc6bf83cac1ffebf70f.tar.gz src-8e02b381d3f079f15227fbc6bf83cac1ffebf70f.zip | |
Use strlcpy when copying `com` to pdu->community to avoid potential
buffer overruns
MFC after: 1 week
Reported by: Coverity
CID: 1006823, 1006824
Notes
Notes:
svn path=/head/; revision=310957
Diffstat (limited to 'contrib/bsnmp')
| -rw-r--r-- | contrib/bsnmp/snmpd/trap.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/contrib/bsnmp/snmpd/trap.c b/contrib/bsnmp/snmpd/trap.c index cead6b5af007..30ff29304d58 100644 --- a/contrib/bsnmp/snmpd/trap.c +++ b/contrib/bsnmp/snmpd/trap.c @@ -422,7 +422,7 @@ snmp_create_v1_trap(struct snmp_pdu *pdu, char *com, const struct asn_oid *trap_oid) { memset(pdu, 0, sizeof(*pdu)); - strcpy(pdu->community, com); + strlcpy(pdu->community, com, sizeof(pdu->community)); pdu->version = SNMP_V1; pdu->type = SNMP_PDU_TRAP; @@ -439,7 +439,7 @@ snmp_create_v2_trap(struct snmp_pdu *pdu, char *com, const struct asn_oid *trap_oid) { memset(pdu, 0, sizeof(*pdu)); - strcpy(pdu->community, com); + strlcpy(pdu->community, com, sizeof(pdu->community)); pdu->version = SNMP_V2c; pdu->type = SNMP_PDU_TRAP2; |