diff options
| author | Domagoj Stolfa <domagoj.stolfa@gmail.com> | 2021-12-17 16:01:54 +0000 |
|---|---|---|
| committer | Mark Johnston <markj@FreeBSD.org> | 2021-12-17 18:10:22 +0000 |
| commit | 30ec3138edc9d491446409910f52ccb1b158253e (patch) | |
| tree | c7874783c5a6bba40192089d006253b7f70e29a2 /cddl/contrib/opensolaris/cmd/dtrace/test/tst | |
| parent | ee5686c614ba7e11e8586b2e5b02dfc550679e96 (diff) | |
| download | src-30ec3138edc9d491446409910f52ccb1b158253e.tar.gz src-30ec3138edc9d491446409910f52ccb1b158253e.zip | |
dtrace: Disable getf() as it is broken on FreeBSD
getf() on FreeBSD calls _sx_slock(), _sx_sunlock() and fget_locked().
Furthermore, it does not set the per-core fault flag, meaning it
usually ends up in a double fault panic once getf() does get called,
especially from fbt.
Reviewing the DTrace Toolkit + a number of other scripts scattered
around FreeBSD, I have not been able to find one use of getf(). Given
how broken the implementation currently is, we disable it until it
can be implemented properly.
Also comment out a test in aggs/tst.subr.d for getf().
Reviewed by: markj
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D33378
Diffstat (limited to 'cddl/contrib/opensolaris/cmd/dtrace/test/tst')
| -rw-r--r-- | cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/aggs/tst.subr.d | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/aggs/tst.subr.d b/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/aggs/tst.subr.d index 9b02e982fe0d..6668f80d81a0 100644 --- a/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/aggs/tst.subr.d +++ b/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/aggs/tst.subr.d @@ -98,7 +98,7 @@ INTFUNC(ntohll(0x1234567890abcdefL)) STRFUNC(inet_ntoa((ipaddr_t *)alloca(sizeof (ipaddr_t)))) STRFUNC(inet_ntoa6((in6_addr_t *)alloca(sizeof (in6_addr_t)))) STRFUNC(inet_ntop(AF_INET, (void *)alloca(sizeof (ipaddr_t)))) -INTFUNC(getf(0)) +/* INTFUNC(getf(0)) */ INTFUNC(strtoll("0x12EE5D5", 16)) STRFUNC(json("{\"systemtap\": false}", "systemtap")) |