aboutsummaryrefslogtreecommitdiff
path: root/bin/mkdir
diff options
context:
space:
mode:
authorMike Smith <msmith@FreeBSD.org>1998-10-20 06:37:01 +0000
committerMike Smith <msmith@FreeBSD.org>1998-10-20 06:37:01 +0000
commit2426ecdfa252acce09b680d5d928b6ea1f4cd441 (patch)
tree16c69254aa0d27aafe1be4f71a327dc60f5ae165 /bin/mkdir
parent7c0704e4465ea51cf10d97b4bbec6bad3e57d8af (diff)
downloadsrc-2426ecdfa252acce09b680d5d928b6ea1f4cd441.tar.gz
src-2426ecdfa252acce09b680d5d928b6ea1f4cd441.zip
- mkdir -m should call chmod because the high-order bits get ignored
by the kernel as a security feature of some sort. Submitted by: Wilfredo Sanchez <wsanchez@apple.com>
Notes
Notes: svn path=/head/; revision=40535
Diffstat (limited to 'bin/mkdir')
-rw-r--r--bin/mkdir/mkdir.c20
1 files changed, 19 insertions, 1 deletions
diff --git a/bin/mkdir/mkdir.c b/bin/mkdir/mkdir.c
index ed26dc80525c..e11cfb0db5dc 100644
--- a/bin/mkdir/mkdir.c
+++ b/bin/mkdir/mkdir.c
@@ -42,7 +42,7 @@ static char const copyright[] =
static char sccsid[] = "@(#)mkdir.c 8.2 (Berkeley) 1/25/94";
#endif
static const char rcsid[] =
- "$Id$";
+ "$Id: mkdir.c,v 1.11 1998/05/15 06:23:45 charnier Exp $";
#endif /* not lint */
#include <sys/types.h>
@@ -105,6 +105,15 @@ main(argc, argv)
warn("%s", *argv);
exitval = 1;
}
+ /*
+ * The mkdir() and umask() calls both honor only the low
+ * nine bits, so if you try to set a mode including the
+ * sticky, setuid, setgid bits you lose them. So chmod().
+ */
+ if (chmod(*argv, mode) == -1) {
+ warn("%s", *argv);
+ exitval = 1;
+ }
}
exit(exitval);
}
@@ -160,6 +169,15 @@ build(path, omode)
retval = 1;
break;
}
+ /*
+ * The mkdir() and umask() calls both honor only the low
+ * nine bits, so if you try to set a mode including the
+ * sticky, setuid, setgid bits you lose them. So chmod().
+ */
+ if (chmod(*path, mode) == -1) {
+ warn("%s", *path);
+ exitval = 1;
+ }
}
else if ((sb.st_mode & S_IFMT) != S_IFDIR) {
if (last)