diff options
author | Don Lewis <truckman@FreeBSD.org> | 2016-05-25 18:38:30 +0000 |
---|---|---|
committer | Don Lewis <truckman@FreeBSD.org> | 2016-05-25 18:38:30 +0000 |
commit | 92a58a9246498c0001cccbea4e33e128eb989077 (patch) | |
tree | 279197a79817df4c9694513dac5637af606e7eab /bin/ed/io.c | |
parent | 360ba6bc13d1d194f1b3a345d4afc150aba0c6ae (diff) | |
download | src-92a58a9246498c0001cccbea4e33e128eb989077.tar.gz src-92a58a9246498c0001cccbea4e33e128eb989077.zip |
Close the input FILE * in read_file() and the output FILE * in write_file()
if read_stream() or write_stream() fails to avoid leaking the FILE.
Reported by: Coverity
CID: 977702
Reviewed by: pfg
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D6554
Notes
Notes:
svn path=/head/; revision=300692
Diffstat (limited to 'bin/ed/io.c')
-rw-r--r-- | bin/ed/io.c | 27 |
1 files changed, 18 insertions, 9 deletions
diff --git a/bin/ed/io.c b/bin/ed/io.c index cf2e95906c1f..1907e7a95472 100644 --- a/bin/ed/io.c +++ b/bin/ed/io.c @@ -36,20 +36,24 @@ read_file(char *fn, long n) { FILE *fp; long size; - + int cs; fp = (*fn == '!') ? popen(fn + 1, "r") : fopen(strip_escapes(fn), "r"); if (fp == NULL) { fprintf(stderr, "%s: %s\n", fn, strerror(errno)); errmsg = "cannot open input file"; return ERR; - } else if ((size = read_stream(fp, n)) < 0) - return ERR; - else if (((*fn == '!') ? pclose(fp) : fclose(fp)) < 0) { + } + if ((size = read_stream(fp, n)) < 0) { + fprintf(stderr, "%s: %s\n", fn, strerror(errno)); + errmsg = "error reading input file"; + } + if ((cs = (*fn == '!') ? pclose(fp) : fclose(fp)) < 0) { fprintf(stderr, "%s: %s\n", fn, strerror(errno)); errmsg = "cannot close input file"; - return ERR; } + if (size < 0 || cs < 0) + return ERR; if (!scripted) fprintf(stdout, "%lu\n", size); return current_addr - n; @@ -143,19 +147,24 @@ write_file(char *fn, const char *mode, long n, long m) { FILE *fp; long size; + int cs; fp = (*fn == '!') ? popen(fn+1, "w") : fopen(strip_escapes(fn), mode); if (fp == NULL) { fprintf(stderr, "%s: %s\n", fn, strerror(errno)); errmsg = "cannot open output file"; return ERR; - } else if ((size = write_stream(fp, n, m)) < 0) - return ERR; - else if (((*fn == '!') ? pclose(fp) : fclose(fp)) < 0) { + } + if ((size = write_stream(fp, n, m)) < 0) { + fprintf(stderr, "%s: %s\n", fn, strerror(errno)); + errmsg = "error writing output file"; + } + if ((cs = (*fn == '!') ? pclose(fp) : fclose(fp)) < 0) { fprintf(stderr, "%s: %s\n", fn, strerror(errno)); errmsg = "cannot close output file"; - return ERR; } + if (size < 0 || cs < 0) + return ERR; if (!scripted) fprintf(stdout, "%lu\n", size); return n ? m - n + 1 : 0; |