aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBjoern A. Zeeb <bz@FreeBSD.org>2019-11-05 10:53:55 +0000
committerBjoern A. Zeeb <bz@FreeBSD.org>2019-11-05 10:53:55 +0000
commitcc07e75f302bf00fa4f8a963e5698e75ff4a5cc1 (patch)
treea327d4d4593f1f662a8513f3c766f6872657f5fd
parent0153183539e4de0b4be5912b6901dbe3feddfc52 (diff)
downloadsrc-cc07e75f302bf00fa4f8a963e5698e75ff4a5cc1.tar.gz
src-cc07e75f302bf00fa4f8a963e5698e75ff4a5cc1.zip
frag6 tests: set end to catch timeout as error
There are times when we have to wait for reply packets. There are either an ICMPv6 (error) reply or the expiration timeout. In these cases synchonous ICMPv6 replies should arrive, always, unless the packet is lost. Due to errors experienced with the test software sending an invlaid request on at least i386 (*) these packets are not generated. That means we are waiting for a long time for the replies or even timeout the test case. Manually set the "End" flag on these test cases as well, so they do fail rather than timeout as the sniffer timeout happens. This improves debugging options, reflects the error properly, and saves time on each test suit run. (*) The real cause for that is still to be found (see the referenced PRs) PR: 241493, 239380 MFC after: 2 weeks Sponsored by: Netflix
Notes
Notes: svn path=/head/; revision=354357
-rw-r--r--tests/sys/netinet6/frag6/frag6_02.py1
-rw-r--r--tests/sys/netinet6/frag6/frag6_04.py1
2 files changed, 2 insertions, 0 deletions
diff --git a/tests/sys/netinet6/frag6/frag6_02.py b/tests/sys/netinet6/frag6/frag6_02.py
index 4e83e9e676cd..945b428c3dac 100644
--- a/tests/sys/netinet6/frag6/frag6_02.py
+++ b/tests/sys/netinet6/frag6/frag6_02.py
@@ -98,6 +98,7 @@ def main():
sp.sendp(ip6f01, iface=args.sendif[0], verbose=False)
sleep(0.10)
+ sniffer.setEnd()
sniffer.join()
if not sniffer.foundCorrectPacket:
sys.exit(1)
diff --git a/tests/sys/netinet6/frag6/frag6_04.py b/tests/sys/netinet6/frag6/frag6_04.py
index 4f4687e0d067..6c35d4858ccb 100644
--- a/tests/sys/netinet6/frag6/frag6_04.py
+++ b/tests/sys/netinet6/frag6/frag6_04.py
@@ -95,6 +95,7 @@ def main():
sp.sendp(ip6f01, iface=args.sendif[0], verbose=False)
sleep(0.10)
+ sniffer.setEnd()
sniffer.join()
if not sniffer.foundCorrectPacket:
sys.exit(1)