aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHans Petter Selasky <hselasky@FreeBSD.org>2013-05-25 17:09:58 +0000
committerHans Petter Selasky <hselasky@FreeBSD.org>2013-05-25 17:09:58 +0000
commit273c749c93cfcc186f524281a6ae59bc8f7be033 (patch)
tree6c1af9a8cc6d61bd0d761c4e1d91477452338508
parent74b6b2bb9903e0b210d52e9e903aa28a594babe1 (diff)
downloadsrc-273c749c93cfcc186f524281a6ae59bc8f7be033.tar.gz
src-273c749c93cfcc186f524281a6ae59bc8f7be033.zip
Fix some statical clang analyzer warnings.
Notes
Notes: svn path=/head/; revision=250986
-rw-r--r--sys/dev/usb/usb_device.c3
-rw-r--r--sys/dev/usb/usb_hub.c1
-rw-r--r--sys/dev/usb/usb_msctest.c2
3 files changed, 1 insertions, 5 deletions
diff --git a/sys/dev/usb/usb_device.c b/sys/dev/usb/usb_device.c
index 82bcd7062a77..7e8181c06f84 100644
--- a/sys/dev/usb/usb_device.c
+++ b/sys/dev/usb/usb_device.c
@@ -799,9 +799,6 @@ usb_config_parse(struct usb_device *udev, uint8_t iface_index, uint8_t cmd)
/* find maximum number of endpoints */
if (ep_max < temp)
ep_max = temp;
-
- /* optimalisation */
- id = (struct usb_interface_descriptor *)ed;
}
}
diff --git a/sys/dev/usb/usb_hub.c b/sys/dev/usb/usb_hub.c
index 227f31730f6c..f82ff9baa932 100644
--- a/sys/dev/usb/usb_hub.c
+++ b/sys/dev/usb/usb_hub.c
@@ -341,7 +341,6 @@ uhub_reattach_port(struct uhub_softc *sc, uint8_t portno)
DPRINTF("reattaching port %d\n", portno);
- err = 0;
timeout = 0;
udev = sc->sc_udev;
child = usb_bus_port_get_device(udev->bus,
diff --git a/sys/dev/usb/usb_msctest.c b/sys/dev/usb/usb_msctest.c
index 1f0598ab62cf..a9b90550381d 100644
--- a/sys/dev/usb/usb_msctest.c
+++ b/sys/dev/usb/usb_msctest.c
@@ -802,7 +802,6 @@ usb_msc_eject(struct usb_device *udev, uint8_t iface_index, int method)
if (sc == NULL)
return (USB_ERR_INVAL);
- err = 0;
switch (method) {
case MSC_EJECT_STOPUNIT:
err = bbb_command_start(sc, DIR_IN, 0, NULL, 0,
@@ -844,6 +843,7 @@ usb_msc_eject(struct usb_device *udev, uint8_t iface_index, int method)
break;
default:
DPRINTF("Unknown eject method (%d)\n", method);
+ err = 0;
break;
}
DPRINTF("Eject CD command status: %s\n", usbd_errstr(err));