diff options
author | Adrian Chadd <adrian@FreeBSD.org> | 2016-06-05 07:56:28 +0000 |
---|---|---|
committer | Adrian Chadd <adrian@FreeBSD.org> | 2016-06-05 07:56:28 +0000 |
commit | 14b258b8066342dc82272f43ceb399ffc8ca7e35 (patch) | |
tree | 0871d61d607a40293db2dda698e20adb89affdba | |
parent | 4bfbed726462a37d0c42238d5380040880299501 (diff) | |
download | src-14b258b8066342dc82272f43ceb399ffc8ca7e35.tar.gz src-14b258b8066342dc82272f43ceb399ffc8ca7e35.zip |
[bwn] Add missing firmware release calls.
This trips me up whenever I'm fooling around with partially supported
NICs that fail to fully attach or initialise - the firmware gets loaded
and references, but something fails - and the firmware references
aren't cleaned up.
Notes
Notes:
svn path=/head/; revision=301435
-rw-r--r-- | sys/dev/bwn/if_bwn.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/sys/dev/bwn/if_bwn.c b/sys/dev/bwn/if_bwn.c index 27f919474dd3..4967af1d1dd2 100644 --- a/sys/dev/bwn/if_bwn.c +++ b/sys/dev/bwn/if_bwn.c @@ -750,6 +750,7 @@ bwn_detach(device_t dev) if (mac->mac_msi != 0) pci_release_msi(dev); mbufq_drain(&sc->sc_snd); + bwn_release_firmware(mac); BWN_LOCK_DESTROY(sc); return (0); } @@ -1328,6 +1329,7 @@ bwn_attach_core(struct bwn_mac *mac) siba_dev_down(sc->sc_dev, 0); fail: siba_powerdown(sc->sc_dev); + bwn_release_firmware(mac); return (error); } @@ -3930,6 +3932,7 @@ bwn_fw_gets(struct bwn_mac *mac, enum bwn_fwtype type) } } else if (rev < 11) { device_printf(sc->sc_dev, "no PCM for rev %d\n", rev); + bwn_release_firmware(mac); return (EOPNOTSUPP); } |