From acf65eef23ef16b34ce7172b8ffb324a4557cd50 Mon Sep 17 00:00:00 2001 From: Konstantin Belousov Date: Sat, 18 Apr 2020 03:09:25 +0000 Subject: sendfile: When all io finished, assert that sfio->pa[] is in expected state. It must contain fully restored contigous run of the wired pages from the object, except possible trimmed tail. Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 2 weeks --- sys/kern/kern_sendfile.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'sys/kern/kern_sendfile.c') diff --git a/sys/kern/kern_sendfile.c b/sys/kern/kern_sendfile.c index e1715fd55afd..0b72df68eee4 100644 --- a/sys/kern/kern_sendfile.c +++ b/sys/kern/kern_sendfile.c @@ -313,6 +313,24 @@ sendfile_iodone(void *arg, vm_page_t *pa, int count, int error) if (!refcount_release(&sfio->nios)) return; +#ifdef INVARIANTS + for (i = 1; i < sfio->npages; i++) { + if (sfio->pa[i] == NULL) + break; + KASSERT(vm_page_wired(sfio->pa[i]), + ("sfio %p page %d %p not wired", sfio, i, sfio->pa[i])); + if (i == 0) + continue; + KASSERT(sfio->pa[0]->object == sfio->pa[i]->object, + ("sfio %p page %d %p wrong owner %p %p", sfio, i, + sfio->pa[i], sfio->pa[0]->object, sfio->pa[i]->object)); + KASSERT(sfio->pa[0]->pindex + i == sfio->pa[i]->pindex, + ("sfio %p page %d %p wrong index %jx %jx", sfio, i, + sfio->pa[i], (uintmax_t)sfio->pa[0]->pindex, + (uintmax_t)sfio->pa[i]->pindex)); + } +#endif + vm_object_pip_wakeup(sfio->obj); if (sfio->m == NULL) { -- cgit v1.2.3