| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally, these tests accidentally used broadcast addresses when they
should've used unicast addresses. That the tests passed prior to r337736
was accidental.
Submitted by: ae
Reviewed by: olivier
MFC after: 2 weeks
Notes:
svn path=/head/; revision=337984
|
|
|
|
|
|
|
|
|
| |
Test the limitation on number of frames per packet introduced in pf in r337969.
Sponsored by: Klara Systems
Notes:
svn path=/head/; revision=337971
|
|
|
|
| |
Notes:
svn path=/head/; revision=337941
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Two of these testcases require software crypto to be enabled. Curiously, it
isn't by default.
PR: 230671
Reported by: Jenkins
Reviewed by: cem
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D16755
Notes:
svn path=/head/; revision=337933
|
|
|
|
|
|
|
|
|
|
| |
FreeBSD's mkstemp sets the temporary file's permissions to 600, and has ever
since mkstemp was added in 1987. Coverity's warning is still relevant for
portable programs since OpenGroup does not require that behavior, and POSIX
didn't until 2008. But none of these programs are portable.
Notes:
svn path=/head/; revision=337930
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
umask(2) should always be used prior to mkstemp(3) so the temporary file
won't be created with insecure permissions.
Reported by: Coverity
CID: 1331605 1347173 1375366 1339800 1331604 1296056 1296060
CID: 1296057 1296062
MFC after: 2 weeks
Notes:
svn path=/head/; revision=337929
|
|
|
|
|
|
|
|
|
|
| |
Apparently kldstat requires the full module name, including busname
Reported by: Jenkins
MFC after: 2 weeks
Notes:
svn path=/head/; revision=337911
|
|
|
|
|
|
|
|
|
|
| |
Reported by: Renato Botelho <garga.bsd@gmail.com>
MFC after: 3 days
X-MFC-with: r337814
Sponsored by: Dell EMC
Notes:
svn path=/head/; revision=337820
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A follow-up to r337812 to catch a couple more memory leaks that should
have been included in that change.
Reported by: Coverity
CID: 1296064, 1296067 (for real this time)
MFC after: 3 days
X-MFC-with: r337812
Sponsored by: Dell EMC
Notes:
svn path=/head/; revision=337814
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The libkqueue tests have several places that leak memory by using an
idiom like:
puts(kevent_to_str(kevp));
Rework to save the pointer returned from kevent_to_str() and then
free() it after it has been used.
Reported by: asomers (pointer to Coverity), Coverity
CID: 1296063, 1296064, 1296065, 1296066, 1296067, 1350287, 1394960
Sponsored by: Dell EMC
Notes:
svn path=/head/; revision=337812
|
|
|
|
|
|
|
|
|
|
| |
This tests for the problem reported in PR 229241, where using a group
name in 'set skip on' did not work as expected.
Sponsored by: Essen Hackathon
Notes:
svn path=/head/; revision=337646
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add some more cases to the truncation test.
- Remove the "expect fail" annotations.
PR: 131876
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D16562
Notes:
svn path=/head/; revision=337424
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With r337328, the test hangs becase the sendmsg() call will block until
the receive buffer is at least partially drained. Fix the problem by
using a non-blocking socket and allowing short writes. Also assert
that a SCM_CREDS message was received if one was expected.
PR: 181741
MFC after: 1 month
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D16516
Notes:
svn path=/head/; revision=337329
|
|
|
|
|
|
|
|
|
| |
It takes 49s to complete this test in QEMU/RISC-V.
Sponsored by: DARPA, AFRL
Notes:
svn path=/head/; revision=337237
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable the LOCAL_PEERCRED socket option for unix domain stream sockets
created with socketpair(2). Previously, it only worked with unix domain
stream sockets created with socket(2)/listen(2)/connect(2)/accept(2).
PR: 176419
Reported by: Nicholas Wilson <nicholas@nicholaswilson.me.uk>
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D16350
Notes:
svn path=/head/; revision=337222
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove return statements in functions with a void return type.
- Allocate enough space for the SCM_CREDS and SCM_RIGHTS messages
received in the rights_creds_payload test.
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Notes:
svn path=/head/; revision=337059
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an error occurs while copying a SCM_RIGHTS message to userspace,
we free the mbuf containing externalized rights, leaking them.
PR: 131876
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Notes:
svn path=/head/; revision=336957
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ian@ pointed out that in the test_abstime() function time(NULL) is
used twice; once in an "if" test and again in the enclosed error
message. If the true branch was taken and the process got preempted
before the second time(NULL) call, by the time the error message was
generated enough time could have elapsed that the message could claim
that the event came "too early" but print an event time that was after
the expected timeout. Correct by making the time(NULL) call only once
and using that returned time in both the "if" test and the error
message.
Reported by: ian@
MFC after: 4 days
X-MFC-with: r336761, r336781, r336802
Sponsored by: Dell EMC
Notes:
svn path=/head/; revision=336905
|
|
|
|
|
|
|
|
|
|
| |
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D16116
Notes:
svn path=/head/; revision=336875
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Another cast for printing an intmax_t was needed in a kqueue test for
some arches.
Pointy-hat: me (twice)
MFC after: 1 week
X-MFC-with: r336761, r336781
Sponsored by: Dell EMC
Notes:
svn path=/head/; revision=336802
|
|
|
|
|
|
|
|
|
|
|
|
| |
A cast for printing an intmax_t was needed in a kqueue test for some
arches.
MFC after: 1 week
X-MFC-with: r336761
Sponsored by: Dell EMC
Notes:
svn path=/head/; revision=336781
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a timer is updated (re-added) with a different time period
(specified in the .data field of the kevent), the new time period has
no effect; the timer will not expire until the original time has
elapsed. This violates the documented behavior as the kqueue(2) man
page says (in part) "Re-adding an existing event will modify the
parameters of the original event, and not result in a duplicate
entry."
This modification, adapted from a patch submitted by cem@ to PR214987,
fixes the kqueue system to allow updating a timer entry. The
kevent timer behavior is changed to:
* When a timer is re-added, update the timer parameters to and
re-start the timer using the new parameters.
* Allow updating both active and already expired timers.
* When the timer has already expired, dequeue any undelivered events
and clear the count of expirations.
All of these changes address the original PR and also bring the
FreeBSD and macOS kevent timer behaviors into agreement.
A few other changes were made along the way:
* Update the kqueue(2) man page to reflect the new timer behavior.
* Fix man page style issues in kqueue(2) diagnosed by igor.
* Update the timer libkqueue system test to test for the updated
timer behavior.
* Fix the (test) libkqueue common.h file so that it includes
config.h which defines various HAVE_* feature defines, before the
#if tests for such variables in common.h. This enables the use of
the actual err(3) family of functions.
* Fix the usages of the err(3) functions in the tests for incorrect
type of variables. Those were formerly undiagnosed due to the
disablement of the err(3) functions (see previous bullet point).
PR: 214987
Reported by: Brian Wellington <bwelling@xbill.org>
Reviewed by: kib
MFC after: 1 week
Relnotes: yes
Sponsored by: Dell EMC
Differential Revision: https://reviews.freebsd.org/D15778
Notes:
svn path=/head/; revision=336761
|
|
|
|
|
|
|
|
|
|
| |
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D16395
Notes:
svn path=/head/; revision=336728
|
|
|
|
|
|
|
|
|
|
|
| |
These tests are failing due to PR 229930. Unfortunately, TAP tests can't be
marked as expected failures.
PR: 229930
Reported by: Jenkins
Notes:
svn path=/head/; revision=336617
|
|
|
|
|
|
|
|
| |
PR: 131876
MFC after: 1 week
Notes:
svn path=/head/; revision=336614
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These syscalls were always supposed to have been auditted, but due to
oversights never were.
PR: 228374
Reported by: aniketp
Reviewed by: aniketp
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D16388
Notes:
svn path=/head/; revision=336604
|
|
|
|
|
|
|
|
|
|
|
|
| |
In r321967 ngie "fixed" these tests by changing their expectations to match
the device numbers produced by the new ino64 code. But it wasn't the tests
that were broken, it was the kernel. bde fixed the kernel in r335053.
Reported by: Jenkins
MFC after: Never (only applies to >= 12)
Notes:
svn path=/head/; revision=336588
|
|
|
|
|
|
|
|
|
|
|
|
| |
These tests were fixed by r335584
PR: 228094
PR: 201447
MFC after: 2 weeks
X-MFC-With: 335584
Notes:
svn path=/head/; revision=336586
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These three syscalls aren't currently audited correctly, so the tests are
marked as expected failures.
PR: 228374
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D16379
Notes:
svn path=/head/; revision=336580
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
auditon(2) is an ioctl-like syscall with several different variants, each of
which has a distinct audit event. This commit tests the remaining variants
that weren't tested in r336564.
Submitted by: aniketp
MFC after: 2 weeks
X-MFC-With: 336564
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D16381
Notes:
svn path=/head/; revision=336579
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
auditon(2) is an ioctl-like syscall with several different variants, each of
which has a distinct audit event. Write separate audit(4) tests for each
variant.
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D16255
Notes:
svn path=/head/; revision=336564
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, fix a bug in common code that could cause other tests to fail: using
ppoll(2) in combination with buffered I/O for /dev/auditpipe. Fix it by
disabling buffering.
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D16099
Notes:
svn path=/head/; revision=336418
|
|
|
|
|
|
|
|
| |
A very basic syncproxy test: set up a connection via a synproxy rule.
This triggeres the panic fixed in r336273.
Notes:
svn path=/head/; revision=336297
|
|
|
|
|
|
|
|
|
|
| |
Enable ptrace() tests using breakpoint() on these architectures.
Reviewed by: andrew
Differential Revision: https://reviews.freebsd.org/D15191
Notes:
svn path=/head/; revision=336053
|
|
|
|
|
|
|
|
|
|
| |
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D16086
Notes:
svn path=/head/; revision=335842
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes ntp_adjtime, auditctl, acct, auditon, and clock_settime. Includes
quotactl, mount, nmount, swapon, and swapoff in failure mode only. Success
tests for those syscalls will follow. Also includes reboot(2) in failure
mode only. That one can't be tested in success mode.
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15898
Notes:
svn path=/head/; revision=335792
|
|
|
|
|
|
|
|
|
|
| |
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D16035
Notes:
svn path=/head/; revision=335791
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix several incorrect buffer size arguments and a file descriptor leak.
Submitted by: aniketp
Reported by: Coverity
CID: 1393489 1393501 1393509 1393510 1393514 1393515 1393516
CID: 1393517 1393518 1393519
MFC after: 2 weeks
X-MFC-With: 335284
X-MFC-With: 335318
X-MFC-With: 335320
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D16000
Notes:
svn path=/head/; revision=335703
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested syscalls include rfork(2), chdir(2), fchdir(2), chroot(2),
getresuid(2), getresgid(2), setpriority(2), setgroups(2), setpgrp(2),
setrlimit(2), setlogin(2), mlock(2), munlock(2), minherit(2), rtprio(2),
profil(2), ktrace(2), ptrace(2), fork(2), umask(2), setuid(2), setgid(2),
seteuid(2), and setegid(2). The last six are only tested in the success
case, either because they're infalliable or a failure is difficult to cause
on-demand.
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15966
Notes:
svn path=/head/; revision=335679
|
|
|
|
|
|
|
|
|
|
| |
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15963
Notes:
svn path=/head/; revision=335677
|
|
|
|
|
|
|
|
|
|
| |
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15897
Notes:
svn path=/head/; revision=335528
|
|
|
|
|
|
|
|
|
|
| |
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15895
Notes:
svn path=/head/; revision=335378
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes utimes(2), futimes(2), lutimes(2), futimesat(2), mprotect(2), and
undelete(2). undelete, for now, is tested only in failure mode.
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15893
Notes:
svn path=/head/; revision=335374
|
|
|
|
|
|
|
|
|
|
| |
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15872
Notes:
svn path=/head/; revision=335354
|
|
|
|
|
|
|
|
|
|
| |
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15871
Notes:
svn path=/head/; revision=335320
|
|
|
|
|
|
|
|
|
|
| |
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15869
Notes:
svn path=/head/; revision=335319
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes extattr_{set_file, _set_fd, _set_link, _delete_file, _delete_fd,
_delete_link}
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15867
Notes:
svn path=/head/; revision=335318
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was correct in the final version on Phabricator, but somehow I screwed
up applying the patch locally.
Reported by: linimon
Pointy-hat-to: asomers
MFC after: 2 weeks
X-MFC-With: 335307
Notes:
svn path=/head/; revision=335311
|
|
|
|
|
|
|
|
|
|
|
|
| |
includes shmget, shmat, shmdt, and shmctl
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15860
Notes:
svn path=/head/; revision=335307
|
|
|
|
|
|
|
|
|
|
| |
Submitted by: aniketp
MFC after: 2 weeks
Sponsored by: Google, Inc. (GSoC 2018)
Differential Revision: https://reviews.freebsd.org/D15853
Notes:
svn path=/head/; revision=335294
|