aboutsummaryrefslogtreecommitdiff
path: root/sys/cam
Commit message (Collapse)AuthorAgeFilesLines
* Remove sparc64 kernel supportWarner Losh2020-02-031-11/+0
| | | | | | | | | Remove all sparc64 specific files Remove all sparc64 ifdefs Removee indireeect sparc64 ifdefs Notes: svn path=/head/; revision=357455
* Fix spelling of removableWarner Losh2020-01-291-1/+1
| | | | Notes: svn path=/head/; revision=357236
* Create a convenince wrapper to fill in a CAM_PATH_INQ request for MMC sims. PassWarner Losh2020-01-272-0/+33
| | | | | | | in the parameters needed for the different sims, but it's almost all identical. Notes: svn path=/head/; revision=357181
* In compatibility structure substitute 'struct callout_handle'Gleb Smirnoff2020-01-221-1/+1
| | | | | | | to 'struct callout *' pointer of the same size. Notes: svn path=/head/; revision=356971
* Const-poison the cam_sim_* convenience accessor functions.Warner Losh2020-01-091-10/+10
| | | | | | | These don't modify the cam_sim, so make that parameter const. Notes: svn path=/head/; revision=356557
* Fix typo: MANGAEMENT_PROTOCOL_OUT -> MANAGEMENT_PROTOCOL_OUT.Gleb Popov2020-01-091-1/+1
| | | | | | | Approved by: allanjude Notes: svn path=/head/; revision=356556
* vfs: drop the mostly unused flags argument from VOP_UNLOCKMateusz Guzik2020-01-031-7/+7
| | | | | | | | | | | Filesystems which want to use it in limited capacity can employ the VOP_UNLOCK_FLAGS macro. Reviewed by: kib (previous version) Differential Revision: https://reviews.freebsd.org/D21427 Notes: svn path=/head/; revision=356337
* Use atomic for start_count in devstat_start_transaction().Alexander Motin2019-12-301-13/+1
| | | | | | | | | | | Combined with earlier nstart/nend removal it allows to remove several locks from request path of GEOM and few other places. It would be cool if we had more SMP-friendly statistics, but this helps too. Sponsored by: iXsystems, Inc. Notes: svn path=/head/; revision=356200
* Make pass(4) handle misaligned buffers of MAXPHYS size.Alexander Motin2019-12-231-10/+10
| | | | | | | | | | | | | | | | | | | Since we are already using malloc()+copyin()/copyout() for smaller data blocks, and since new asynchronous API does it always, I see no reason to keep this ugly artificial size/alignment limitation in old API. Tape applications suffer enough from the MAXPHYS limitations by itself, and additional alignment requirement, often halving effectively usable block size, does not help. It would be good to use unmapped I/O here instead, but it require some HBA drivers polishing first to support non-BIO unmapped buffers. MFC after: 2 weeks Sponsored by: iXsystems, Inc. Notes: svn path=/head/; revision=356042
* Revert r355833Warner Losh2019-12-171-8/+11
| | | | | | | | While it works on nda, it fails on ada and/or da for at least zfs with a modify after free issue on a trim BIO. Revert while I rework it to fix those devices. Notes: svn path=/head/; revision=355865
* Revert r355831Warner Losh2019-12-171-11/+0
| | | | | | | | It wasn't supposed to change the defaults, but actually does. Back this out until that can be sorted out. Notes: svn path=/head/; revision=355843
* Implement bio_speedupWarner Losh2019-12-171-2/+37
| | | | | | | | | | | | | | | | | | | | | | | React to the BIO_SPEED command in the cam io scheduler by completing as successful BIO_DELETE commands that are pending, up to the length passed down in the BIO_SPEEDUP cmomand. The length passed down is a hint for how much space on the drive needs to be recovered. By completing the BIO_DELETE comomands, this allows the upper layers to allocate and write to the blocks that were about to be trimmed. Since FreeBSD implements TRIMSs as advisory, we can eliminliminate them and go directly to writing. The biggest benefit from TRIMS coomes ffrom the drive being able t ooptimize its free block pool inthe log run. There's little nto no bene3efit in the shoort term. , sepeciall whn the trim is followed by a write. Speedup lets us make this tradeoff. Reviewed by: kirk, kib Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D18351 Notes: svn path=/head/; revision=355837
* Eliminate the TRIM_ACTIVE flag.Warner Losh2019-12-171-11/+8
| | | | | | | | | | | Rather than a trim active flag, have a counter that can be used to have a absolute limit on the number of trims in flight independent of any I/O limiting factors. Sponsored by: Netflix Notes: svn path=/head/; revision=355834
* Tweak the ddb show cam iosched command a bit.Warner Losh2019-12-171-3/+3
| | | | | | | | | | | For each of the different queue types, list the name of the queue. While it can be worked out from context, this makes it more useful and clearer. Sponsored by: Netflix Notes: svn path=/head/; revision=355833
* Add rate limiters to TRIM.Warner Losh2019-12-171-2/+42
| | | | | | | | | | | | Add rate limiters to trims. Trims are a bit different than reads or writes in that they can be combined, so some care needs to be taken where we rate limit them. Additional work will be needed to push the working rate limit below the I/O quanta rate for things like IOPS. Sponsored by: Netflix Notes: svn path=/head/; revision=355832
* NVME trim stuff.Warner Losh2019-12-171-0/+11
| | | | | | | | | | | | | | | | | | | Add two sysctls to control pacing of nvme trims. kern.cam.nda.X.goal_trim is the number of upper layer BIO_DEELETE requests to try to collecet before sending TRIM down too the nvme drive. trim_ticks is the number of ticks, at mosot, to wait for at least goal_trim BIOS_DELEETE requests to come in. Trim pacing is useful when a large number off disjoint trims are comoing in from the upper layers. Since we have no way to chain toogether trims from the upper layers that are sent down, this acts as a hueristic to group trims into reasonable sized chunks. What's reasonable varies from drive to drive. Sponsored by: Netflix Notes: svn path=/head/; revision=355831
* Revert r355813Warner Losh2019-12-162-20/+2
| | | | | | | | It was extracted from a larger tree and is incomplete. Will resubmit after reworking. Notes: svn path=/head/; revision=355817
* Implement a system-wide limit or da and ada devices for delete.Warner Losh2019-12-162-2/+20
| | | | | | | | | | | Excesively large TRIMs can result in timeouts, which cause big problems. Limit trims to 1GB to mititgate these issues. Reviewed by: scottl Differential Revision: https://reviews.freebsd.org/D22809 Notes: svn path=/head/; revision=355813
* Use callout_func_t instead of the deprecated timeout_t.John Baldwin2019-12-104-5/+5
| | | | | | | | Reviewed by: kib, imp Differential Revision: https://reviews.freebsd.org/D22752 Notes: svn path=/head/; revision=355601
* vfs: introduce v_irflag and make v_type smallerMateusz Guzik2019-12-081-1/+1
| | | | | | | | | | | | | | | | | | The current vnode layout is not smp-friendly by having frequently read data avoidably sharing cachelines with very frequently modified fields. In particular v_iflag inspected for VI_DOOMED can be found in the same line with v_usecount. Instead make it available in the same cacheline as the v_op, v_data and v_type which all get read all the time. v_type is avoidably 4 bytes while the necessary data will easily fit in 1. Shrinking it frees up 3 bytes, 2 of which get used here to introduce a new flag field with a new value: VIRF_DOOMED. Reviewed by: kib, jeff Differential Revision: https://reviews.freebsd.org/D22715 Notes: svn path=/head/; revision=355537
* ses: sanitize illegal strings in SES element descriptorsAlan Somers2019-12-061-2/+32
| | | | | | | | | | | | | | | | | | The SES4r3 standard requires that element descriptors may only contain ASCII characters in the range 0x20 to 0x7e. Some SuperMicro expanders violate that rule. This patch adds a sanity check to ses(4). Descriptors in violation will be replaced by "<invalid>". This patch fixes "sesutil --libxo xml" on such systems. Previously it would generate non-well-formed XML output. PR: 241929 Reviewed by: allanjude MFC after: 2 weeks Sponsored by: Axcient Notes: svn path=/head/; revision=355430
* Mark some more hot global variables with __read_mostly.Alexander Motin2019-12-041-1/+1
| | | | | | | MFC after: 1 week Notes: svn path=/head/; revision=355404
* Regularize my copyright noticeWarner Losh2019-12-041-4/+3
| | | | | | | | | | | | o Remove All Rights Reserved from my notices o imp@FreeBSD.org everywhere o regularize punctiation, eliminate date ranges o Make sure that it's clear that I don't claim All Rights reserved by listing All Rights Reserved on same line as other copyright holders (but not me). Other such holders are also listed last where it's clear. Notes: svn path=/head/; revision=355394
* Fix a hang introduced in r351599.Kenneth D. Merry2019-12-021-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | My changes in 351599 (kindly committed by avg) made the cd(4) media check asynchronous to avoid a sleep while holding a mutex. There was a difficult to reproduce bug with those changes that caused a hang on boot on some single processor machines/VMs. Leandro Lupori managed to reproduce the bug, diagnose it, and supplied a patch! Here is his analysis, from the PR: ====== I was able to reproduce the problem described in comment#14. Actually, I wasn't trying to reproduce it, I just started seeing it a few weeks ago, in CURRENT. I can reproduce it consistently, by using QEMU to run a PowerPC64 VM with a single core/thread (-smp 1). It happens only when there is no media in the emulated CD-ROM, a device that QEMU adds by default, unless -nodefaults is specified in command line. I've debugged it and this is what I've found: 1- After the CD probe is successful, GEOM will try to open the device, which will end up calling cdcheckmedia(), that sets CD state to CD_STATE_MEDIA_PREVENT. 2- Next, scsi_prevent() is executed and succeeds, the CD_FLAG_DISC_LOCKED flag is set and CD state moves to CD_STATE_MEDIA_SIZE. 3- Next, scsi_read_capacity() is executed and fails, state is set to CD_STATE_MEDIA_ALLOW, cdmediaprobedone() is called and wakes up cdcheckmedia(). 4- Then, when cdstart() is invoked to process CD_STATE_MEDIA_ALLOW, it first checks if CD_FLAG_DISC_LOCKED is set, and if so skips directly to CD_STATE_MEDIA_SIZE state. This will repeat the steps of bullet 3, entering an infinite MEDIA_SIZE command loop. When there is a least another core/thread, the GEOM thread that performed the initial cdopen() will get scheduled again, closing the CD device, that will call cdprevent(PR_ALLOW) that clears the CD_FLAG_DISC_LOCKED flag and breaks the loop. So, apparently, the problem is CD_STATE_MEDIA_ALLOW being skipped when CD_FLAG_DISC_LOCKED is set. If I understand correctly, in this case, the state should be advanced to CD_STATE_MEDIA size only when the current state is CD_STATE_MEDIA_PREVENT. ===== PR: kern/219857 Submitted by: Leandro Lupori <leandro.lupori@gmail.com> MFC after: 1 week Notes: svn path=/head/; revision=355299
* Do not retry long ready waits if previous gave nothing.Alexander Motin2019-11-222-1/+13
| | | | | | | | | | | | | | | | I have some disks reporting "Logical unit is in process of becoming ready" for about half an hour before finally reporting failure. During that time CAM waits for the readiness during ~2 minutes for each request, that makes system boot take very long time. This change reduces wait times for the following requests to ~1 second if previously long wait for that device has timed out. MFC after: 2 weeks Sponsored by: iXsystems, Inc. Notes: svn path=/head/; revision=355023
* MMCCAM: defer release of ccb until we're done with itKyle Evans2019-11-221-1/+1
| | | | | | | | | | | If we've found a device, we attempt to call xpt_action() on a ccb that's already been released. Simply defer release until after we're done with it. Reviewed by: imp, scottl MFC after: 1 week Notes: svn path=/head/; revision=355015
* Remove xpt_lock mutex.Alexander Motin2019-11-221-6/+1
| | | | | | | | | | CAM does not require SIM locks for years, and obviously does not require it for completely virtual XPT SIM. MFC after: 2 weeks Notes: svn path=/head/; revision=355013
* Make CAM use root_mount_hold_token() to delay boot.Alexander Motin2019-11-223-70/+56
| | | | | | | | | | | | | | | | | | Before this change CAM used config_intrhook_establish() for this purpose, but that approach does not allow to delay it again after releasing once. USB stack uses root_mount_hold() to delay boot until bus scan is complete. But once it is, CAM had no time to scan SCSI bus, registered by umass(4), if it already done other scans and called config_intrhook_disestablish(). The new approach makes it work smooth, assuming the USB device is found during the initial bus scan. Devices appearing on USB bus later may still require setting kern.cam.boot_delay, but hopefully those are minority. MFC after: 2 weeks Sponsored by: iXsystems, Inc. Notes: svn path=/head/; revision=355010
* Remove NEEDGIANT from the scsi_sg /dev node. It likely has not beenScott Long2019-11-221-1/+1
| | | | | | | | | needed for many years. Reported by: imp Notes: svn path=/head/; revision=355009
* Set handling for some "Logical unit not ready" errors.Alexander Motin2019-11-201-17/+23
| | | | | | | | MFC after: 2 weeks Sponsored by: iXsystems, Inc. Notes: svn path=/head/; revision=354914
* Fix a race between daopen and damediapollWarner Losh2019-11-131-0/+1
| | | | | | | | | | | | | | | | | | | | | | When we do a daopen, we call dareprobe and wait for the results. The repoll runs the da state machine up through the DA_STATE_RC* and then exits. For removable media, we poll the device every 3 seconds with a TUR to see if it has disappeared. This introduces a race. If the removable device has lots of partitions, and if it's a little slow (like say a USB2 connected USB stick), then we can have a fair amount of time that this reporbe is going on for. If, during that time, damediapoll fires, it calls daschedule which changes the scheduling priority from NONE to NORMAL. When that happens, the careful single stepping in the da state machine is disrupted and we wind up sceduling multiple read capacity calls. The first one succeeds and releases the reference. The second one succeeds and releases the reference (and panics if the right code is compiled into the da driver). To avoid the race, only do the TUR calls while in state normal, otherwise just reschedule damediapoll. This prevents the race from happening. Notes: svn path=/head/; revision=354668
* Add asserts for some state transitionsWarner Losh2019-11-111-0/+15
| | | | | | | | | | | | | | | For the PROBEWP and PROBERC* states, add assertiosn that both the da device state is in the right state, as well as the ccb state is the right one when we enter dadone_probe{wp,rc}. This will ensure that we don't sneak through when we're re-probing the size and write protection status of the device and thereby leak a reference which can later lead to an invalidated peripheral going away before all references are released (and resulting panic). Reviewed by: scottl, ken Differential Revision: https://reviews.freebsd.org/D22295 Notes: svn path=/head/; revision=354623
* Update the softc state of the da driver before releasing the CCB.Warner Losh2019-11-111-10/+10
| | | | | | | | | | | | | | | | | | | | | | | There are contexts where releasing the ccb triggers dastart() to be run inline. When da was written, there was always a deferral, so it didn't matter much. Now, with direct dispatch, we can call dastart from the dadone* routines. If the probe state isn't updated, then dastart will redo things with stale information. This normally isn't a problem, because we run the probe state machine once at boot... Except that we also run it for each open of the device, which means we can have multiple threads racing each other to try to kick off the probe. However, if we update the state before we release the CCB, we can avoid the race. While it's needed only for the probewp and proberc* states, do it everywhere because it won't hurt the other places. The race here happens because we reprobe dozens of times on boot when drives have lots of partitions. We should consider caching this info for 1-2 seconds to avoid this thundering hurd. Reviewed by: scottl, ken Differential Revision: https://reviews.freebsd.org/D22295 Notes: svn path=/head/; revision=354622
* Require and enforce that dareprobe() has to be called with the periph lock held.Warner Losh2019-11-111-2/+4
| | | | | | | | Reviewed by: scottl, ken Differential Revision: https://reviews.freebsd.org/D22295 Notes: svn path=/head/; revision=354621
* Fix panic message to indicate right action that was improper.Warner Losh2019-11-111-1/+1
| | | | | | | | Reviewed by: scottl, ken Differential Revision: https://reviews.freebsd.org/D22295 Notes: svn path=/head/; revision=354620
* Add GEOM attribute to report physical device name, and report itEdward Tomasz Napierala2019-11-095-0/+10
| | | | | | | | | | | | | | | via 'diskinfo -v'. This avoids the need to track it down via CAM, and should also work for disks that don't use CAM. And since it's inherited thru the GEOM hierarchy, in most cases one doesn't need to walk the GEOM graph either, eg you can use it on a partition instead of disk itself. Reviewed by: allanjude, imp Sponsored by: Klara Inc Differential Revision: https://reviews.freebsd.org/D22249 Notes: svn path=/head/; revision=354571
* Remove lock from CTL camsim frontend.Alexander Motin2019-11-031-31/+9
| | | | | | | | | CAM does not need a SIM lock for quite a while, and CTL never needed it. MFC after: 2 weeks Notes: svn path=/head/; revision=354268
* nda(4): Remove unnecessary union and avoid Clang -Wsizeof-array-divwarningBrooks Davis2019-10-241-9/+7
| | | | | | | | | | | | | | | | | | Clang trunk recently gained this new warning, and complains about the sizeof(trim->data) / sizeof(struct nvme_dsm_range) expression, since the left hand side's element type (char) does not match the right hand side's type. The byte buffer is unnecessary so we can remove it to clean up the code and fix the warning at the same time. No functional change. Submitted by: James Clarke <jrtc27@jrtc27.com> Reviewed by: imp Sponsored by: DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D21912 Notes: svn path=/head/; revision=354054
* Add kern.cam.da.X.quirks tunable, similar existing for ada.Alexander Motin2019-09-261-0/+8
| | | | | | | | | Submitted by: Michael Lass MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D20677 Notes: svn path=/head/; revision=352743
* Fix assumptions of only one device per SES slot.Alexander Motin2019-09-112-15/+21
| | | | | | | | | | | It is typical to have one, but no longer true for multi-actuator HDDs with separate LUN for each actuator. MFC after: 4 days Sponsored by: iXsystems, Inc. Notes: svn path=/head/; revision=352201
* Supply SAT layer with valid transfer sizes.Alexander Motin2019-09-071-2/+2
| | | | | | | | | | | | | | | | | | | | This is a rework of r344701, that noticed that number of bytes passes to 8 bit sector count field gets truncated. First decision was to not pass anything, since ATA specs define the field as N/A. But it appeared to be a problem for some SAT devices, that require information about data transfer to operate properly. Some additional investigation shown that it is quite a common practice to set unused fields of ATA commands (fortunately ATA specs formally allow it) to supply the information to SAT layer. I have found SAS-SATA interposer that does not allow pass-through without it. As side effect, reduce code duplication by removing ata_do_28bit_cmd() function, replacing it with more universal ata_do_cmd(). MFC after: 1 week Sponsored by: iXsystems, Inc. Notes: svn path=/head/; revision=352011
* Take proper lock in ses_setphyspath_callback().Alexander Motin2019-08-295-4/+8
| | | | | | | | | | | | | | | XPT_DEV_ADVINFO call should be protected by the lock of the specific device it is addressed to, not the lock of SES device. In some weird case, probably with hardware violating standards, it sometimes caused NULL dereference due to race. To protect from it further, add lock assertion to *_dev_advinfo(). MFC after: 1 week Sponsored by: iXsystems, Inc. Notes: svn path=/head/; revision=351606
* scsi_cd: whitespace cleanupAndriy Gapon2019-08-291-111/+110
| | | | | | | | | Remove trailing whitespace and fix mixed indentation. MFC after: 3 weeks Notes: svn path=/head/; revision=351601
* scsi_cd: ifdef out cdsize()Andriy Gapon2019-08-291-1/+3
| | | | | | | | | It was used only by the old cdcheckmedia(). MFC after: 3 weeks Notes: svn path=/head/; revision=351600
* scsi_cd: make the media check asynchronousAndriy Gapon2019-08-292-43/+554
| | | | | | | | | | | | This makes the media check process asynchronous, so we no longer block in cdstrategy() to check for media. PR: 219857 Obtained from: ken MFC after: 3 weeks Notes: svn path=/head/; revision=351599
* Always check cam_periph_error() status for ERESTART.Alexander Motin2019-08-271-4/+6
| | | | | | | | | | | | Even if we do not expect retries, we better be sure, since otherwise it may result in use after free kernel panic. I've noticed that it retries SCSI_STATUS_BUSY even with SF_NO_RECOVERY | SF_NO_RETRY. MFC after: 1 week Sponsored by: iXsystems, Inc. Notes: svn path=/head/; revision=351550
* Make `camcontrol modepage` support block descriptors.Alexander Motin2019-08-072-2/+4
| | | | | | | | | | | | | | | | | | | | It allows to read and write block descriptors alike to mode page parameters. It allows to change block size or short-stroke HDDs or overprovision SSDs. Depenting on -P parameter the change can be either persistent or till reset. In case of block size change device may need reformat after the setting. In case of SSD overprovisioning format or sanitize may be needed to really free the flash. During implementation appeared that csio_encode_visit() can not handle integers of more then 4 bytes, that makes 8-byte LBA handling awkward. I had to split it into two 4-byte halves now. MFC after: 1 week Relnotes: yes Sponsored by: iXsystems, Inc. Notes: svn path=/head/; revision=350676
* Reenable UNMAP support on ramdisks by default.Alexander Motin2019-07-271-1/+1
| | | | | | | | | For some reason, I guess just mechanical editing, it was disable in r333446. MFC after: 2 weeks Notes: svn path=/head/; revision=350383
* Allow WRITE SAME handle more then 2^^32 blocks.Alexander Motin2019-07-272-12/+47
| | | | | | | | | | | | | If not limited by write_same_max_lba option, split operation into several 2^^31 blocks chunks in a loop. For large disks it may take a while, so setting write_same_max_lba may be useful to avoid timeouts. While there, fix build with CAM_CTL_DEBUG. MFC after: 2 weeks Notes: svn path=/head/; revision=350378
* Add support for Long LBA mode parameter block descriptor.Alexander Motin2019-07-262-30/+62
| | | | | | | | | It is formally required for SBC Base 2016 feature set. MFC after: 2 weeks Notes: svn path=/head/; revision=350363
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-21 14:55:37 +0000