aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix "set but not used" in the siis driver.Scott Long2022-02-261-2/+1
|
* The TWE driver should have been marked with gone_in for FreeBSD 13.x,Scott Long2022-02-261-0/+2
| | | | | | but was missed. Mark it for gone_in 14.0. The hardware hasn't been produced or supported in over 20 years, and even back then it was known to be electrically unreliable and prone to catastrophic failure.
* Fix "set but not used" in twe.Scott Long2022-02-261-2/+8
|
* Fix "set but not used" for real in the ciss driver.Scott Long2022-02-261-8/+3
|
* Expand __diagused to include the KTR kernel diagnostic option.Scott Long2022-02-261-1/+1
|
* Fix "set but not used" in the ips driver. Dead code.Scott Long2022-02-261-3/+1
|
* Fix "set but not used" in aic7xxx/aic79xx. The variables were deadScott Long2022-02-262-15/+0
| | | | code.
* Fix "set but not used" in smartpqi. The PCI_MEM macros don't require aScott Long2022-02-262-2/+2
| | | | | | | physical/absolute address in FreeBSD, but it looks like the calling code might be somewhat portable to other OS's that do require this. Therefore, set the variables to __unused instead of removing the code entirely.
* iscsi: retrieve global login timeout from sysctlbyname() as integerRichard Scheffenegger2022-02-251-5/+7
| | | | | | | | The OID "kern.iscsi.login_timeout" references an integer and not a string. Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D34380
* tcp: Restore correct ECT marking behavior on SACK retransmissionsRichard Scheffenegger2022-02-254-6/+7
| | | | | | | | | | | While coalescing all ECN-related code into new common source files, the flag to deal with SACK retransmissions was skipped. This leads to non-compliant ECT-marking of SACK retransmissions, as well as the premature sending of other TCP ECN flags (CWR). Reviewed By: rrs, #transport Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D34376
* rmlock: Micro-optimize read lockingMark Johnston2022-02-251-2/+2
| | | | | | | | | | | Use get_pcpu() instead of an open-coded pcpu_find(td->td_oncpu). This eliminates some memory accesses and results in a shorter instruction sequence. Note that get_pcpu() didn't exist when rmlocks were added. Reviewed by: jah, mjg MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D34377
* vfs_unregister: fix error handlingMarvin Ma2022-02-251-2/+1
| | | | | | | | | | | Due to misplaced braces, an error from vfs_uninit() in the VFCF_SBDRY case was ignored. Reported by: Anton Rang <rang@acm.org> Reviewed by: Anton Rang <rang@acm.org>, markj MFC after: 1 week Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D34375
* CTL: Rework 05c3e8e87142 using %zu format.Alexander Motin2022-02-251-20/+20
| | | | MFC after: 2 days
* Fix mdoc issues found by mandoc -Tlint.Christian Brueffer2022-02-2517-13/+15
|
* mdoc style: new sentence, new line.Christian Brueffer2022-02-251-3/+5
|
* rtld.1: Fix misplaced textJohn F. Carr2022-02-251-4/+4
| | | | | | PR: 262194 Fixes: f90218886fc8 ("rtld: introduce PRELOAD_FDS") MFC after: 3 days
* gzip: fix error handling in unxzEric van Gyzen2022-02-251-2/+1
| | | | | | | | | The result of fstat() was not checked. Furthermore, there was a redundant check of st.st_size. Fix both. Reported by: Coverity MFC after: 1 week Sponsored by: Dell EMC Isilon
* efivar: handle error when reading --fromfileEric van Gyzen2022-02-251-1/+3
| | | | | | | | | | | | The result of read() was stored in an unsigned variable, so the test for a negative value would never work. While I'm here, print a better error message for an empty file, omitting the misleading errno message. Reported by: Coverity MFC after: 1 week Sponsored by: Dell EMC Isilon
* rtsold: fix memory leak in script executionEric van Gyzen2022-02-251-2/+4
| | | | | | | | | | | | Since commit 04e9edb54428, rtsold has leaked the memory for the argument vector of every script it runs. Reported by: Coverity Reviewed by: markj Fixes: 04e9edb5442826a14616157962361ff81e4a38fe MFC after: 1 week Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D34355
* rtsold: Use correct error in llflags_get()Eric van Gyzen2022-02-251-1/+1
| | | | | | | | | | | Set errno to EINVAL if the name overflows the buffer, as was done before commit ecce515d54bc. Reviewed by: dab, markj Fixes: ecce515d54bcea54fea03f731aad646c87761d22 MFC after: 1 week Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D34354
* nfscl: Fix a use after free in nfscl_cleanupkext()Rick Macklem2022-02-251-6/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ler@, markj@ reported a use after free in nfscl_cleanupkext(). They also provided two possible causes: - In nfscl_cleanup_common(), "own" is the owner string owp->nfsow_owner. If we free that particular owner structure, than in subsequent comparisons "own" will point to freed memory. - nfscl_cleanup_common() can free more than one owner, so the use of LIST_FOREACH_SAFE() in nfscl_cleanupkext() is not sufficient. I also believe there is a 3rd: - If nfscl_freeopenowner() or nfscl_freelockowner() is called without the NFSCLSTATE mutex held, this could race with nfscl_cleanupkext(). This could happen when the exclusive lock is held on the client, such as when delegations are being returned or when recovering from NFSERR_EXPIRED. This patch fixes them as follows: 1 - Copy the owner string to a local variable before the nfscl_cleanup_common() call. 2 - Modify nfscl_cleanup_common() so that it will never free more than the first matching element. Normally there should only be one element in each list with a matching open/lock owner anyhow (but there might be a bug that results in a duplicate). This should guarantee that the FOREACH_SAFE loops in nfscl_cleanupkext() are adequate. 3 - Acquire the NFSCLSTATE mutex in nfscl_freeopenowner() and nfscl_freelockowner(), if it is not already held. This serializes all of these calls with the ones done in nfscl_cleanup_common(). Reported by: ler Reviewed by: markj Tested by: cy MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D34334
* mdoc style: whitespace fixes.Christian Brueffer2022-02-255-7/+1
|
* iscsi: per-session timeouts and rapid teardown of session on reconnectRichard Scheffenegger2022-02-2510-7/+151
| | | | | | | | | | Add per-Session configurable ping (SCSI NOP) and login timeouts. Remove the torn down, old iSCSI session quickly, when performing a reconnect. Reviewed By: trasz Sponsored by: NetApp, Inc. Differential Revision: https://reviews.freebsd.org/D34198
* Fix 32-bit build after 530d274c15e5.Alexander Motin2022-02-241-20/+20
| | | | MFC after: 3 days
* sendfile_test: fix copy-paste bugEric van Gyzen2022-02-241-1/+1
| | | | | | | | | | Require the newly opened file descriptor to be good, instead of re-requiring the one that was required three lines earlier. Thankfully, opening /dev/null is really unlikely to fail. Reported by: Coverity MFC after: 1 week Sponsored by: Dell EMC Isilon
* iwlwifi: update firmwareBjoern A. Zeeb2022-02-2439-20/+99
| | | | | | | | | Update to the latest firmware based on linux-firmware at c53073d4e1485ac9f7cb065db466793c495aead7 and update firmware module Makefiles accordingly. Sponsored by: The FreeBSD Foundation MFC after: 3 days
* iwlwifi: enhance debug informationBjoern A. Zeeb2022-02-241-38/+43
| | | | | | | | | Add a string of the debug type to the output of the debug message so it is easier to search for specific events in a trace with lots of debugging on. While here remove superflous (). Sponsored by: The FreeBSD Foundation MFC after: 3 days
* iwlwifi: update from iwlwifi-nextBjoern A. Zeeb2022-02-2491-1554/+11379
| | | | | | | | | | | | | | | | | | | | Import new code from iwlwifi-next at cb0a1fb7fd86b0062692b5056ca8552906509512 (matching tag: iwlwifi-next-for-kalle-2022-02-18). Also add files not previously imported because we are not yet compiling them to ease updating and having them when needed. This adds MEI (Management Engine) support upstream which we cannot import (currently GPL-only) so we have stub functions for the missing bits. This also reduces the diff to upstream. Changes submitted to avoid problems with const and with void * arithmetics were merged. In the module build Makefile disable CONFIG_IWLWIFI_OPMODE_MODULAR as we are building iwlwifi as a single module. Sponsored by: The FreeBSD Foundation MFC after: 3 days
* CTL: Add length validation for incoming HA messages.Alexander Motin2022-02-241-4/+78
| | | | | | | | | This should fix uninitialized memory reads when working with broken HA peer, like one fixed in 1a8d8a3a909. Instead print error message and kill the HA link. MFC after: 3 days Sponsored by: iXsystems, Inc.
* fusefs: fix a cached attributes bug during directory renameAlan Somers2022-02-242-3/+37
| | | | | | | | | | When renaming a directory into a different parent directory, invalidate the cached attributes of the new parent. Otherwise, stat will show the wrong st_nlink value. MFC after: 1 week Reviewed by: ngie Differential Revision: https://reviews.freebsd.org/D34336
* dtc: more mandoc -T lint fixesWarner Losh2022-02-241-3/+3
| | | | | Obtained from: dtc repo 04c805a8b08e4a1d4ff1f1e62ef475fbfe1a5fbe Sponsored by: Netflix
* LinuxKPI: add MODULE_IMPORT_NS()Bjoern A. Zeeb2022-02-241-0/+1
| | | | | | | | | Add dummy MODULE_IMPORT_NS() used by an updated iwlwifi. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: hselasky Differential Revision: https://reviews.freebsd.org/D34349
* LinuxKPI: change DECLARE_FLEX_ARRAY()Bjoern A. Zeeb2022-02-241-1/+1
| | | | | | | | | | | DECLARE_FLEX_ARRAY can be used inside a structure. On FreeBSD due to -Wgnu-variable-sized-type-not-at-end this yields an error. Use [0] instead of [] to overcome this. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: hselasky Differential Revision: https://reviews.freebsd.org/D34350
* LinuxKPI: USB change successful probe result to BUS_PROBE_DEFAULTBjoern A. Zeeb2022-02-241-1/+1
| | | | | | | | | | | Rather than returning 0 (which is BUS_PROBE_SPECIFIC) return BUS_PROBE_DEFAULT to give other drivers a possible chance too to attach. Reported by: jhb Reviewed by: hselasky, jhb, imp MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D34317
* cons: Use bool for boolean variablesWarner Losh2022-02-241-9/+10
| | | | | MFC After: 3 days Sponsored by: Netflix
* bhyve: plug memory leak in topology_parse()Andy Fiddaman2022-02-241-4/+4
| | | | | Reviewed by: jhb, rew Differential Revision: https://reviews.freebsd.org/D34301
* posixshm: Allow jails to use kern.ipc.posix_shm_listJamie Gritton2022-02-241-1/+1
| | | | | PR: 257554 Reported by: grembo@
* Revert "nfscl: Fix a use after free in nfscl_cleanupkext()"Rick Macklem2022-02-241-59/+11
| | | | | | | This reverts commit dd08b84e35b6fdee0df5fd0e0533cd361dec71cb. cy@ reported a problem caused by this patch. He will be testing an alternate patch, but I'm reverting this one.
* usb(4): Automagically apply all quirks for USB mass storage devices.Hans Petter Selasky2022-02-244-53/+96
| | | | | | | | | | | | | | | | | | | | | | | | Currently there are five quirks the USB stack tries to automagically detect: - UQ_MSC_NO_PREVENT_ALLOW - UQ_MSC_NO_SYNC_CACHE - UQ_MSC_NO_TEST_UNIT_READY - UQ_MSC_NO_GETMAXLUN - UQ_MSC_NO_START_STOP If any of the quirks above are set, no further quirks will be probed. If any of the USB mass storage tests fail, the USB device is re-enumerated as a last resort to clear any error states from the device. Then the USB stack will try to probe and attach the umass<N> device passing the detected quirks. While at it give more details in dmesg about what is going on. Tested by: several Submitted by: Idwer Vollering <vidwer_fbsdbugs@gmail.com> Differential Revision: https://reviews.freebsd.org/D30919 MFC after: 1 week Sponsored by: NVIDIA Networking
* Fix mdoc macro usage and style in section 4 manpages.Christian Brueffer2022-02-2431-38/+17
|
* Handle MODULE_VERBOSE_TWIDDLE in module_verbose_setSimon J. Gerraty2022-02-242-5/+5
| | | | | | | | | If module_verbose is set to a value below MODULE_VERBOSE_TWIDDLE call twiddle_divisor(UINT_MAX). This makes more sense here than when we are loading the kernel. Sponsored by: Juniper Networks, Inc.
* unionfs: rework unionfs_getwritemount()Jason A. Harmening2022-02-241-15/+34
| | | | | | | | | | | | | VOP_GETWRITEMOUNT() is called on the vn_start_write() path without any vnode locks guaranteed to be held. It's therefore unsafe to blindly access per-mount and per-vnode data. Instead, follow the approach taken by nullfs and use the vnode interlock coupled with the hold count to ensure the mount and the vnode won't be recycled while they are being accessed. Reviewed by: kib (earlier version), markj, pho Tested by: pho Differential Revision: https://reviews.freebsd.org/D34282
* test-includes: temporarily add back net/pfvar.hWarner Losh2022-02-241-0/+1
| | | | | | | | net/pfvar.h is installed unconditionally, but depends on files that are installed conditionally. Until that can be sorted out, temporarily add this back to badfiles.inc to cope with MK_PF=no failing. Sponsored by: Netflix
* libctf: Use const ctf_file_t references in string lookup routinesMark Johnston2022-02-232-5/+5
| | | | | MFC after: 1 week Sponsored by: The FreeBSD Foundation
* Update fsdb(8) to reflect new structure of fsck_ffs(8).Kirk McKusick2022-02-234-40/+41
| | | | | | | | | | The cleanup of fsck_ffs(8) in commit c0bfa109b942659f6 broke fsdb(8). This commit adds the one-line update needed in fsdb(8) to make it work with the new fsck_ffs(8) structure. Reported by: Chuck Silvers Tested by: Chuck Silvers MFC after: 3 days
* cam iosched: Update comment for when we schedule writes.Warner Losh2022-02-231-2/+3
| | | | Sponsored by: Netflix
* Temporarily skip sys.geom.class.multipath.failloop.failloop in CILi-Wen Hsu2022-02-231-0/+4
| | | | | | | | | | | | | This test case uses `dtrace -c` but it has some issues at the moment so disable it until dtrace fixed. From markj: This is the CTF type ID limit which has come up quite a few times lately. It'll be fixed with the introduction of CTFv3. PR: 258763 Sponsored by: The FreeBSD Foundation
* bio: make _bio_cflags match bio_cflagsWarner Losh2022-02-231-1/+1
| | | | | | | | | While none of the in-tree geoms that modify the bio_cflags use the top half of the word, were they to do this in the future, we'd hit false positives for DIAGNOSTIC kernels. Make both uint16_t. MFC After: 1 week Sponsored by: Netflix
* tcp: Push bit failure to set in fastpathRandall Stewart2022-02-231-4/+4
| | | | | | | | | | | | | | Recently changes were made to the tcp stack to use a macro/function to set tcp flags. In the process the PUSH bit setting in the fastpath of rack was broken. This fixes that as well as cleans up a warning that is occurring when you don't have INVARIANT on (inp used in KASSERT). We can use the tcp test suite to find this bug the test plan shows the script that fails due to the missing push bit Reviewed by: rscheff, tuexen Sponsored by: Netflix Inc. Differential Revision: https://reviews.freebsd.org/D34332
* cp: Make -P work without -R as per POSIXCameron Katri2022-02-233-9/+31
| | | | | | | | | | According to POSIX, cp should allow the `-P` flag to work whether `-R` is specified or not. Currently, the `-P` option only works along with `-R`. PR: 199466 Reviewed by: kevans Differential Revision: https://reviews.freebsd.org/D30012
generated by cgit v1.2.3 (git 2.25.1) at 2024-10-22 20:46:37 +0000