aboutsummaryrefslogtreecommitdiff
path: root/unit-tests/var-eval-short.mk
diff options
context:
space:
mode:
Diffstat (limited to 'unit-tests/var-eval-short.mk')
-rw-r--r--unit-tests/var-eval-short.mk11
1 files changed, 7 insertions, 4 deletions
diff --git a/unit-tests/var-eval-short.mk b/unit-tests/var-eval-short.mk
index 1b9ccc714736..a099b6871d1e 100644
--- a/unit-tests/var-eval-short.mk
+++ b/unit-tests/var-eval-short.mk
@@ -1,12 +1,13 @@
-# $NetBSD: var-eval-short.mk,v 1.7 2021/09/07 20:41:58 rillig Exp $
+# $NetBSD: var-eval-short.mk,v 1.8 2021/12/27 18:54:19 rillig Exp $
#
# Tests for each variable modifier to ensure that they only do the minimum
-# necessary computations. If the result of the expression is not needed, they
-# should only parse the modifier but not actually evaluate it.
+# necessary computations. If the result of the expression is irrelevant,
+# the modifier should only be parsed. The modifier should not be evaluated,
+# but if it is evaluated for simplicity of the code (such as ':ts'), it must
+# not have any observable side effects.
#
# See also:
# var.c, the comment starting with 'The ApplyModifier functions'
-# ApplyModifier, for the order of the modifiers
# ParseModifierPart, for evaluating nested expressions
# cond-short.mk
@@ -17,6 +18,8 @@ FAIL= ${:!echo unexpected 1>&2!}
# is ignored as well. To do that, it is necessary to step through the code of
# each modifier.
+# TODO: Test the modifiers in the same order as they appear in ApplyModifier.
+
.if 0 && ${FAIL}
.endif