diff options
author | Mateusz Guzik <mjg@FreeBSD.org> | 2020-01-03 22:29:58 +0000 |
---|---|---|
committer | Mateusz Guzik <mjg@FreeBSD.org> | 2020-01-03 22:29:58 +0000 |
commit | b249ce48ea5560afdcff57e72a9880b7d3132434 (patch) | |
tree | af24958629e49de8db56734a7389a612627230d5 /sys/fs | |
parent | 4a20fe31c373d6a6c81bd6205d210bd893dc8068 (diff) |
vfs: drop the mostly unused flags argument from VOP_UNLOCK
Filesystems which want to use it in limited capacity can employ the
VOP_UNLOCK_FLAGS macro.
Reviewed by: kib (previous version)
Differential Revision: https://reviews.freebsd.org/D21427
Notes
Notes:
svn path=/head/; revision=356337
Diffstat (limited to 'sys/fs')
35 files changed, 218 insertions, 219 deletions
diff --git a/sys/fs/autofs/autofs_vnops.c b/sys/fs/autofs/autofs_vnops.c index 03324fb1b987..e9e058933e5b 100644 --- a/sys/fs/autofs/autofs_vnops.c +++ b/sys/fs/autofs/autofs_vnops.c @@ -152,7 +152,7 @@ autofs_trigger_vn(struct vnode *vp, const char *path, int pathlen, */ lock_flags = VOP_ISLOCKED(vp); vref(vp); - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); sx_xlock(&autofs_softc->sc_lock); diff --git a/sys/fs/cd9660/cd9660_vfsops.c b/sys/fs/cd9660/cd9660_vfsops.c index 1ff817c1f00a..79152582ccb7 100644 --- a/sys/fs/cd9660/cd9660_vfsops.c +++ b/sys/fs/cd9660/cd9660_vfsops.c @@ -235,7 +235,7 @@ iso_mountfs(devvp, mp) if (error == 0) g_getattr("MNT::verified", cp, &isverified); g_topology_unlock(); - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); if (error) goto out; if (devvp->v_rdev->si_iosize_max != 0) diff --git a/sys/fs/cd9660/cd9660_vnops.c b/sys/fs/cd9660/cd9660_vnops.c index 70dd4e4a57ec..cfc23fe63280 100644 --- a/sys/fs/cd9660/cd9660_vnops.c +++ b/sys/fs/cd9660/cd9660_vnops.c @@ -261,11 +261,11 @@ cd9660_ioctl(ap) vp = ap->a_vp; vn_lock(vp, LK_SHARED | LK_RETRY); if (VN_IS_DOOMED(vp)) { - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); return (EBADF); } if (vp->v_type == VCHR || vp->v_type == VBLK) { - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); return (EOPNOTSUPP); } @@ -281,7 +281,7 @@ cd9660_ioctl(ap) break; } - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); return (error); } diff --git a/sys/fs/devfs/devfs_devs.c b/sys/fs/devfs/devfs_devs.c index cb79635595e0..6ff0cdafccf6 100644 --- a/sys/fs/devfs/devfs_devs.c +++ b/sys/fs/devfs/devfs_devs.c @@ -407,7 +407,7 @@ devfs_delete(struct devfs_mount *dm, struct devfs_dirent *de, int flags) VI_UNLOCK(vp); vgone(vp); if ((flags & DEVFS_DEL_VNLOCKED) == 0) - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); vdrop(vp); sx_xlock(&dm->dm_lock); } else diff --git a/sys/fs/devfs/devfs_vfsops.c b/sys/fs/devfs/devfs_vfsops.c index fe385a8e45df..56297578ec2a 100644 --- a/sys/fs/devfs/devfs_vfsops.c +++ b/sys/fs/devfs/devfs_vfsops.c @@ -156,7 +156,7 @@ devfs_mount(struct mount *mp) sx_xunlock(&fmp->dm_lock); } - VOP_UNLOCK(rvp, 0); + VOP_UNLOCK(rvp); vfs_cache_root_set(mp, rvp); vfs_mountedfrom(mp, "devfs"); diff --git a/sys/fs/devfs/devfs_vnops.c b/sys/fs/devfs/devfs_vnops.c index 14843bf538ca..862eb9a1f089 100644 --- a/sys/fs/devfs/devfs_vnops.c +++ b/sys/fs/devfs/devfs_vnops.c @@ -241,7 +241,7 @@ devfs_populate_vp(struct vnode *vp) DEVFS_DMP_HOLD(dmp); /* Can't call devfs_populate() with the vnode lock held. */ - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); devfs_populate(dmp); sx_xunlock(&dmp->dm_lock); @@ -635,7 +635,7 @@ devfs_close(struct vop_close_args *ap) vholdnz(vp); VI_UNLOCK(vp); vp_locked = VOP_ISLOCKED(vp); - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); KASSERT(dev->si_refcount > 0, ("devfs_close() on un-referenced struct cdev *(%s)", devtoname(dev))); error = dsw->d_close(dev, ap->a_fflag | dflags, S_IFCHR, td); @@ -965,7 +965,7 @@ devfs_lookupx(struct vop_lookup_args *ap, int *dm_unlock) if (de == NULL) return (ENOENT); dvplocked = VOP_ISLOCKED(dvp); - VOP_UNLOCK(dvp, 0); + VOP_UNLOCK(dvp); error = devfs_allocv(de, mp, cnp->cn_lkflags & LK_TYPE_MASK, vpp); *dm_unlock = 0; @@ -1153,7 +1153,7 @@ devfs_open(struct vop_open_args *ap) } vlocked = VOP_ISLOCKED(vp); - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); fpop = td->td_fpop; td->td_fpop = fp; @@ -1464,9 +1464,9 @@ devfs_remove(struct vop_remove_args *ap) de_covered->de_flags &= ~DE_COVERED; } /* We need to unlock dvp because devfs_delete() may lock it. */ - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); if (dvp != vp) - VOP_UNLOCK(dvp, 0); + VOP_UNLOCK(dvp); devfs_delete(dmp, de, 0); sx_xunlock(&dmp->dm_lock); if (dvp != vp) @@ -1507,7 +1507,7 @@ devfs_revoke(struct vop_revoke_args *ap) vgone(vp); vdrop(vp); - VOP_UNLOCK(vp,0); + VOP_UNLOCK(vp); loop: for (;;) { mtx_lock(&devfs_de_interlock); @@ -1563,12 +1563,12 @@ devfs_rioctl(struct vop_ioctl_args *ap) vp = ap->a_vp; vn_lock(vp, LK_SHARED | LK_RETRY); if (VN_IS_DOOMED(vp)) { - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); return (EBADF); } dmp = VFSTODEVFS(vp->v_mount); sx_xlock(&dmp->dm_lock); - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); DEVFS_DMP_HOLD(dmp); devfs_populate(dmp); if (DEVFS_DMP_DROP(dmp)) { diff --git a/sys/fs/ext2fs/ext2_vfsops.c b/sys/fs/ext2fs/ext2_vfsops.c index 80bc15b22c72..7e03d77863ae 100644 --- a/sys/fs/ext2fs/ext2_vfsops.c +++ b/sys/fs/ext2fs/ext2_vfsops.c @@ -197,10 +197,10 @@ ext2_mount(struct mount *mp) if (error) error = priv_check(td, PRIV_VFS_MOUNT_PERM); if (error) { - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); return (error); } - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); g_topology_lock(); error = g_access(ump->um_cp, 0, 1, 0); g_topology_unlock(); @@ -744,7 +744,7 @@ ext2_reload(struct mount *mp, struct thread *td) vn_lock(devvp, LK_EXCLUSIVE | LK_RETRY); if (vinvalbuf(devvp, 0, 0, 0) != 0) panic("ext2_reload: dirty1"); - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); /* * Step 2: re-read superblock from disk. @@ -802,7 +802,7 @@ loop: error = bread(devvp, fsbtodb(fs, ino_to_fsba(fs, ip->i_number)), (int)fs->e2fs_bsize, NOCRED, &bp); if (error) { - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); vrele(vp); MNT_VNODE_FOREACH_ALL_ABORT(mp, mvp); return (error); @@ -812,7 +812,7 @@ loop: EXT2_INODE_SIZE(fs) * ino_to_fsbo(fs, ip->i_number)), ip); brelse(bp); - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); vrele(vp); if (error) { @@ -849,7 +849,7 @@ ext2_mountfs(struct vnode *devvp, struct mount *mp) g_topology_lock(); error = g_vfs_open(devvp, &cp, "ext2fs", ronly ? 0 : 1); g_topology_unlock(); - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); if (error) return (error); @@ -1155,7 +1155,7 @@ loop: } if ((error = VOP_FSYNC(vp, waitfor, td)) != 0) allerror = error; - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); vrele(vp); } @@ -1166,7 +1166,7 @@ loop: vn_lock(ump->um_devvp, LK_EXCLUSIVE | LK_RETRY); if ((error = VOP_FSYNC(ump->um_devvp, waitfor, td)) != 0) allerror = error; - VOP_UNLOCK(ump->um_devvp, 0); + VOP_UNLOCK(ump->um_devvp); } /* diff --git a/sys/fs/ext2fs/ext2_vnops.c b/sys/fs/ext2fs/ext2_vnops.c index 0eae2e7d1dd0..3cd69c847c9c 100644 --- a/sys/fs/ext2fs/ext2_vnops.c +++ b/sys/fs/ext2fs/ext2_vnops.c @@ -837,13 +837,13 @@ abortit: ip = VTOI(fvp); if (ip->i_nlink >= EXT4_LINK_MAX && !EXT2_HAS_RO_COMPAT_FEATURE(ip->i_e2fs, EXT2F_ROCOMPAT_DIR_NLINK)) { - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); error = EMLINK; goto abortit; } if ((ip->i_flags & (NOUNLINK | IMMUTABLE | APPEND)) || (dp->i_flags & APPEND)) { - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); error = EPERM; goto abortit; } @@ -854,7 +854,7 @@ abortit: if ((fcnp->cn_namelen == 1 && fcnp->cn_nameptr[0] == '.') || dp == ip || (fcnp->cn_flags | tcnp->cn_flags) & ISDOTDOT || (ip->i_flag & IN_RENAME)) { - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); error = EINVAL; goto abortit; } @@ -882,7 +882,7 @@ abortit: ext2_inc_nlink(ip); ip->i_flag |= IN_CHANGE; if ((error = ext2_update(fvp, !DOINGASYNC(fvp))) != 0) { - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); goto bad; } @@ -897,7 +897,7 @@ abortit: * call to checkpath(). */ error = VOP_ACCESS(fvp, VWRITE, tcnp->cn_cred, tcnp->cn_thread); - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); if (oldparent != dp->i_number) newparent = dp->i_number; if (doingdirectory && newparent) { @@ -1494,7 +1494,7 @@ ext2_rmdir(struct vop_rmdir_args *ap) ext2_dec_nlink(dp); dp->i_flag |= IN_CHANGE; cache_purge(dvp); - VOP_UNLOCK(dvp, 0); + VOP_UNLOCK(dvp); /* * Truncate inode. The only stuff left * in the directory is "." and "..". @@ -1504,7 +1504,7 @@ ext2_rmdir(struct vop_rmdir_args *ap) cnp->cn_thread); cache_purge(ITOV(ip)); if (vn_lock(dvp, LK_EXCLUSIVE | LK_NOWAIT) != 0) { - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); vn_lock(dvp, LK_EXCLUSIVE | LK_RETRY); vn_lock(vp, LK_EXCLUSIVE | LK_RETRY); } diff --git a/sys/fs/fdescfs/fdesc_vfsops.c b/sys/fs/fdescfs/fdesc_vfsops.c index 6737bfb94f5e..e6aa9b9a2341 100644 --- a/sys/fs/fdescfs/fdesc_vfsops.c +++ b/sys/fs/fdescfs/fdesc_vfsops.c @@ -110,7 +110,7 @@ fdesc_mount(struct mount *mp) rvp->v_type = VDIR; rvp->v_vflag |= VV_ROOT; fmp->f_root = rvp; - VOP_UNLOCK(rvp, 0); + VOP_UNLOCK(rvp); /* XXX -- don't mark as local to work around fts() problems */ /*mp->mnt_flag |= MNT_LOCAL;*/ vfs_getnewfsid(mp); diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c index 3dc621554fa1..732d679f6deb 100644 --- a/sys/fs/fdescfs/fdesc_vnops.c +++ b/sys/fs/fdescfs/fdesc_vnops.c @@ -341,7 +341,7 @@ fdesc_lookup(struct vop_lookup_args *ap) * will be re-acquired. */ vhold(dvp); - VOP_UNLOCK(dvp, 0); + VOP_UNLOCK(dvp); fdrop(fp, td); /* Re-aquire the lock afterwards. */ @@ -418,7 +418,7 @@ fdesc_pathconf(struct vop_pathconf_args *ap) if (VTOFDESC(vp)->fd_type == Froot) return (vop_stdpathconf(ap)); vref(vp); - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); error = kern_fpathconf(curthread, VTOFDESC(vp)->fd_fd, ap->a_name, ap->a_retval); vn_lock(vp, LK_SHARED | LK_RETRY); @@ -516,7 +516,7 @@ fdesc_setattr(struct vop_setattr_args *ap) if ((error = vn_start_write(vp, &mp, V_WAIT | PCATCH)) == 0) { vn_lock(vp, LK_EXCLUSIVE | LK_RETRY); error = VOP_SETATTR(vp, ap->a_vap, ap->a_cred); - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); vn_finished_write(mp); } fdrop(fp, td); @@ -630,7 +630,7 @@ fdesc_readlink(struct vop_readlink_args *va) panic("fdesc_readlink: not fdescfs link"); fd_fd = ((struct fdescnode *)vn->v_data)->fd_fd; lockflags = VOP_ISLOCKED(vn); - VOP_UNLOCK(vn, 0); + VOP_UNLOCK(vn); td = curthread; error = fget_cap(td, fd_fd, &cap_no_rights, &fp, NULL); diff --git a/sys/fs/fifofs/fifo_vnops.c b/sys/fs/fifofs/fifo_vnops.c index 36f0f6f27550..65119fc1d368 100644 --- a/sys/fs/fifofs/fifo_vnops.c +++ b/sys/fs/fifofs/fifo_vnops.c @@ -195,7 +195,7 @@ fifo_open(ap) if ((ap->a_mode & O_NONBLOCK) == 0) { if ((ap->a_mode & FREAD) && fip->fi_writers == 0) { gen = fip->fi_wgen; - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); stops_deferred = sigdeferstop(SIGDEFERSTOP_OFF); error = msleep(&fip->fi_readers, PIPE_MTX(fpipe), PDROP | PCATCH | PSOCK, "fifoor", 0); @@ -222,7 +222,7 @@ fifo_open(ap) } if ((ap->a_mode & FWRITE) && fip->fi_readers == 0) { gen = fip->fi_rgen; - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); stops_deferred = sigdeferstop(SIGDEFERSTOP_OFF); error = msleep(&fip->fi_writers, PIPE_MTX(fpipe), PDROP | PCATCH | PSOCK, "fifoow", 0); diff --git a/sys/fs/fuse/fuse_vfsops.c b/sys/fs/fuse/fuse_vfsops.c index fff2cca67e77..a4c21c5c5a45 100644 --- a/sys/fs/fuse/fuse_vfsops.c +++ b/sys/fs/fuse/fuse_vfsops.c @@ -626,7 +626,7 @@ fuse_vfsop_root(struct mount *mp, int lkflags, struct vnode **vpp) SDT_PROBE2(fusefs, , vfsops, trace, 1, "root vnode race"); FUSE_UNLOCK(); - VOP_UNLOCK(*vpp, 0); + VOP_UNLOCK(*vpp); vrele(*vpp); vrecycle(*vpp); *vpp = data->vroot; diff --git a/sys/fs/msdosfs/msdosfs_vfsops.c b/sys/fs/msdosfs/msdosfs_vfsops.c index ae050e192865..c6f6d1b9d87f 100644 --- a/sys/fs/msdosfs/msdosfs_vfsops.c +++ b/sys/fs/msdosfs/msdosfs_vfsops.c @@ -301,10 +301,10 @@ msdosfs_mount(struct mount *mp) if (error) error = priv_check(td, PRIV_VFS_MOUNT_PERM); if (error) { - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); return (error); } - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); g_topology_lock(); error = g_access(pmp->pm_cp, 0, 1, 0); g_topology_unlock(); @@ -415,7 +415,7 @@ mountmsdosfs(struct vnode *devvp, struct mount *mp) dev = devvp->v_rdev; if (atomic_cmpset_acq_ptr((uintptr_t *)&dev->si_mountpt, 0, (uintptr_t)mp) == 0) { - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); return (EBUSY); } g_topology_lock(); @@ -423,12 +423,12 @@ mountmsdosfs(struct vnode *devvp, struct mount *mp) g_topology_unlock(); if (error != 0) { atomic_store_rel_ptr((uintptr_t *)&dev->si_mountpt, 0); - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); return (error); } dev_ref(dev); bo = &devvp->v_bufobj; - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); if (dev->si_iosize_max != 0) mp->mnt_iosize_max = dev->si_iosize_max; if (mp->mnt_iosize_max > MAXPHYS) @@ -934,7 +934,7 @@ loop: error = VOP_FSYNC(vp, waitfor, td); if (error) allerror = error; - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); vrele(vp); } @@ -946,7 +946,7 @@ loop: error = VOP_FSYNC(pmp->pm_devvp, waitfor, td); if (error) allerror = error; - VOP_UNLOCK(pmp->pm_devvp, 0); + VOP_UNLOCK(pmp->pm_devvp); } error = msdosfs_fsiflush(pmp, waitfor); diff --git a/sys/fs/msdosfs/msdosfs_vnops.c b/sys/fs/msdosfs/msdosfs_vnops.c index 76baeb8f17c4..f625e9368442 100644 --- a/sys/fs/msdosfs/msdosfs_vnops.c +++ b/sys/fs/msdosfs/msdosfs_vnops.c @@ -852,7 +852,7 @@ msdosfs_fsync(struct vop_fsync_args *ap) devvp = VTODE(ap->a_vp)->de_pmp->pm_devvp; vn_lock(devvp, LK_EXCLUSIVE | LK_RETRY); allerror = VOP_FSYNC(devvp, MNT_WAIT, ap->a_td); - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); } else allerror = 0; @@ -1009,7 +1009,7 @@ abortit: (fcnp->cn_flags & ISDOTDOT) || (tcnp->cn_flags & ISDOTDOT) || (ip->de_flag & DE_RENAME)) { - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); error = EINVAL; goto abortit; } @@ -1040,7 +1040,7 @@ abortit: * call to doscheckpath(). */ error = VOP_ACCESS(fvp, VWRITE, tcnp->cn_cred, tcnp->cn_thread); - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); if (VTODE(fdvp)->de_StartCluster != VTODE(tdvp)->de_StartCluster) newparent = 1; if (doingdirectory && newparent) { @@ -1109,7 +1109,7 @@ abortit: if ((fcnp->cn_flags & SAVESTART) == 0) panic("msdosfs_rename: lost from startdir"); if (!newparent) - VOP_UNLOCK(tdvp, 0); + VOP_UNLOCK(tdvp); if (relookup(fdvp, &fvp, fcnp) == 0) vrele(fdvp); if (fvp == NULL) { @@ -1119,7 +1119,7 @@ abortit: if (doingdirectory) panic("rename: lost dir entry"); if (newparent) - VOP_UNLOCK(tdvp, 0); + VOP_UNLOCK(tdvp); vrele(tdvp); vrele(ap->a_fvp); return 0; @@ -1139,9 +1139,9 @@ abortit: if (xp != ip) { if (doingdirectory) panic("rename: lost dir entry"); - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); if (newparent) - VOP_UNLOCK(fdvp, 0); + VOP_UNLOCK(fdvp); vrele(ap->a_fvp); xp = NULL; } else { @@ -1164,8 +1164,8 @@ abortit: if (error) { memcpy(ip->de_Name, oldname, 11); if (newparent) - VOP_UNLOCK(fdvp, 0); - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fdvp); + VOP_UNLOCK(fvp); goto bad; } /* @@ -1185,8 +1185,8 @@ abortit: if (error) { /* XXX should downgrade to ro here, fs is corrupt */ if (newparent) - VOP_UNLOCK(fdvp, 0); - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fdvp); + VOP_UNLOCK(fvp); goto bad; } if (!doingdirectory) { @@ -1195,8 +1195,8 @@ abortit: if (error) { /* XXX should downgrade to ro here, fs is corrupt */ if (newparent) - VOP_UNLOCK(fdvp, 0); - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fdvp); + VOP_UNLOCK(fvp); goto bad; } if (ip->de_dirclust == MSDOSFSROOT) @@ -1206,7 +1206,7 @@ abortit: } reinsert(ip); if (newparent) - VOP_UNLOCK(fdvp, 0); + VOP_UNLOCK(fdvp); } /* @@ -1224,7 +1224,7 @@ abortit: NOCRED, &bp); if (error) { /* XXX should downgrade to ro here, fs is corrupt */ - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); goto bad; } dotdotp = (struct direntry *)bp->b_data + 1; @@ -1238,7 +1238,7 @@ abortit: bdwrite(bp); else if ((error = bwrite(bp)) != 0) { /* XXX should downgrade to ro here, fs is corrupt */ - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); goto bad; } } @@ -1251,7 +1251,7 @@ abortit: * namecache entries that were installed for this direntry. */ cache_purge(fvp); - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); bad: if (xp) vput(tvp); diff --git a/sys/fs/nfs/nfs_commonsubs.c b/sys/fs/nfs/nfs_commonsubs.c index 9d6511dfcbfd..0629091425b2 100644 --- a/sys/fs/nfs/nfs_commonsubs.c +++ b/sys/fs/nfs/nfs_commonsubs.c @@ -2550,7 +2550,7 @@ nfsv4_fillattr(struct nfsrv_descript *nd, struct mount *mp, vnode_t vp, if (error == 0) error = VOP_GETACL(vp, ACL_TYPE_NFS4, naclp, cred, p); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } else error = NFSERR_PERM; if (error != 0) { @@ -2570,7 +2570,7 @@ nfsv4_fillattr(struct nfsrv_descript *nd, struct mount *mp, vnode_t vp, if (NFSVOPLOCK(vp, LK_SHARED) == 0) { error = VOP_GETEXTATTR(vp, EXTATTR_NAMESPACE_USER, "xxx", NULL, &atsiz, cred, p); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); if (error != EOPNOTSUPP) xattrsupp = true; } diff --git a/sys/fs/nfs/nfsport.h b/sys/fs/nfs/nfsport.h index 5cd4ca023911..bfe9db97cee2 100644 --- a/sys/fs/nfs/nfsport.h +++ b/sys/fs/nfs/nfsport.h @@ -1116,7 +1116,7 @@ void nfsd_mntinit(void); * later, for debugging or stats, etc. */ #define NFSVOPLOCK(v, f) vn_lock((v), (f)) -#define NFSVOPUNLOCK(v, f) VOP_UNLOCK((v), (f)) +#define NFSVOPUNLOCK(v) VOP_UNLOCK((v)) #define NFSVOPISLOCKED(v) VOP_ISLOCKED((v)) /* diff --git a/sys/fs/nfsclient/nfs_clport.c b/sys/fs/nfsclient/nfs_clport.c index 9e97540612af..77ecdd255ea2 100644 --- a/sys/fs/nfsclient/nfs_clport.c +++ b/sys/fs/nfsclient/nfs_clport.c @@ -336,7 +336,7 @@ nfscl_ngetreopen(struct mount *mntp, u_int8_t *fhp, int fhsize, error = vfs_hash_get(mntp, hash, (LK_EXCLUSIVE | LK_NOWAIT), td, &nvp, newnfs_vncmpf, nfhp); if (error == 0 && nvp != NULL) { - NFSVOPUNLOCK(nvp, 0); + NFSVOPUNLOCK(nvp); } else if (error == EBUSY) { /* * It is safe so long as a vflush() with diff --git a/sys/fs/nfsclient/nfs_clvfsops.c b/sys/fs/nfsclient/nfs_clvfsops.c index 4b06b7592b6c..b4c997ea88c3 100644 --- a/sys/fs/nfsclient/nfs_clvfsops.c +++ b/sys/fs/nfsclient/nfs_clvfsops.c @@ -1624,7 +1624,7 @@ mountnfs(struct nfs_args *argp, struct mount *mp, struct sockaddr *nam, /* * Lose the lock but keep the ref. */ - NFSVOPUNLOCK(*vpp, 0); + NFSVOPUNLOCK(*vpp); vfs_cache_root_set(mp, *vpp); return (0); } @@ -1826,7 +1826,7 @@ loop: error = VOP_FSYNC(vp, waitfor, td); if (error) allerror = error; - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); vrele(vp); } return (allerror); diff --git a/sys/fs/nfsclient/nfs_clvnops.c b/sys/fs/nfsclient/nfs_clvnops.c index ad5a07ac910b..63b1ab76975b 100644 --- a/sys/fs/nfsclient/nfs_clvnops.c +++ b/sys/fs/nfsclient/nfs_clvnops.c @@ -353,7 +353,7 @@ nfs_lock(struct vop_lock1_args *ap) * sleepable call to vnode_pager_setsize(). */ NFSUNLOCKNODE(np); - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); return (EBUSY); } if ((ap->a_flags & LK_NOWAIT) != 0 || @@ -363,7 +363,7 @@ nfs_lock(struct vop_lock1_args *ap) } if (lktype == LK_SHARED) { NFSUNLOCKNODE(np); - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); ap->a_flags &= ~(LK_TYPE_MASK | LK_INTERLOCK); ap->a_flags |= LK_EXCLUSIVE; error = VOP_LOCK1_APV(&default_vnodeops, ap); @@ -1358,7 +1358,7 @@ nfs_lookup(struct vop_lookup_args *ap) error = vfs_busy(mp, MBF_NOWAIT); if (error != 0) { vfs_ref(mp); - NFSVOPUNLOCK(dvp, 0); + NFSVOPUNLOCK(dvp); error = vfs_busy(mp, 0); NFSVOPLOCK(dvp, ltype | LK_RETRY); vfs_rel(mp); @@ -1369,7 +1369,7 @@ nfs_lookup(struct vop_lookup_args *ap) if (error != 0) return (error); } - NFSVOPUNLOCK(dvp, 0); + NFSVOPUNLOCK(dvp); error = nfscl_nget(mp, dvp, nfhp, cnp, td, &np, NULL, cnp->cn_lkflags); if (error == 0) @@ -1935,7 +1935,7 @@ nfs_rename(struct vop_rename_args *ap) * this condition can result in potential (silent) data loss. */ error = VOP_FSYNC(fvp, MNT_WAIT, fcnp->cn_thread); - NFSVOPUNLOCK(fvp, 0); + NFSVOPUNLOCK(fvp); if (!error && tvp) error = VOP_FSYNC(tvp, MNT_WAIT, tcnp->cn_thread); if (error) @@ -3185,7 +3185,7 @@ nfs_advlock(struct vop_advlock_args *ap) ap->a_fl, 0, cred, td, ap->a_id, ap->a_flags); if (ret == NFSERR_DENIED && (ap->a_flags & F_WAIT) && ap->a_op == F_SETLK) { - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); error = nfs_catnap(PZERO | PCATCH, ret, "ncladvl"); if (error) @@ -3239,13 +3239,13 @@ nfs_advlock(struct vop_advlock_args *ap) } else if (!NFS_ISV4(vp)) { if ((VFSTONFS(vp->v_mount)->nm_flag & NFSMNT_NOLOCKD) != 0) { size = VTONFS(vp)->n_size; - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); error = lf_advlock(ap, &(vp->v_lockf), size); } else { if (nfs_advlock_p != NULL) error = nfs_advlock_p(ap); else { - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); error = ENOLCK; } } @@ -3256,14 +3256,14 @@ nfs_advlock(struct vop_advlock_args *ap) NFSLOCKNODE(np); np->n_flag |= NHASBEENLOCKED; NFSUNLOCKNODE(np); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } } return (error); } else error = EOPNOTSUPP; out: - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); return (error); } @@ -3284,10 +3284,10 @@ nfs_advlockasync(struct vop_advlockasync_args *ap) return (error); if ((VFSTONFS(vp->v_mount)->nm_flag & NFSMNT_NOLOCKD) != 0) { size = VTONFS(vp)->n_size; - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); error = lf_advlockasync(ap, &(vp->v_lockf), size); } else { - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); error = EOPNOTSUPP; } return (error); @@ -3667,13 +3667,13 @@ nfs_copy_file_range(struct vop_copy_file_range_args *ap) error = vn_lock(invp, LK_SHARED | LK_NOWAIT); if (error == 0) break; - VOP_UNLOCK(outvp, 0); + VOP_UNLOCK(outvp); if (mp != NULL) vn_finished_write(mp); mp = NULL; error = vn_lock(invp, LK_SHARED); if (error == 0) - VOP_UNLOCK(invp, 0); + VOP_UNLOCK(invp); } } if (mp != NULL) @@ -3802,8 +3802,8 @@ nfs_copy_file_range(struct vop_copy_file_range_args *ap) error = 0; } } - VOP_UNLOCK(invp, 0); - VOP_UNLOCK(outvp, 0); + VOP_UNLOCK(invp); + VOP_UNLOCK(outvp); if (mp != NULL) vn_finished_write(mp); if (error == NFSERR_NOTSUPP || error == NFSERR_OFFLOADNOREQS || @@ -3893,7 +3893,7 @@ nfs_ioctl(struct vop_ioctl_args *ap) if (error == 0 && ret != 0) error = ret; } - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); if (error != 0) error = ENXIO; diff --git a/sys/fs/nfsserver/nfs_nfsdport.c b/sys/fs/nfsserver/nfs_nfsdport.c index 6a883f847f62..b35c7ab6a5b3 100644 --- a/sys/fs/nfsserver/nfs_nfsdport.c +++ b/sys/fs/nfsserver/nfs_nfsdport.c @@ -314,7 +314,7 @@ nfsvno_getattr(struct vnode *vp, struct nfsvattr *nvap, error = VOP_GETATTR(vp, &nvap->na_vattr, nd->nd_cred); if (lockedit != 0) - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); /* * If we got the Change, Size and Modify Time from the DS, @@ -402,7 +402,7 @@ nfsvno_accchk(struct vnode *vp, accmode_t accmode, struct ucred *cred, } if (error != 0) { if (vpislocked == 0) - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); goto out; } @@ -442,7 +442,7 @@ nfsvno_accchk(struct vnode *vp, accmode_t accmode, struct ucred *cred, } } if (vpislocked == 0) - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); out: NFSEXITCODE(error); @@ -531,7 +531,7 @@ nfsvno_namei(struct nfsrv_descript *nd, struct nameidata *ndp, goto out1; } if (islocked) - NFSVOPUNLOCK(dp, 0); + NFSVOPUNLOCK(dp); VREF(dp); *retdirp = dp; if (NFSVNO_EXRDONLY(exp)) @@ -599,7 +599,7 @@ nfsvno_namei(struct nfsrv_descript *nd, struct nameidata *ndp, if ((cnp->cn_flags & (SAVENAME | SAVESTART)) == 0) nfsvno_relpathbuf(ndp); if (ndp->ni_vp && !lockleaf) - NFSVOPUNLOCK(ndp->ni_vp, 0); + NFSVOPUNLOCK(ndp->ni_vp); break; } @@ -607,7 +607,7 @@ nfsvno_namei(struct nfsrv_descript *nd, struct nameidata *ndp, * Validate symlink */ if ((cnp->cn_flags & LOCKPARENT) && ndp->ni_pathlen == 1) - NFSVOPUNLOCK(ndp->ni_dvp, 0); + NFSVOPUNLOCK(ndp->ni_dvp); if (!(nd->nd_flag & ND_PUBLOOKUP)) { error = EINVAL; goto badlink2; @@ -1429,7 +1429,7 @@ nfsvno_rename(struct nameidata *fromndp, struct nameidata *tondp, if (NFSVOPLOCK(fvp, LK_EXCLUSIVE) == 0) { error = nfsrv_checkremove(fvp, 0, NULL, (nfsquad_t)((u_quad_t)0), p); - NFSVOPUNLOCK(fvp, 0); + NFSVOPUNLOCK(fvp); } else error = EPERM; if (tvp && !error) @@ -1515,7 +1515,7 @@ nfsvno_link(struct nameidata *ndp, struct vnode *vp, struct ucred *cred, vrele(ndp->ni_dvp); else vput(ndp->ni_dvp); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } else { if (ndp->ni_dvp == ndp->ni_vp) vrele(ndp->ni_dvp); @@ -2314,7 +2314,7 @@ again: */ mp = vp->v_mount; vfs_ref(mp); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); nd->nd_repstat = vfs_busy(mp, 0); vfs_rel(mp); if (nd->nd_repstat != 0) { @@ -2448,8 +2448,7 @@ again: r = VOP_LOOKUP(vp, &nvp, &cn); if (vp != nvp) - NFSVOPUNLOCK(vp, - 0); + NFSVOPUNLOCK(vp); } } @@ -2563,7 +2562,7 @@ again: if (nvp != NULL) { supports_nfsv4acls = nfs_supportsnfsv4acls(nvp); - NFSVOPUNLOCK(nvp, 0); + NFSVOPUNLOCK(nvp); } else supports_nfsv4acls = 0; if (refp != NULL) { @@ -3622,7 +3621,7 @@ nfssvc_nfsd(struct thread *td, struct nfssvc_args *uap) if (ret == 0) { nfsrv_dsremove(curdvp, fname, td->td_ucred, td); - NFSVOPUNLOCK(curdvp, 0); + NFSVOPUNLOCK(curdvp); } } NFSD_DEBUG(4, "nfsrv_copymr=%d\n", error); @@ -3898,7 +3897,7 @@ nfsrv_dscreate(struct vnode *dvp, struct vattr *vap, struct vattr *nvap, error = NFSVOPLOCK(dvp, LK_EXCLUSIVE); if (error == 0) { error = VOP_CREATE(dvp, &nvp, &named.ni_cnd, vap); - NFSVOPUNLOCK(dvp, 0); + NFSVOPUNLOCK(dvp); if (error == 0) { /* Set the ownership of the file. */ error = VOP_SETATTR(nvp, nvap, tcred); @@ -4286,7 +4285,7 @@ nfsrv_dsremove(struct vnode *dvp, char *fname, struct ucred *tcred, error = VOP_REMOVE(dvp, nvp, &named.ni_cnd); vput(nvp); } - NFSVOPUNLOCK(dvp, 0); + NFSVOPUNLOCK(dvp); nfsvno_relpathbuf(&named); if (error != 0) printf("pNFS: nfsrv_pnfsremove failed=%d\n", error); @@ -4641,7 +4640,7 @@ tryagain: NFSUNLOCKMNT(failnmp); } for (i = 0; i < mirrorcnt; i++) - NFSVOPUNLOCK(dvp[i], 0); + NFSVOPUNLOCK(dvp[i]); NFSD_DEBUG(4, "nfsrv_proxyds: aft RPC=%d trya=%d\n", error, trycnt); /* Try the Read/Getattr again if a mirror was deleted. */ @@ -4826,7 +4825,7 @@ nfsrv_dsgetsockmnt(struct vnode *vp, int lktype, char *buf, int *buflenp, vput(nvp); } if (error != 0 || lktype == 0) - NFSVOPUNLOCK(dvp, 0); + NFSVOPUNLOCK(dvp); } } if (error == 0) { @@ -4867,7 +4866,7 @@ nfsrv_dsgetsockmnt(struct vnode *vp, int lktype, char *buf, int *buflenp, * have locked dvp's that need to be unlocked. */ for (i = 0; i < gotone; i++) { - NFSVOPUNLOCK(*dvpp, 0); + NFSVOPUNLOCK(*dvpp); *dvpp++ = NULL; } } @@ -6085,7 +6084,7 @@ nfsvno_seek(struct nfsrv_descript *nd, struct vnode *vp, u_long cmd, * VOP_IOCTL() will return ENXIO. However, the correct reply for * NFSv4.2 is *eofp == true and error == 0 for this case. */ - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); error = VOP_IOCTL(vp, cmd, offp, 0, cred, p); *eofp = false; if (error == ENXIO || (error == 0 && cmd == FIOSEEKHOLE)) { diff --git a/sys/fs/nfsserver/nfs_nfsdserv.c b/sys/fs/nfsserver/nfs_nfsdserv.c index 01e691e3cc2f..269ad8ce438e 100644 --- a/sys/fs/nfsserver/nfs_nfsdserv.c +++ b/sys/fs/nfsserver/nfs_nfsdserv.c @@ -298,7 +298,7 @@ nfsrvd_getattr(struct nfsrv_descript *nd, int isdgram, } else at_root = 0; vfs_ref(mp); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); if (at_root != 0) { if ((nd->nd_repstat = NFSVOPLOCK(tvp, LK_SHARED)) == 0) { @@ -1409,7 +1409,7 @@ nfsrvd_mknod(struct nfsrv_descript *nd, __unused int isdgram, nd->nd_repstat = nfsvno_getattr(vp, &nva, nd, p, 1, NULL); if (vpp != NULL && nd->nd_repstat == 0) { - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); *vpp = vp; } else vput(vp); @@ -1584,14 +1584,14 @@ nfsrvd_rename(struct nfsrv_descript *nd, int isdgram, tdp = todp; tnes = *toexp; if (dp != tdp) { - NFSVOPUNLOCK(dp, 0); + NFSVOPUNLOCK(dp); /* Might lock tdp. */ tdirfor_ret = nfsvno_getattr(tdp, &tdirfor, nd, p, 0, NULL); } else { tdirfor_ret = nfsvno_getattr(tdp, &tdirfor, nd, p, 1, NULL); - NFSVOPUNLOCK(dp, 0); + NFSVOPUNLOCK(dp); } } else { tfh.nfsrvfh_len = 0; @@ -1613,16 +1613,16 @@ nfsrvd_rename(struct nfsrv_descript *nd, int isdgram, tnes = *exp; tdirfor_ret = nfsvno_getattr(tdp, &tdirfor, nd, p, 1, NULL); - NFSVOPUNLOCK(dp, 0); + NFSVOPUNLOCK(dp); } else { - NFSVOPUNLOCK(dp, 0); + NFSVOPUNLOCK(dp); nd->nd_cred->cr_uid = nd->nd_saveduid; nfsd_fhtovp(nd, &tfh, LK_EXCLUSIVE, &tdp, &tnes, NULL, 0); /* Locks tdp. */ if (tdp) { tdirfor_ret = nfsvno_getattr(tdp, &tdirfor, nd, p, 1, NULL); - NFSVOPUNLOCK(tdp, 0); + NFSVOPUNLOCK(tdp); } } } @@ -1729,7 +1729,7 @@ nfsrvd_link(struct nfsrv_descript *nd, int isdgram, nfsrv_wcc(nd, dirfor_ret, &dirfor, diraft_ret, &diraft); goto out; } - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); if (vnode_vtype(vp) == VDIR) { if (nd->nd_flag & ND_NFSV4) nd->nd_repstat = NFSERR_ISDIR; @@ -1751,7 +1751,7 @@ nfsrvd_link(struct nfsrv_descript *nd, int isdgram, } nfsd_fhtovp(nd, &dfh, LK_EXCLUSIVE, &dp, &tnes, NULL, 0); if (dp) - NFSVOPUNLOCK(dp, 0); + NFSVOPUNLOCK(dp); } } NFSNAMEICNDSET(&named.ni_cnd, nd->nd_cred, CREATE, @@ -1908,7 +1908,7 @@ nfsrvd_symlinksub(struct nfsrv_descript *nd, struct nameidata *ndp, nvap, nd, p, 1, NULL); } if (vpp != NULL && nd->nd_repstat == 0) { - NFSVOPUNLOCK(ndp->ni_vp, 0); + NFSVOPUNLOCK(ndp->ni_vp); *vpp = ndp->ni_vp; } else vput(ndp->ni_vp); @@ -2041,7 +2041,7 @@ nfsrvd_mkdirsub(struct nfsrv_descript *nd, struct nameidata *ndp, nd->nd_repstat = nfsvno_getattr(vp, nvap, nd, p, 1, NULL); if (vpp && !nd->nd_repstat) { - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); *vpp = vp; } else { vput(vp); @@ -3081,7 +3081,7 @@ nfsrvd_open(struct nfsrv_descript *nd, __unused int isdgram, * (ie: Leave the NFSVOPUNLOCK() about here.) */ if (vp) - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); if (stp) free(stp, M_NFSDSTATE); if (!nd->nd_repstat && dirp) @@ -4947,7 +4947,7 @@ nfsrvd_ioadvise(struct nfsrv_descript *nd, __unused int isdgram, !NFSISSET_ATTRBIT(&hints, NFSV4IOHINT_DONTNEED)) || (NFSISSET_ATTRBIT(&hints, NFSV4IOHINT_DONTNEED) && !NFSISSET_ATTRBIT(&hints, NFSV4IOHINT_WILLNEED))) { - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); if (NFSISSET_ATTRBIT(&hints, NFSV4IOHINT_WILLNEED)) { ret = VOP_ADVISE(vp, offset, len, POSIX_FADV_WILLNEED); NFSZERO_ATTRBIT(&hints); @@ -5294,7 +5294,7 @@ nfsrvd_copy_file_range(struct nfsrv_descript *nd, __unused int isdgram, if (nd->nd_repstat == 0) nd->nd_repstat = nfsrv_lockctrl(vp, &instp, &inlop, NULL, clientid, &stateid, exp, nd, curthread); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); if (nd->nd_repstat != 0) goto out; @@ -5316,7 +5316,7 @@ nfsrvd_copy_file_range(struct nfsrv_descript *nd, __unused int isdgram, if (nd->nd_repstat == 0) nd->nd_repstat = nfsrv_lockctrl(tovp, &outstp, &outlop, NULL, clientid, &stateid, toexp, nd, curthread); - NFSVOPUNLOCK(tovp, 0); + NFSVOPUNLOCK(tovp); /* Range lock the byte ranges for both invp and outvp. */ if (nd->nd_repstat == 0) { @@ -5372,7 +5372,7 @@ nfsrvd_copy_file_range(struct nfsrv_descript *nd, __unused int isdgram, nd->nd_repstat = NFSERR_INVAL; } } - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); if (ret != 0 && nd->nd_repstat == 0) nd->nd_repstat = ret; } else if (nd->nd_repstat == 0) diff --git a/sys/fs/nfsserver/nfs_nfsdsocket.c b/sys/fs/nfsserver/nfs_nfsdsocket.c index 8215b96ba7e1..2dff6006f7a8 100644 --- a/sys/fs/nfsserver/nfs_nfsdsocket.c +++ b/sys/fs/nfsserver/nfs_nfsdsocket.c @@ -624,7 +624,7 @@ nfsrvd_dorpc(struct nfsrv_descript *nd, int isdgram, u_char *tag, int taglen, if (nfs_retfh[nd->nd_procnum] == 1) { if (vp) - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); error = (*(nfsrv3_procs1[nd->nd_procnum]))(nd, isdgram, vp, NULL, (fhandle_t *)fh.nfsrvfh_data, &nes); } else if (nfs_retfh[nd->nd_procnum] == 2) { @@ -934,7 +934,7 @@ nfsrvd_compound(struct nfsrv_descript *nd, int isdgram, u_char *tag, vrele(vp); vp = nvp; cur_fsid = vp->v_mount->mnt_stat.f_fsid; - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); vpnes = nes; } break; @@ -949,7 +949,7 @@ nfsrvd_compound(struct nfsrv_descript *nd, int isdgram, u_char *tag, vrele(vp); vp = nvp; cur_fsid = vp->v_mount->mnt_stat.f_fsid; - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); vpnes = nes; } break; @@ -962,7 +962,7 @@ nfsrvd_compound(struct nfsrv_descript *nd, int isdgram, u_char *tag, vrele(vp); vp = nvp; cur_fsid = vp->v_mount->mnt_stat.f_fsid; - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); vpnes = nes; } } else @@ -1079,7 +1079,7 @@ nfsrvd_compound(struct nfsrv_descript *nd, int isdgram, u_char *tag, } } /* Lookup ops return a locked vnode */ - NFSVOPUNLOCK(nvp, 0); + NFSVOPUNLOCK(nvp); } if (!nd->nd_repstat) { vrele(vp); diff --git a/sys/fs/nfsserver/nfs_nfsdstate.c b/sys/fs/nfsserver/nfs_nfsdstate.c index 41f329c16d2b..2a981b630e60 100644 --- a/sys/fs/nfsserver/nfs_nfsdstate.c +++ b/sys/fs/nfsserver/nfs_nfsdstate.c @@ -1554,7 +1554,7 @@ nfsrv_freeallnfslocks(struct nfsstate *stp, vnode_t vp, int cansleep, tvp = NULL; else if (vp == NULL && cansleep != 0) { tvp = nfsvno_getvp(&lfp->lf_fh); - NFSVOPUNLOCK(tvp, 0); + NFSVOPUNLOCK(tvp); } else tvp = vp; gottvp = 1; @@ -1780,7 +1780,7 @@ tryagain: if (vnode_unlocked == 0) { ASSERT_VOP_ELOCKED(vp, "nfsrv_lockctrl1"); vnode_unlocked = 1; - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } reterr = nfsrv_locallock(vp, lfp, (new_lop->lo_flags & (NFSLCK_READ | NFSLCK_WRITE)), @@ -1954,7 +1954,7 @@ tryagain: if (vnode_unlocked == 0) { ASSERT_VOP_ELOCKED(vp, "nfsrv_lockctrl2"); vnode_unlocked = 1; - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } nfsrv_locallock_rollback(vp, lfp, p); NFSLOCKSTATE(); @@ -2038,7 +2038,7 @@ tryagain: ASSERT_VOP_ELOCKED(vp, "nfsrv_lockctrl3"); vnode_unlocked = 1; - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } nfsrv_locallock_rollback(vp, lfp, p); NFSLOCKSTATE(); @@ -2150,7 +2150,7 @@ tryagain: NFSUNLOCKSTATE(); if (vnode_unlocked == 0) { ASSERT_VOP_ELOCKED(vp, "nfsrv_lockctrl4"); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } nfsrv_locallock_rollback(vp, lfp, p); NFSLOCKSTATE(); @@ -2205,7 +2205,7 @@ tryagain: if (vnode_unlocked == 0) { ASSERT_VOP_ELOCKED(vp, "nfsrv_lockctrl5"); vnode_unlocked = 1; - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } /* Update the local locks. */ nfsrv_localunlock(vp, lfp, first, end, p); @@ -2247,7 +2247,7 @@ tryagain: if (filestruct_locked != 0) { if (vnode_unlocked == 0) { ASSERT_VOP_ELOCKED(vp, "nfsrv_lockctrl6"); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } /* Roll back local locks. */ nfsrv_locallock_rollback(vp, lfp, p); @@ -2296,7 +2296,7 @@ tryagain: if (vnode_unlocked == 0) { ASSERT_VOP_ELOCKED(vp, "nfsrv_lockctrl7"); vnode_unlocked = 1; - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } nfsrv_locallock_rollback(vp, lfp, p); NFSLOCKSTATE(); @@ -3525,7 +3525,7 @@ nfsrv_openupdate(vnode_t vp, struct nfsstate *new_stp, nfsquad_t clientid, nfsrv_locklf(lfp); NFSUNLOCKSTATE(); ASSERT_VOP_ELOCKED(vp, "nfsrv_openupdate"); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); if (nfsrv_freeopen(stp, vp, 1, p) == 0) { NFSLOCKSTATE(); nfsrv_unlocklf(lfp); @@ -4979,7 +4979,7 @@ nfsrv_updatestable(NFSPROC_T *p) if (NFSVOPLOCK(vp, LK_EXCLUSIVE) == 0) { error = nfsvno_setattr(vp, &nva, NFSFPCRED(sf->nsf_fp), p, NULL); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } else error = EPERM; vn_finished_write(mp); @@ -5156,7 +5156,7 @@ nfsrv_clientconflict(struct nfsclient *clp, int *haslockp, vnode_t vp, NFSUNLOCKSTATE(); if (vp != NULL) { lktype = NFSVOPISLOCKED(vp); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } NFSLOCKV4ROOTMUTEX(); nfsv4_relref(&nfsv4rootfs_lock); @@ -5331,7 +5331,7 @@ nfsrv_delegconflict(struct nfsstate *stp, int *haslockp, NFSPROC_T *p, NFSUNLOCKSTATE(); if (vp != NULL) { lktype = NFSVOPISLOCKED(vp); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } NFSLOCKV4ROOTMUTEX(); nfsv4_relref(&nfsv4rootfs_lock); @@ -5566,7 +5566,7 @@ nfsd_recalldelegation(vnode_t vp, NFSPROC_T *p) if (NFSVOPLOCK(vp, LK_EXCLUSIVE) == 0) { error = nfsrv_checkremove(vp, 0, NULL, (nfsquad_t)((u_quad_t)0), p); - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); } else error = EPERM; if (error == NFSERR_DELAY) { @@ -7600,7 +7600,7 @@ nfsrv_setdsserver(char *dspathp, char *mdspathp, NFSPROC_T *p, M_NFSDSTATE, M_WAITOK | M_ZERO); ds->nfsdev_dvp = nd.ni_vp; ds->nfsdev_nmp = VFSTONFS(nd.ni_vp->v_mount); - NFSVOPUNLOCK(nd.ni_vp, 0); + NFSVOPUNLOCK(nd.ni_vp); dsdirsize = strlen(dspathp) + 16; dsdirpath = malloc(dsdirsize, M_TEMP, M_WAITOK); @@ -7626,7 +7626,7 @@ nfsrv_setdsserver(char *dspathp, char *mdspathp, NFSPROC_T *p, break; } ds->nfsdev_dsdir[i] = nd.ni_vp; - NFSVOPUNLOCK(nd.ni_vp, 0); + NFSVOPUNLOCK(nd.ni_vp); } free(dsdirpath, M_TEMP); @@ -8241,7 +8241,7 @@ nfsrv_copymr(vnode_t vp, vnode_t fvp, vnode_t dvp, struct nfsdevice *ds, didprintf = 0; TAILQ_INIT(&thl); /* Unlock the MDS vp, so that a LayoutReturn can be done on it. */ - NFSVOPUNLOCK(vp, 0); + NFSVOPUNLOCK(vp); /* Now, do a recall for all layouts not yet recalled. */ tryagain: NFSDRECALLLOCK(); diff --git a/sys/fs/nullfs/null_vfsops.c b/sys/fs/nullfs/null_vfsops.c index 352fa84c35b4..1ab8e8562fdc 100644 --- a/sys/fs/nullfs/null_vfsops.c +++ b/sys/fs/nullfs/null_vfsops.c @@ -113,7 +113,7 @@ nullfs_mount(struct mount *mp) */ if (mp->mnt_vnodecovered->v_op == &null_vnodeops && VOP_ISLOCKED(mp->mnt_vnodecovered) == LK_EXCLUSIVE) { - VOP_UNLOCK(mp->mnt_vnodecovered, 0); + VOP_UNLOCK(mp->mnt_vnodecovered); isvnunlocked = true; } else { isvnunlocked = false; @@ -186,7 +186,7 @@ nullfs_mount(struct mount *mp) /* * Unlock the node (either the lower or the alias) */ - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); if (NULLVPTOLOWERVP(nullm_rootvp)->v_mount->mnt_flag & MNT_LOCAL) { MNT_ILOCK(mp); @@ -444,7 +444,7 @@ nullfs_unlink_lowervp(struct mount *mp, struct vnode *lowervp) */ KASSERT(VN_IS_DOOMED(vp), ("not reclaimed nullfs vnode %p", vp)); - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); } else { /* * Otherwise, the nullfs vnode still shares the lock diff --git a/sys/fs/nullfs/null_vnops.c b/sys/fs/nullfs/null_vnops.c index 84c32d4145a9..7ca56ce700b5 100644 --- a/sys/fs/nullfs/null_vnops.c +++ b/sys/fs/nullfs/null_vnops.c @@ -410,7 +410,7 @@ null_lookup(struct vop_lookup_args *ap) * ldvp and locking dvp, which is also correct if the * locks are still shared. */ - VOP_UNLOCK(ldvp, 0); + VOP_UNLOCK(ldvp); vn_lock(dvp, LK_EXCLUSIVE | LK_RETRY); } vdrop(ldvp); @@ -690,7 +690,7 @@ null_lock(struct vop_lock1_args *ap) panic("Unsupported lock request %d\n", ap->a_flags); } - VOP_UNLOCK(lvp, 0); + VOP_UNLOCK(lvp); error = vop_stdlock(ap); } vdrop(lvp); @@ -718,7 +718,7 @@ null_unlock(struct vop_unlock_args *ap) nn = VTONULL(vp); if (nn != NULL && (lvp = NULLVPTOLOWERVP(vp)) != NULL) { vholdnz(lvp); - error = VOP_UNLOCK(lvp, 0); + error = VOP_UNLOCK(lvp); vdrop(lvp); } else { error = vop_stdunlock(ap); @@ -884,7 +884,7 @@ null_vptocnp(struct vop_vptocnp_args *ap) vhold(lvp); mp = vp->v_mount; vfs_ref(mp); - VOP_UNLOCK(vp, 0); /* vp is held by vn_vptocnp_locked that called us */ + VOP_UNLOCK(vp); /* vp is held by vn_vptocnp_locked that called us */ ldvp = lvp; vref(lvp); error = vn_vptocnp(&ldvp, cred, ap->a_buf, ap->a_buflen); @@ -907,7 +907,7 @@ null_vptocnp(struct vop_vptocnp_args *ap) #ifdef DIAGNOSTIC NULLVPTOLOWERVP(*dvp); #endif - VOP_UNLOCK(*dvp, 0); /* keep reference on *dvp */ + VOP_UNLOCK(*dvp); /* keep reference on *dvp */ } vn_lock(vp, locked | LK_RETRY); vfs_rel(mp); diff --git a/sys/fs/pseudofs/pseudofs_vncache.c b/sys/fs/pseudofs/pseudofs_vncache.c index 58e75daf75db..1a127e5e1998 100644 --- a/sys/fs/pseudofs/pseudofs_vncache.c +++ b/sys/fs/pseudofs/pseudofs_vncache.c @@ -291,7 +291,7 @@ pfs_purge_one(struct vnode *vnp) VOP_LOCK(vnp, LK_EXCLUSIVE); vgone(vnp); - VOP_UNLOCK(vnp, 0); + VOP_UNLOCK(vnp); vdrop(vnp); } diff --git a/sys/fs/pseudofs/pseudofs_vnops.c b/sys/fs/pseudofs/pseudofs_vnops.c index dfacc6621ea9..b0e23c38acd9 100644 --- a/sys/fs/pseudofs/pseudofs_vnops.c +++ b/sys/fs/pseudofs/pseudofs_vnops.c @@ -291,7 +291,7 @@ pfs_ioctl(struct vop_ioctl_args *va) vn = va->a_vp; vn_lock(vn, LK_SHARED | LK_RETRY); if (VN_IS_DOOMED(vn)) { - VOP_UNLOCK(vn, 0); + VOP_UNLOCK(vn); return (EBADF); } pvd = vn->v_data; @@ -301,13 +301,13 @@ pfs_ioctl(struct vop_ioctl_args *va) pfs_assert_not_owned(pn); if (vn->v_type != VREG) { - VOP_UNLOCK(vn, 0); + VOP_UNLOCK(vn); PFS_RETURN (EINVAL); } KASSERT_PN_IS_FILE(pn); if (pn->pn_ioctl == NULL) { - VOP_UNLOCK(vn, 0); + VOP_UNLOCK(vn); PFS_RETURN (ENOTTY); } @@ -316,7 +316,7 @@ pfs_ioctl(struct vop_ioctl_args *va) * have changed since the open() call. */ if (!pfs_visible(curthread, pn, pvd->pvd_pid, &proc)) { - VOP_UNLOCK(vn, 0); + VOP_UNLOCK(vn); PFS_RETURN (EIO); } @@ -325,7 +325,7 @@ pfs_ioctl(struct vop_ioctl_args *va) if (proc != NULL) PROC_UNLOCK(proc); - VOP_UNLOCK(vn, 0); + VOP_UNLOCK(vn); PFS_RETURN (error); } @@ -422,7 +422,7 @@ pfs_vptocnp(struct vop_vptocnp_args *ap) * vp is held by caller. */ locked = VOP_ISLOCKED(vp); - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); error = pfs_vncache_alloc(mp, dvp, pn, pid); if (error) { @@ -432,7 +432,7 @@ pfs_vptocnp(struct vop_vptocnp_args *ap) } *buflen = i; - VOP_UNLOCK(*dvp, 0); + VOP_UNLOCK(*dvp); vn_lock(vp, locked | LK_RETRY); vfs_unbusy(mp); @@ -506,7 +506,7 @@ pfs_lookup(struct vop_cachedlookup_args *va) error = vfs_busy(mp, MBF_NOWAIT); if (error != 0) { vfs_ref(mp); - VOP_UNLOCK(vn, 0); + VOP_UNLOCK(vn); error = vfs_busy(mp, 0); vn_lock(vn, LK_EXCLUSIVE | LK_RETRY); vfs_rel(mp); @@ -517,7 +517,7 @@ pfs_lookup(struct vop_cachedlookup_args *va) PFS_RETURN(ENOENT); } } - VOP_UNLOCK(vn, 0); + VOP_UNLOCK(vn); KASSERT(pd->pn_parent != NULL, ("%s(): non-root directory has no parent", __func__)); /* @@ -666,7 +666,7 @@ pfs_read(struct vop_read_args *va) vhold(vn); locked = VOP_ISLOCKED(vn); - VOP_UNLOCK(vn, 0); + VOP_UNLOCK(vn); if (pn->pn_flags & PFS_RAWRD) { PFS_TRACE(("%zd resid", uio->uio_resid)); @@ -944,7 +944,7 @@ pfs_readlink(struct vop_readlink_args *va) } vhold(vn); locked = VOP_ISLOCKED(vn); - VOP_UNLOCK(vn, 0); + VOP_UNLOCK(vn); /* sbuf_new() can't fail with a static buffer */ sbuf_new(&sb, buf, sizeof buf, 0); diff --git a/sys/fs/smbfs/smbfs_vfsops.c b/sys/fs/smbfs/smbfs_vfsops.c index 186c004e309a..9671eae94220 100644 --- a/sys/fs/smbfs/smbfs_vfsops.c +++ b/sys/fs/smbfs/smbfs_vfsops.c @@ -234,7 +234,7 @@ smbfs_mount(struct mount *mp) vfs_mount_error(mp, "smbfs_root error: %d", error); goto bad; } - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); SMBVDEBUG("root.v_usecount = %d\n", vrefcnt(vp)); #ifdef DIAGNOSTIC diff --git a/sys/fs/smbfs/smbfs_vnops.c b/sys/fs/smbfs/smbfs_vnops.c index 964512541a9b..3a0c207f685c 100644 --- a/sys/fs/smbfs/smbfs_vnops.c +++ b/sys/fs/smbfs/smbfs_vnops.c @@ -1338,7 +1338,7 @@ smbfs_lookup(ap) error = vfs_busy(mp, MBF_NOWAIT); if (error != 0) { vfs_ref(mp); - VOP_UNLOCK(dvp, 0); + VOP_UNLOCK(dvp); error = vfs_busy(mp, 0); vn_lock(dvp, LK_EXCLUSIVE | LK_RETRY); vfs_rel(mp); @@ -1352,7 +1352,7 @@ smbfs_lookup(ap) goto out; } } - VOP_UNLOCK(dvp, 0); + VOP_UNLOCK(dvp); error = smbfs_nget(mp, dvp, name, nmlen, NULL, &vp); vfs_unbusy(mp); vn_lock(dvp, LK_EXCLUSIVE | LK_RETRY); diff --git a/sys/fs/tmpfs/tmpfs_vfsops.c b/sys/fs/tmpfs/tmpfs_vfsops.c index 8133f6f08b5f..d3f700407463 100644 --- a/sys/fs/tmpfs/tmpfs_vfsops.c +++ b/sys/fs/tmpfs/tmpfs_vfsops.c @@ -374,7 +374,7 @@ tmpfs_mount(struct mount *mp) vn_lock(mp->mnt_vnodecovered, LK_SHARED | LK_RETRY); error = VOP_GETATTR(mp->mnt_vnodecovered, &va, mp->mnt_cred); - VOP_UNLOCK(mp->mnt_vnodecovered, 0); + VOP_UNLOCK(mp->mnt_vnodecovered); if (error) return (error); diff --git a/sys/fs/tmpfs/tmpfs_vnops.c b/sys/fs/tmpfs/tmpfs_vnops.c index d70797e9a9a5..0ae45779c673 100644 --- a/sys/fs/tmpfs/tmpfs_vnops.c +++ b/sys/fs/tmpfs/tmpfs_vnops.c @@ -674,9 +674,9 @@ tmpfs_rename_relock(struct vnode *fdvp, struct vnode **fvpp, struct tmpfs_dirent *de; int error, restarts = 0; - VOP_UNLOCK(tdvp, 0); + VOP_UNLOCK(tdvp); if (*tvpp != NULL && *tvpp != tdvp) - VOP_UNLOCK(*tvpp, 0); + VOP_UNLOCK(*tvpp); mp = fdvp->v_mount; relock: @@ -685,11 +685,11 @@ relock: if (error) goto releout; if (vn_lock(tdvp, LK_EXCLUSIVE | LK_NOWAIT) != 0) { - VOP_UNLOCK(fdvp, 0); + VOP_UNLOCK(fdvp); error = vn_lock(tdvp, LK_EXCLUSIVE); if (error) goto releout; - VOP_UNLOCK(tdvp, 0); + VOP_UNLOCK(tdvp); goto relock; } /* @@ -698,8 +698,8 @@ relock: */ de = tmpfs_dir_lookup(VP_TO_TMPFS_DIR(fdvp), NULL, fcnp); if (de == NULL) { - VOP_UNLOCK(fdvp, 0); - VOP_UNLOCK(tdvp, 0); + VOP_UNLOCK(fdvp); + VOP_UNLOCK(tdvp); if ((fcnp->cn_flags & ISDOTDOT) != 0 || (fcnp->cn_namelen == 1 && fcnp->cn_nameptr[0] == '.')) error = EINVAL; @@ -709,14 +709,14 @@ relock: } error = tmpfs_alloc_vp(mp, de->td_node, LK_EXCLUSIVE | LK_NOWAIT, &nvp); if (error != 0) { - VOP_UNLOCK(fdvp, 0); - VOP_UNLOCK(tdvp, 0); + VOP_UNLOCK(fdvp); + VOP_UNLOCK(tdvp); if (error != EBUSY) goto releout; error = tmpfs_alloc_vp(mp, de->td_node, LK_EXCLUSIVE, &nvp); if (error != 0) goto releout; - VOP_UNLOCK(nvp, 0); + VOP_UNLOCK(nvp); /* * Concurrent rename race. */ @@ -731,7 +731,7 @@ relock: } vrele(*fvpp); *fvpp = nvp; - VOP_UNLOCK(*fvpp, 0); + VOP_UNLOCK(*fvpp); /* * Re-resolve tvp and acquire the vnode lock if present. */ @@ -755,15 +755,15 @@ relock: vrele(*tvpp); *tvpp = nvp; if (error != 0) { - VOP_UNLOCK(fdvp, 0); - VOP_UNLOCK(tdvp, 0); + VOP_UNLOCK(fdvp); + VOP_UNLOCK(tdvp); if (error != EBUSY) goto releout; error = tmpfs_alloc_vp(mp, de->td_node, LK_EXCLUSIVE, &nvp); if (error != 0) goto releout; - VOP_UNLOCK(nvp, 0); + VOP_UNLOCK(nvp); /* * fdvp contains fvp, thus tvp (=fdvp) is not empty. */ @@ -1062,7 +1062,7 @@ tmpfs_rename(struct vop_rename_args *v) out_locked: if (fdvp != tdvp && fdvp != tvp) - VOP_UNLOCK(fdvp, 0); + VOP_UNLOCK(fdvp); out: /* @@ -1513,7 +1513,7 @@ tmpfs_vptocnp_fill(struct vnode *vp, struct tmpfs_node *tn, } if (error == 0) { if (vp != *dvp) - VOP_UNLOCK(*dvp, 0); + VOP_UNLOCK(*dvp); } else { if (vp != *dvp) vput(*dvp); diff --git a/sys/fs/udf/udf_vfsops.c b/sys/fs/udf/udf_vfsops.c index 45331dedab14..0f30b5ef36e9 100644 --- a/sys/fs/udf/udf_vfsops.c +++ b/sys/fs/udf/udf_vfsops.c @@ -330,7 +330,7 @@ udf_mountfs(struct vnode *devvp, struct mount *mp) g_topology_lock(); error = g_vfs_open(devvp, &cp, "udf", 0); g_topology_unlock(); - VOP_UNLOCK(devvp, 0); + VOP_UNLOCK(devvp); if (error) goto bail; diff --git a/sys/fs/unionfs/union_subr.c b/sys/fs/unionfs/union_subr.c index cc2d41768f73..09064f16550d 100644 --- a/sys/fs/unionfs/union_subr.c +++ b/sys/fs/unionfs/union_subr.c @@ -361,9 +361,9 @@ unionfs_noderem(struct vnode *vp, struct thread *td) VI_UNLOCK(vp); if (lvp != NULLVP) - VOP_UNLOCK(lvp, 0); + VOP_UNLOCK(lvp); if (uvp != NULLVP) - VOP_UNLOCK(uvp, 0); + VOP_UNLOCK(uvp); if (dvp != NULLVP && unp->un_hash.le_prev != NULL) unionfs_rem_cached_vnode(unp, dvp); @@ -551,7 +551,7 @@ unionfs_relookup(struct vnode *dvp, struct vnode **vpp, cn->cn_flags |= NOCACHE; vref(dvp); - VOP_UNLOCK(dvp, 0); + VOP_UNLOCK(dvp); if ((error = relookup(dvp, vpp, cn))) { uma_zfree(namei_zone, cn->cn_pnbuf); @@ -961,7 +961,7 @@ unionfs_vn_create_on_upper(struct vnode **vpp, struct vnode *udvp, } unionfs_vn_create_on_upper_free_out1: - VOP_UNLOCK(udvp, 0); + VOP_UNLOCK(udvp); unionfs_vn_create_on_upper_free_out2: if (cn.cn_flags & HASBUF) { diff --git a/sys/fs/unionfs/union_vfsops.c b/sys/fs/unionfs/union_vfsops.c index b4b24dddb937..600b8dc86488 100644 --- a/sys/fs/unionfs/union_vfsops.c +++ b/sys/fs/unionfs/union_vfsops.c @@ -167,7 +167,7 @@ unionfs_domount(struct mount *mp) uid = va.va_uid; gid = va.va_gid; } - VOP_UNLOCK(mp->mnt_vnodecovered, 0); + VOP_UNLOCK(mp->mnt_vnodecovered); if (error) return (error); @@ -252,7 +252,7 @@ unionfs_domount(struct mount *mp) * Save reference */ if (below) { - VOP_UNLOCK(upperrootvp, 0); + VOP_UNLOCK(upperrootvp); vn_lock(lowerrootvp, LK_EXCLUSIVE | LK_RETRY); ump->um_lowervp = upperrootvp; ump->um_uppervp = lowerrootvp; @@ -278,7 +278,7 @@ unionfs_domount(struct mount *mp) /* * Unlock the node */ - VOP_UNLOCK(ump->um_uppervp, 0); + VOP_UNLOCK(ump->um_uppervp); /* * Get the unionfs root vnode. diff --git a/sys/fs/unionfs/union_vnops.c b/sys/fs/unionfs/union_vnops.c index 2bc006137fe9..e180f3c38d59 100644 --- a/sys/fs/unionfs/union_vnops.c +++ b/sys/fs/unionfs/union_vnops.c @@ -128,7 +128,7 @@ unionfs_lookup(struct vop_cachedlookup_args *ap) if (udvp != NULLVP) { dtmpvp = udvp; if (ldvp != NULLVP) - VOP_UNLOCK(ldvp, 0); + VOP_UNLOCK(ldvp); } else dtmpvp = ldvp; @@ -136,7 +136,7 @@ unionfs_lookup(struct vop_cachedlookup_args *ap) error = VOP_LOOKUP(dtmpvp, &vp, cnp); if (dtmpvp == udvp && ldvp != NULLVP) { - VOP_UNLOCK(udvp, 0); + VOP_UNLOCK(udvp); vn_lock(dvp, LK_EXCLUSIVE | LK_RETRY); } @@ -148,10 +148,10 @@ unionfs_lookup(struct vop_cachedlookup_args *ap) */ if (nameiop == DELETE || nameiop == RENAME || (cnp->cn_lkflags & LK_TYPE_MASK)) - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); vrele(vp); - VOP_UNLOCK(dvp, 0); + VOP_UNLOCK(dvp); *(ap->a_vpp) = dunp->un_dvp; vref(dunp->un_dvp); @@ -188,7 +188,7 @@ unionfs_lookup(struct vop_cachedlookup_args *ap) } if (nameiop == DELETE || nameiop == RENAME || (cnp->cn_lkflags & LK_TYPE_MASK)) - VOP_UNLOCK(uvp, 0); + VOP_UNLOCK(uvp); } /* check whiteout */ @@ -232,7 +232,7 @@ unionfs_lookup(struct vop_cachedlookup_args *ap) return (lerror); } if (cnp->cn_lkflags & LK_TYPE_MASK) - VOP_UNLOCK(lvp, 0); + VOP_UNLOCK(lvp); } } @@ -267,7 +267,7 @@ unionfs_lookup(struct vop_cachedlookup_args *ap) goto unionfs_lookup_out; if (LK_SHARED == (cnp->cn_lkflags & LK_TYPE_MASK)) - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); if (LK_EXCLUSIVE != VOP_ISLOCKED(vp)) { vn_lock(vp, LK_EXCLUSIVE | LK_RETRY); lockflag = 1; @@ -275,7 +275,7 @@ unionfs_lookup(struct vop_cachedlookup_args *ap) error = unionfs_mkshadowdir(MOUNTTOUNIONFSMOUNT(dvp->v_mount), udvp, VTOUNIONFS(vp), cnp, td); if (lockflag != 0) - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); if (error != 0) { UNIONFSDEBUG("unionfs_lookup: Unable to create shadow dir."); if ((cnp->cn_lkflags & LK_TYPE_MASK) == LK_EXCLUSIVE) @@ -372,7 +372,7 @@ unionfs_create(struct vop_create_args *ap) if (vp->v_type == VSOCK) *(ap->a_vpp) = vp; else { - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); error = unionfs_nodeget(ap->a_dvp->v_mount, vp, NULLVP, ap->a_dvp, ap->a_vpp, cnp, curthread); vrele(vp); @@ -446,7 +446,7 @@ unionfs_mknod(struct vop_mknod_args *ap) if (vp->v_type == VSOCK) *(ap->a_vpp) = vp; else { - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); error = unionfs_nodeget(ap->a_dvp->v_mount, vp, NULLVP, ap->a_dvp, ap->a_vpp, cnp, curthread); vrele(vp); @@ -903,7 +903,7 @@ unionfs_ioctl(struct vop_ioctl_args *ap) unionfs_get_node_status(unp, ap->a_td, &unsp); ovp = (unsp->uns_upper_opencnt ? unp->un_uppervp : unp->un_lowervp); unionfs_tryrem_node_status(unp, unsp); - VOP_UNLOCK(ap->a_vp, 0); + VOP_UNLOCK(ap->a_vp); if (ovp == NULLVP) return (EBADF); @@ -930,7 +930,7 @@ unionfs_poll(struct vop_poll_args *ap) unionfs_get_node_status(unp, ap->a_td, &unsp); ovp = (unsp->uns_upper_opencnt ? unp->un_uppervp : unp->un_lowervp); unionfs_tryrem_node_status(unp, unsp); - VOP_UNLOCK(ap->a_vp, 0); + VOP_UNLOCK(ap->a_vp); if (ovp == NULLVP) return (EBADF); @@ -990,7 +990,7 @@ unionfs_remove(struct vop_remove_args *ap) ump = NULL; vp = uvp = lvp = NULLVP; /* search vnode */ - VOP_UNLOCK(ap->a_vp, 0); + VOP_UNLOCK(ap->a_vp); error = unionfs_relookup(udvp, &vp, cnp, &cn, td, cnp->cn_nameptr, strlen(cnp->cn_nameptr), DELETE); if (error != 0 && error != ENOENT) { @@ -1193,7 +1193,7 @@ unionfs_rename(struct vop_rename_args *ap) if ((error = vn_lock(fvp, LK_EXCLUSIVE)) != 0) goto unionfs_rename_abort; error = unionfs_copyfile(unp, 1, fcnp->cn_cred, td); - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); if (error != 0) goto unionfs_rename_abort; break; @@ -1201,7 +1201,7 @@ unionfs_rename(struct vop_rename_args *ap) if ((error = vn_lock(fvp, LK_EXCLUSIVE)) != 0) goto unionfs_rename_abort; error = unionfs_mkshadowdir(ump, rfdvp, unp, fcnp, td); - VOP_UNLOCK(fvp, 0); + VOP_UNLOCK(fvp); if (error != 0) goto unionfs_rename_abort; break; @@ -1258,13 +1258,13 @@ unionfs_rename(struct vop_rename_args *ap) if ((error = vn_lock(fdvp, LK_EXCLUSIVE)) != 0) goto unionfs_rename_abort; error = unionfs_relookup_for_delete(fdvp, fcnp, td); - VOP_UNLOCK(fdvp, 0); + VOP_UNLOCK(fdvp); if (error != 0) goto unionfs_rename_abort; /* Locke of tvp is canceled in order to avoid recursive lock. */ if (tvp != NULLVP && tvp != tdvp) - VOP_UNLOCK(tvp, 0); + VOP_UNLOCK(tvp); error = unionfs_relookup_for_rename(tdvp, tcnp, td); if (tvp != NULLVP && tvp != tdvp) vn_lock(tvp, LK_EXCLUSIVE | LK_RETRY); @@ -1282,11 +1282,11 @@ unionfs_rename(struct vop_rename_args *ap) } if (ltdvp != NULLVP) - VOP_UNLOCK(ltdvp, 0); + VOP_UNLOCK(ltdvp); if (tdvp != rtdvp) vrele(tdvp); if (ltvp != NULLVP) - VOP_UNLOCK(ltvp, 0); + VOP_UNLOCK(ltvp); if (tvp != rtvp && tvp != NULLVP) { if (rtvp == NULLVP) vput(tvp); @@ -1360,7 +1360,7 @@ unionfs_mkdir(struct vop_mkdir_args *ap) } if ((error = VOP_MKDIR(udvp, &uvp, cnp, ap->a_vap)) == 0) { - VOP_UNLOCK(uvp, 0); + VOP_UNLOCK(uvp); cnp->cn_lkflags = LK_EXCLUSIVE; error = unionfs_nodeget(ap->a_dvp->v_mount, uvp, NULLVP, ap->a_dvp, ap->a_vpp, cnp, td); @@ -1458,7 +1458,7 @@ unionfs_symlink(struct vop_symlink_args *ap) if (udvp != NULLVP) { error = VOP_SYMLINK(udvp, &uvp, cnp, ap->a_vap, ap->a_target); if (error == 0) { - VOP_UNLOCK(uvp, 0); + VOP_UNLOCK(uvp); cnp->cn_lkflags = LK_EXCLUSIVE; error = unionfs_nodeget(ap->a_dvp->v_mount, uvp, NULLVP, ap->a_dvp, ap->a_vpp, cnp, td); @@ -1884,12 +1884,12 @@ unionfs_lock(struct vop_lock1_args *ap) /* Share Lock is once released and a deadlock is avoided. */ vholdnz(uvp); uhold = 1; - VOP_UNLOCK(uvp, 0); + VOP_UNLOCK(uvp); unp = VTOUNIONFS(vp); if (unp == NULL) { /* vnode is released. */ VI_UNLOCK(vp); - VOP_UNLOCK(lvp, 0); + VOP_UNLOCK(lvp); vdrop(uvp); return (EBUSY); } @@ -1909,7 +1909,7 @@ unionfs_lock(struct vop_lock1_args *ap) /* vnode is released. */ VI_UNLOCK(vp); if (error == 0) - VOP_UNLOCK(lvp, 0); + VOP_UNLOCK(lvp); vdrop(lvp); if (uhold != 0) vdrop(uvp); @@ -1940,10 +1940,10 @@ unionfs_lock(struct vop_lock1_args *ap) /* vnode is released. */ VI_UNLOCK(vp); if (error == 0) - VOP_UNLOCK(uvp, 0); + VOP_UNLOCK(uvp); vdrop(uvp); if (lvp != NULLVP) { - VOP_UNLOCK(lvp, 0); + VOP_UNLOCK(lvp); vdrop(lvp); } return (vop_stdlock(ap)); @@ -1994,13 +1994,13 @@ unionfs_unlock(struct vop_unlock_args *ap) if (lvp != NULLVP) { vholdnz(lvp); - error = VOP_UNLOCK(lvp, 0); + error = VOP_UNLOCK(lvp); } if (error == 0 && uvp != NULLVP) { vholdnz(uvp); uhold = 1; - error = VOP_UNLOCK(uvp, 0); + error = VOP_UNLOCK(uvp); } if (lvp != NULLVP) @@ -2070,7 +2070,7 @@ unionfs_advlock(struct vop_advlock_args *ap) unionfs_tryrem_node_status(unp, unsp); } - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); error = VOP_ADVLOCK(uvp, ap->a_id, ap->a_op, ap->a_fl, ap->a_flags); @@ -2079,7 +2079,7 @@ unionfs_advlock(struct vop_advlock_args *ap) return error; unionfs_advlock_abort: - VOP_UNLOCK(vp, 0); + VOP_UNLOCK(vp); UNIONFS_INTERNAL_DEBUG("unionfs_advlock: leave (%d)\n", error); |