diff options
| author | Robert Watson <rwatson@FreeBSD.org> | 2005-08-03 00:18:35 +0000 |
|---|---|---|
| committer | Robert Watson <rwatson@FreeBSD.org> | 2005-08-03 00:18:35 +0000 |
| commit | 13b203d0d78cc08a7e0da8e8d5eb8c1a5d94ab69 (patch) | |
| tree | 9a4e586ffbcd1450917ee5e388a4e1eb38254e32 /sys/dev/awi | |
| parent | bccb41014af4667b1cf2878456f5a8a854acf1f7 (diff) | |
Modify device drivers supporting multicast addresses to lock if_addr_mtx
over iteration of their multicast address lists when synchronizing the
hardware address filter with the network stack-maintained list.
Problem reported by: Ed Maste (emaste at phaedrus dot sandvine dot ca>
MFC after: 1 week
Notes
Notes:
svn path=/head/; revision=148654
Diffstat (limited to 'sys/dev/awi')
| -rw-r--r-- | sys/dev/awi/awi.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/sys/dev/awi/awi.c b/sys/dev/awi/awi.c index 4c0ffc261773..838e3fb3793c 100644 --- a/sys/dev/awi/awi.c +++ b/sys/dev/awi/awi.c @@ -1146,15 +1146,19 @@ awi_mode_init(struct awi_softc *sc) #ifdef __FreeBSD__ if (ifp->if_flags & IFF_ALLMULTI) goto set_mib; + IF_ADDR_LOCK(ifp); TAILQ_FOREACH(ifma, &ifp->if_multiaddrs, ifma_link) { if (ifma->ifma_addr->sa_family != AF_LINK) continue; - if (n == AWI_GROUP_ADDR_SIZE) + if (n == AWI_GROUP_ADDR_SIZE) { + IF_ADDR_UNLOCK(ifp); goto set_mib; + } IEEE80211_ADDR_COPY(sc->sc_mib_addr.aGroup_Addresses[n], LLADDR((struct sockaddr_dl *)ifma->ifma_addr)); n++; } + IF_ADDR_UNLOCK(ifp); #else ETHER_FIRST_MULTI(step, &sc->sc_ic.ic_ec, enm); while (enm != NULL) { |