diff options
| author | Brian Behlendorf <behlendorf1@llnl.gov> | 2012-03-14 19:36:49 +0000 |
|---|---|---|
| committer | Brian Behlendorf <behlendorf1@llnl.gov> | 2012-03-15 22:18:29 +0000 |
| commit | 77a405ae52e4a902f7cc3790e2a73d044c66d962 (patch) | |
| tree | b2c4a6c40139ec4c9b44fdb3d812993cbd839cf0 | |
| parent | 42cb3819f1a1f536105faac81ffc150f3da90a80 (diff) | |
Add missing NULL in zpl_xattr_handlers
The xattr_resolve_name() helper function expects the registered
list of xattr handlers to be NULL terminated. This NULL was
accidentally missing which could result in a NULL dereference.
Interestingly this issue only manifested itself on certain 32-bit
systems. Presumably on 64-bit kernels we just always happen to
get lucky and the memory following the structure is zeroed.
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #594
| -rw-r--r-- | module/zfs/zpl_xattr.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/module/zfs/zpl_xattr.c b/module/zfs/zpl_xattr.c index dbe61df98cf0..c03764fc507f 100644 --- a/module/zfs/zpl_xattr.c +++ b/module/zfs/zpl_xattr.c @@ -674,4 +674,5 @@ xattr_handler_t *zpl_xattr_handlers[] = { &zpl_xattr_acl_access_handler, &zpl_xattr_acl_default_handler, #endif /* HAVE_POSIX_ACLS */ + NULL }; |